Re: [PATCH] spi: tegra: Fix a memory leak in tegra_slink_probe()

[Jon Hunter <jonathanh@nvidia.com>]

On 02/02/2026 15:15, Felix Gu wrote:
> In tegra_slink_probe(), when platform_get_irq() fails, it directly
> returns from the function with an error code, which causes a memory leak.
> 
> Replace it with a goto label to ensure proper cleanup.
> 
> Fixes: eb9913b511f1 ("spi: tegra: Fix missing IRQ check in tegra_slink_probe()")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
>   drivers/spi/spi-tegra20-slink.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index 7d6f3fe8b7e3..8c608abd6076 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -1086,8 +1086,10 @@ static int tegra_slink_probe(struct platform_device *pdev)
>   	reset_control_deassert(tspi->rst);
>   
>   	spi_irq = platform_get_irq(pdev, 0);
> -	if (spi_irq < 0)
> -		return spi_irq;
> +	if (spi_irq < 0) {
> +		ret = spi_irq;
> +		goto exit_pm_put;
> +	}
>   	tspi->irq = spi_irq;
>   	ret = request_threaded_irq(tspi->irq, tegra_slink_isr,
>   				   tegra_slink_isr_thread, IRQF_ONESHOT,
> 
> ---
> base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
> change-id: 20260202-slink-a229f708611d


We could get rid of this 'spi_irq' variable and just use 'ret', but that 
is another clean-up. Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic