From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-pm@vger.kernel.org, Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Angus Ainslie <angus@akkea.ca>, dl-linux-imx <linux-imx@nxp.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/13] thermal: qoriq: Convert driver to use regmap API
Date: Thu, 11 Apr 2019 15:00:51 +0200 [thread overview]
Message-ID: <dac3e90a-dd9f-56eb-faa2-c48d1fe380da@linaro.org> (raw)
In-Reply-To: <CAHQ1cqGbBXdQBagcKH211N0GkBzQzsutbu6=FMLLxZoL8pL8bA@mail.gmail.com>
On 05/04/2019 20:24, Andrey Smirnov wrote:
[ ... ]
>>> +static const struct regmap_range qiriq_yes_ranges[] = {
>>> + regmap_reg_range(REGS_TMR, REGS_TSCFGR),
>>> + regmap_reg_range(REGS_TTRnCR(0), REGS_TTRnCR(3)),
>>> + /* Read only registers below */
>>> + regmap_reg_range(REGS_TRITSR(0), REGS_TRITSR(15)),
>>> +};
>>> +
>>> +static const struct regmap_access_table qiriq_wr_table = {
>>> + .yes_ranges = qiriq_yes_ranges,
>>> + .n_yes_ranges = ARRAY_SIZE(qiriq_yes_ranges) - 1,
>>> +};
>>> +
>>> +static const struct regmap_access_table qiriq_rd_table = {
>>> + .yes_ranges = qiriq_yes_ranges,
>>> + .n_yes_ranges = ARRAY_SIZE(qiriq_yes_ranges),
>>> +};
>>
>> As the table are the same, it would make sense to fold both structure to
>> a single one (and s/qiriq/qoriq/ ?)
>>
>
> Writable registers are a subset of readable registers and n_yes_ranges
> is different between the two. Not sure how I could fold the two into a
> single struct.
Right, never mind my comment.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-04-11 13:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 4:14 [PATCH v3 00/13] QorIQ TMU multi-sensor and HWMON support Andrey Smirnov
2019-04-01 4:14 ` [PATCH v3 01/13] thermal: qoriq: Remove unnecessary DT node is NULL check Andrey Smirnov
2019-04-04 3:21 ` Daniel Lezcano
2019-04-05 17:51 ` Andrey Smirnov
2019-04-11 16:52 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 02/13] thermal: qoriq: Add local struct device pointer Andrey Smirnov
2019-04-04 3:11 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 03/13] thermal: qoriq: Don't store struct thermal_zone_device reference Andrey Smirnov
2019-04-04 3:23 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 04/13] thermal: qoriq: Add local struct qoriq_sensor pointer Andrey Smirnov
2019-04-04 3:28 ` Daniel Lezcano
2019-04-05 17:57 ` Andrey Smirnov
2019-04-01 4:14 ` [PATCH v3 05/13] thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data Andrey Smirnov
2019-04-04 7:57 ` Daniel Lezcano
2019-04-04 8:06 ` [PATCH RFC 1/2] thermal/drivers/of: Add a get_temp_id callback function Daniel Lezcano
2019-04-04 8:06 ` [PATCH RFC 2/2] thermal/drivers/qoriq: Use the get_temp_id() Daniel Lezcano
2019-04-13 8:18 ` [PATCH RFC 1/2] thermal/drivers/of: Add a get_temp_id callback function Andrey Smirnov
2019-04-13 8:28 ` Daniel Lezcano
2019-04-05 18:00 ` [PATCH v3 05/13] thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data Andrey Smirnov
2019-04-11 16:54 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 06/13] thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly Andrey Smirnov
2019-04-04 8:09 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 07/13] thermal: qoriq: Pass data to qoriq_tmu_calibration() directly Andrey Smirnov
2019-04-04 8:11 ` Daniel Lezcano
2019-04-05 18:04 ` Andrey Smirnov
2019-04-01 4:14 ` [PATCH v3 08/13] thermal: qoriq: Convert driver to use devm_ioremap() Andrey Smirnov
2019-04-04 8:23 ` Daniel Lezcano
2019-04-05 18:14 ` Andrey Smirnov
2019-04-01 4:14 ` [PATCH v3 09/13] thermal: qoriq: Convert driver to use regmap API Andrey Smirnov
2019-04-04 8:47 ` Daniel Lezcano
2019-04-05 18:24 ` Andrey Smirnov
2019-04-11 13:00 ` Daniel Lezcano [this message]
2019-04-01 4:14 ` [PATCH v3 10/13] thermal: qoriq: Enable all sensors before registering them Andrey Smirnov
2019-04-04 9:08 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 11/13] thermal: qoriq: Do not report invalid temperature reading Andrey Smirnov
2019-04-04 9:05 ` Daniel Lezcano
2019-04-05 18:30 ` Andrey Smirnov
2019-04-01 4:14 ` [PATCH v3 12/13] thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs() Andrey Smirnov
2019-04-04 9:10 ` Daniel Lezcano
2019-04-01 4:14 ` [PATCH v3 13/13] thermal: qoriq: Add hwmon support Andrey Smirnov
2019-04-04 9:11 ` Daniel Lezcano
2019-04-05 18:38 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac3e90a-dd9f-56eb-faa2-c48d1fe380da@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=cphealy@gmail.com \
--cc=edubezval@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®