From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57223156F46 for ; Fri, 26 Jul 2024 05:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721973547; cv=none; b=OLkY+RxjmLkqBN/UTsEP5LUPYBVPz//fJT+hHVzyjYh5CGPqhFweSy3AUa4SiBwV1dTyF209qP2YXKIUUz0SZk2UnPGpgSIfCQKojOz0ozTD6cNYpshkM6UHZ3GBEoJa/jbA3atx0z6S0FxWhQfViZOuTGfu51G2E9x3d6gRMJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721973547; c=relaxed/simple; bh=PeZcMZeweJbsVxgw1N7g/HLCdkhelynbAD5Jt8gLcjg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=UrsL5XV/iZzV4cwEPG+ev49FOdazciBJ2ikI/gWvqTTiRIDcL5fv2Ln3gJG3fg5lrRah1FzQlEFY7lO6KDw1oEmcQfoNJqFCvpwlOWoOv5eg8YKISRTS5Hq5uehnK90AbpJwPgMFJNCyQQy5BkvH507zdv7btQoBYh50BUrA62E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=v0aiKzzj; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v0aiKzzj" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4279c924ca7so11946235e9.2 for ; Thu, 25 Jul 2024 22:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721973544; x=1722578344; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=dAYeHQWH8jaw6jGoVv0l5Fwc2TPm2KqkM2puS1a7KXw=; b=v0aiKzzjyfZS0gNMkTk/K/WTCv1ukrmyNCy/5dtpBqrt5Hwd3O7ntFyFkVCxrcrGKI IUy+Hs3EHVlyjpytmuINswMCKgT3IQl2M46dYO0VxmbtQcG5CSaZiZTf9ViBMCMF/HFU FKyt+cL/m8jJoe1jqxmAnPjOxcUX6uhP5R6KQaTRVUIHQYzzqR98Vthc7KmcQ/DbdaUG JKLJ7PzlmEBUZ8u76CQhU1Ro16HVomxM2A3qirzmd3YEciWST7KAon7Xdirn+Q6B4EXS mKBoZ9EKAAnR4BXf/LAAUVySvGbe/BYcXFTy7DOBLbLht/8TeyXuhNrn/yM9er2qMcp5 qgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721973544; x=1722578344; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dAYeHQWH8jaw6jGoVv0l5Fwc2TPm2KqkM2puS1a7KXw=; b=t09b9Ox8pYpsELS9rKUIvAxF241PIOj6tSx/b+bvh+pr2CDv10/vdBfcjgKkEsEtUN noWHZ/bk306NdI5ax6VB3wOIbQ+9hNe4MGLAJ0cfFXVi4o8rQfYVyOuxKIyRyg99kHK/ hDUGv6HjVdpShjAcCS+zaEhfSPRzDXwU9NyZkgk1VLe5xhz1Jmy1krMiVo/7ia3S3KQY EnSBaJzrqBvllrz66Jj8gj5YLnZZ7suC0x19nhahG0Gmxdi/NG0lk5TbI1Pwg17fEFsY ErN1JzD/wUGuzfxlUhuMTp6e3c9bsNvk2fXa0Qzl04wYF0hOQJ4f8zb4If1RQLteDL1d Dqug== X-Forwarded-Encrypted: i=1; AJvYcCXPB7aapG5SknwmmOTdM0k1XSSmmqge8XOUduUlPm+48gkCW/jqjHbmXqik2J9qBm2NtdRRddFkMb5LIE8wZuPGTF1ZsCX2DUnXcIQt X-Gm-Message-State: AOJu0Ywx2QlITj9WHe4C1nMC5npooQqHC2A26vgY29wK/ZyRfA0CitrJ wd7cvzhOGZO2qunkrrS0G8lxMLdycvwihxwEKKDkwEdemcsEI5pf0dlPb/Wzsxo= X-Google-Smtp-Source: AGHT+IG+TSLMeItn3Y5MEhX/SpI0aUplguwHSbj+rsaQ5j2pMvkVudDYgkzZ54VWmsDtuZ5I0CUY6w== X-Received: by 2002:a05:6000:4011:b0:367:940c:6a3c with SMTP id ffacd0b85a97d-36b3640529fmr3557937f8f.41.1721973543552; Thu, 25 Jul 2024 22:59:03 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c0574sm4045173f8f.8.2024.07.25.22.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 22:59:03 -0700 (PDT) Message-ID: Subject: Re: [PATCH 00/15] usb: typec: tcpci: few TCPCi & TCPCi-Maxim cleanups (mostly genmask()) From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Heikki Krogerus , Greg Kroah-Hartman Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Badhri Jagan Sridharan , kernel-team@android.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 26 Jul 2024 06:59:01 +0100 In-Reply-To: <20240710-tcpc-cleanup-v1-0-0ec1f41f4263@linaro.org> References: <20240710-tcpc-cleanup-v1-0-0ec1f41f4263@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.1-4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Wed, 2024-07-10 at 11:36 +0100, Andr=C3=A9 Draszik wrote: > While looking through the TCPCi drivers, it occurred to me that all of th= e > open-coded register bit manipulations can be simplified and made more > legible by using the standard GENMASK(), FIELD_GET(), and FIELD_PREP() > macros, which also is less prone to errors: e.g. >=20 > if (((reg & (TCPC_ROLE_CTRL_CC2_MASK << TCPC_ROLE_CTRL_CC2_SHIFT)) >> > =C2=A0=C2=A0=C2=A0=C2=A0 TCPC_ROLE_CTRL_CC2_SHIFT) !=3D > =C2=A0=C2=A0=C2=A0 ((reg & (TCPC_ROLE_CTRL_CC1_MASK << TCPC_ROLE_CTRL_CC= 1_SHIFT)) >> > =C2=A0=C2=A0=C2=A0=C2=A0 TCPC_ROLE_CTRL_CC1_SHIFT)) >=20 > (arguably) is much harder to read and reason about than: >=20 > if (FIELD_GET(TCPC_ROLE_CTRL_CC2, reg) !=3D FIELD_GET(TCPC_ROLE_CTRL_CC1= , reg)) >=20 > and so on. >=20 > These patches do that. In addition, there are a few comment fixes and I > added in a conversion to using dev_err_probe() and > devm_add_action_or_reset() in the Maxim TCPCi driver. >=20 > I kept the patches separated by register or register field as appropriate= to > simplify reviewing, allowing to focus on one field/register at a time. >=20 > Signed-off-by: Andr=C3=A9 Draszik > --- > Andr=C3=A9 Draszik (15): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpci: fix a comment typo > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: clarify a co= mment > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpci: use GENMASK() for TCPC_= CC_STATUS_CC[12] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpci: use GENMASK() for TCPC_= ROLE_CTRL_CC[12] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpci: use GENMASK() for TCPC_= ROLE_CTRL_RP_VAL > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpci: use GENMASK() for TCPC_= MSG_HDR_INFO_REV > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpci: use GENMASK() for TCPC_= TRANSMIT register fields > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: sort TCPC_AL= ERT_MASK values by bit > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: simplify cle= aring of TCPC_ALERT_RX_BUF_OVF > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: drop STATUS_= CHECK() > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: use GENMASK(= ) for TCPC_VENDOR_CC_CTRL2 register > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: use GENMASK(= ) for TCPC_VENDOR_CC_CTRL3 register > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: use GENMASK(= ) for TCPC_VENDOR_ADC_CTRL1 register > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: convert to d= ev_err_probe() > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 usb: typec: tcpm/tcpci_maxim: use device m= anaged TCPCI port deregistration >=20 > =C2=A0drivers/usb/typec/anx7411.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 +- > =C2=A0drivers/usb/typec/tcpm/maxim_contaminant.c |=C2=A0 46 +++++++------ > =C2=A0drivers/usb/typec/tcpm/tcpci.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 104 ++++++++++++++--------------- > =C2=A0drivers/usb/typec/tcpm/tcpci_maxim.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 18 ++--- > =C2=A0drivers/usb/typec/tcpm/tcpci_maxim_core.c=C2=A0 |=C2=A0 71 ++++++++= ++---------- > =C2=A0drivers/usb/typec/tcpm/tcpci_rt1711h.c=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 27 ++++---- > =C2=A0include/linux/usb/tcpci.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 31 +++= ------ > =C2=A07 files changed, 144 insertions(+), 158 deletions(-) Any comments on this series? Cheers, Andre'