From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB4EC433FE for ; Mon, 7 Dec 2020 09:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9FE62311A for ; Mon, 7 Dec 2020 09:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbgLGJya (ORCPT ); Mon, 7 Dec 2020 04:54:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:38974 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbgLGJya (ORCPT ); Mon, 7 Dec 2020 04:54:30 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3BAFAD21; Mon, 7 Dec 2020 09:53:47 +0000 (UTC) Subject: Re: [PATCH drm/hisilicon v2 1/2] drm/hisilicon: Use managed mode-config init To: "tiantao (H)" , Tian Tao , airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, alexander.deucher@amd.com, tglx@linutronix.de, dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org, linux-kernel@vger.kernel.org References: <1607331906-19005-1-git-send-email-tiantao6@hisilicon.com> <1607331906-19005-2-git-send-email-tiantao6@hisilicon.com> <0d60eccc-907d-6fc2-e1c2-c7fe0facd21e@huawei.com> From: Thomas Zimmermann Message-ID: Date: Mon, 7 Dec 2020 10:53:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <0d60eccc-907d-6fc2-e1c2-c7fe0facd21e@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0I72f04CKrbtKB6WYrp3kjWuNdq7hQS1M" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0I72f04CKrbtKB6WYrp3kjWuNdq7hQS1M Content-Type: multipart/mixed; boundary="iXbnfvtIHw4JjkM1Kf9QTPJwDkogkIii1"; protected-headers="v1" From: Thomas Zimmermann To: "tiantao (H)" , Tian Tao , airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, alexander.deucher@amd.com, tglx@linutronix.de, dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH drm/hisilicon v2 1/2] drm/hisilicon: Use managed mode-config init References: <1607331906-19005-1-git-send-email-tiantao6@hisilicon.com> <1607331906-19005-2-git-send-email-tiantao6@hisilicon.com> <0d60eccc-907d-6fc2-e1c2-c7fe0facd21e@huawei.com> In-Reply-To: <0d60eccc-907d-6fc2-e1c2-c7fe0facd21e@huawei.com> --iXbnfvtIHw4JjkM1Kf9QTPJwDkogkIii1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 07.12.20 um 10:29 schrieb tiantao (H): >=20 >=20 > =E5=9C=A8 2020/12/7 17:22, Thomas Zimmermann =E5=86=99=E9=81=93: >> Hi >> >> Am 07.12.20 um 10:05 schrieb Tian Tao: >>> Using drmm_mode_config_init() sets up managed release of modesetting >>> resources. >>> >> >> Individual patches usually contain a changelog to highlight the=20 >> difference to previous versions. Please add one before committing the = >=20 > Just to be sure: I don't need to add a changlog to this individual=20 > patch, right? You should. It's supposed to be good style to add a changelog for each=20 patch and also highlight the series' overall changes in the cover letter.= Best regards Thomas >=20 >> patch.=C2=A0 Your cover letter for the series already does this correc= tly. >> >>> Signed-off-by: Tian Tao >> >> Reviewed-by: Thomas Zimmermann >> >> Thanks for all these updates. >=20 > Thank you for your constant help with the review code and your careful = > guidance! >=20 >> >>> --- >>> =C2=A0 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 14 +++------= ----- >>> =C2=A0 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h |=C2=A0 1 - >>> =C2=A0 2 files changed, 3 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c=20 >>> b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c >>> index 3687753..7f01213 100644 >>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c >>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c >>> @@ -96,8 +96,9 @@ static int hibmc_kms_init(struct hibmc_drm_private = >>> *priv) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct drm_device *dev =3D &priv->dev;= >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret; >>> -=C2=A0=C2=A0=C2=A0 drm_mode_config_init(dev); >>> -=C2=A0=C2=A0=C2=A0 priv->mode_config_initialized =3D true; >>> +=C2=A0=C2=A0=C2=A0 ret =3D drmm_mode_config_init(dev); >>> +=C2=A0=C2=A0=C2=A0 if (ret) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ret; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev->mode_config.min_width =3D 0; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev->mode_config.min_height =3D 0; >>> @@ -125,14 +126,6 @@ static int hibmc_kms_init(struct=20 >>> hibmc_drm_private *priv) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0; >>> =C2=A0 } >>> -static void hibmc_kms_fini(struct hibmc_drm_private *priv) >>> -{ >>> -=C2=A0=C2=A0=C2=A0 if (priv->mode_config_initialized) { >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm_mode_config_cleanup(&= priv->dev); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 priv->mode_config_initial= ized =3D false; >>> -=C2=A0=C2=A0=C2=A0 } >>> -} >>> - >>> =C2=A0 /* >>> =C2=A0=C2=A0 * It can operate in one of three modes: 0, 1 or Sleep. >>> =C2=A0=C2=A0 */ >>> @@ -262,7 +255,6 @@ static int hibmc_unload(struct drm_device *dev) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm_atomic_helper_shutdown(dev); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pci_disable_msi(dev->pdev); >>> -=C2=A0=C2=A0=C2=A0 hibmc_kms_fini(priv); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev->dev_private =3D NULL; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0; >>> =C2=A0 } >>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h=20 >>> b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >>> index a49c10e..7d263f4 100644 >>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >>> @@ -42,7 +42,6 @@ struct hibmc_drm_private { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct drm_crtc crtc; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct drm_encoder encoder; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct hibmc_connector connector; >>> -=C2=A0=C2=A0=C2=A0 bool mode_config_initialized; >>> =C2=A0 }; >>> =C2=A0 static inline struct hibmc_connector *to_hibmc_connector(struc= t=20 >>> drm_connector *connector) >>> >> >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --iXbnfvtIHw4JjkM1Kf9QTPJwDkogkIii1-- --0I72f04CKrbtKB6WYrp3kjWuNdq7hQS1M Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/N+6oFAwAAAAAACgkQlh/E3EQov+Cp sQ/+KZGgJvYtL7bhwCJr8ENheu7nGVIe02n+kekMBJntRRmA+7/gLQsebp9F06zrefVcDj+Kv7Qc s1F73YPr2SLwH1FgkzDCLd1IeVwgSVq/Eeprar3xziWrXC91d3ak3KavYMjQqHRszEbRMbK/oSqS W3HW3LYSkVkhwtuDcfODYjWWlMLn2et7H0eNCam2tA8F34rydGrZA09E4q/OfYuUr7KAQfG9P97d iCpl1pz/Z1yzg6/Dnpoxvv7o6oL9rHzo7/b2FJpaznXPEf56I/btGK01POrpXHzIEcFO+fMVbDdb CzshuvEKHUMNhFzY0eFmk+ov9tpUv7fq6k4/87rwTOYT07cJ5kAx9mXHwAmW6auf+DS2bS657bT6 9YIJavqSiGW3GWQ1fztQeLi1QOQfehzGoJz5vBkYN7iLHj0V/hiS1GLUmTtTkJQ7g8jxzHxTyiRX QteAS7hCfaHDasEtbq4ijhiEIMENOCF5uuyaYw1CaXilbxrlg3WtyQLG5jVwffEI3CkD1C+foujN qHP3RewE+M5U6wn6gC6PX6YnaFRcM49YnyXf7G3GwD4hQAV15gUrWffZ8sxSqo75DVIJq6iE7PAP ZuM0l6vJUUSr7DGqWcivcQfTxNJitMYfXcm1JyZZyFTMHiYY/EWOWF62DXNGdbwJsPlIH32SAK/h ENM= =qLU2 -----END PGP SIGNATURE----- --0I72f04CKrbtKB6WYrp3kjWuNdq7hQS1M--