From: Thomas Zimmermann <tzimmermann@suse.de>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y
Date: Wed, 26 Jun 2024 16:11:09 +0200 [thread overview]
Message-ID: <dac6562e-2542-410d-909a-c1a15e5daa2c@suse.de> (raw)
In-Reply-To: <8cb41481-f44c-4615-8c1f-d38261082a10@suse.de>
Am 26.06.24 um 16:07 schrieb Thomas Zimmermann:
> Hi
>
> Am 26.06.24 um 08:37 schrieb Chen-Yu Tsai:
>> Hi Thomas,
>>
>> On Thu, Jun 20, 2024 at 10:20 PM Chun-Kuang Hu
>> <chunkuang.hu@kernel.org> wrote:
>>> Hi, Chen-Yu:
>>>
>>> Chen-Yu Tsai <wenst@chromium.org> 於 2024年6月20日 週四 下午1:47寫道:
>>>> With the recent switch from fbdev-generic to fbdev-dma, the driver now
>>>> requires the DRM GEM DMA helpers. This dependency is missing, and will
>>>> cause a link failure if fbdev emulation is enabled.
>>>>
>>>> Add the missing dependency.
>>> Acked-by: Chun-Kuang Hu <chunkuang.hu@mediatek.com>
>> Could you help merge this?
>
> It's merged into drm-misc-fixes.
drm-misc-next
>
> Best regards
> Thomas
>
>>
>> Thanks
>> ChenYu
>>
>>>> Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma")
>>>> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
>>>> ---
>>>> The commit this patch fixes is in drm-misc-next. Ideally this patch
>>>> should be applied on top of it directly.
>>>>
>>>> CK, could you give your ack for it?
>>>>
>>>> drivers/gpu/drm/mediatek/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/mediatek/Kconfig
>>>> b/drivers/gpu/drm/mediatek/Kconfig
>>>> index 96cbe020f493..d6449ebae838 100644
>>>> --- a/drivers/gpu/drm/mediatek/Kconfig
>>>> +++ b/drivers/gpu/drm/mediatek/Kconfig
>>>> @@ -7,6 +7,7 @@ config DRM_MEDIATEK
>>>> depends on HAVE_ARM_SMCCC
>>>> depends on OF
>>>> depends on MTK_MMSYS
>>>> + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION
>>>> select DRM_KMS_HELPER
>>>> select DRM_MIPI_DSI
>>>> select DRM_PANEL
>>>> --
>>>> 2.45.2.741.gdbec12cfda-goog
>>>>
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
next prev parent reply other threads:[~2024-06-26 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 5:47 Chen-Yu Tsai
2024-06-20 6:37 ` Thomas Zimmermann
2024-06-20 8:49 ` Chen-Yu Tsai
2024-06-20 14:20 ` Chun-Kuang Hu
2024-06-26 6:37 ` Chen-Yu Tsai
2024-06-26 14:07 ` Thomas Zimmermann
2024-06-26 14:11 ` Thomas Zimmermann [this message]
2024-06-20 21:20 ` Paolo Bonzini
2024-06-20 21:24 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac6562e-2542-410d-909a-c1a15e5daa2c@suse.de \
--to=tzimmermann@suse.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®