mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	kernel-janitors@vger.kernel.org,
	Tze Yee Ng <tze.yee.ng@altera.com>
Cc: stable@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: stratix10-rsu: Fix NULL deref on rsu_send_msg() timeout in probe
Date: Tue, 26 May 2026 09:29:10 -0500	[thread overview]
Message-ID: <dad634f3-f3a5-4a6c-a90d-76356a28ce63@kernel.org> (raw)
In-Reply-To: <2bc78c8a-191f-4657-9ed9-a271c86a4b92@web.de>



On 5/21/26 11:33, Markus Elfring wrote:
> …
>> Apply the same cleanup pattern to the remaining failure paths: remove the
>> async client, free the channel, and return early so no further messages are
>> queued on a channel whose scl has been cleared.
> …
> 
> How do you think about to avoid a bit of duplicate source code
> in the implementation of the function “stratix10_rsu_probe”?
> https://elixir.bootlin.com/linux/v7.1-rc4/source/drivers/firmware/stratix10-rsu.c#L715-L807

Excellent suggestion.

Thanks,
Dinh



      reply	other threads:[~2026-05-26 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  3:14 Dinh Nguyen
2026-05-21 16:33 ` Markus Elfring
2026-05-26 14:29   ` Dinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dad634f3-f3a5-4a6c-a90d-76356a28ce63@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=Markus.Elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=tze.yee.ng@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®