Re: [PATCH v4 5/6] dt-bindings: media: mediatek,vcodec-encoder: Add MT8196 with VCP support

["Irui Wang (王瑞)" <Irui.Wang@mediatek.com>]

Dear Krzysztof,

Thanks for your response.

On Fri, 2026-02-13 at 10:32 +0100, Krzysztof Kozlowski wrote:
> On 13/02/2026 10:27, Irui Wang (王瑞) wrote:
> > Dear Krzysztof,
> > 
> > I sincerely apologize for taking up your time to review and respond
> > to
> > this patch. The maintainers' review comments are very important to
> > us,
> > so we will never ignore them, there must be some misunderstanding
> > in
> > this process.
> > 
> > On Fri, 2026-02-13 at 08:52 +0100, Krzysztof Kozlowski wrote:
> > > On Thu, Feb 12, 2026 at 06:01:02PM +0800, Irui Wang wrote:
> > > > Add support for MT8196 video encoder which uses VCP (Video Co-
> > > > Processor)
> > > > for firmware management. Unlike previous platforms that use
> > > > SCP/VPU, MT8196
> > > > requires VCP to load and execute the video encoding firmware,
> > > > with
> > > > the
> > > > encoder communicating through VCP to perform encoding
> > > > operations.
> > > 
> > > Again, read review from v2. Subject is still wrong.
> 
> Here "read review from v2"

I will rewrite Subject to "media: dt-bindings: mediatek,vcodec-encoder: 
Add MT8196" in next version.
> 
> > 
> > From the reviews of v2 and v3, my understanding is that the patch
> > lacks
> > details, so we add more description for current modification, for
> > 'VCP'
> > usage. So we are very grateful if you could provide a `correct
> > Subject
> > ` example for us, thanks a lot.
> 
> You received one at v2.
> 
> > 
> > 
> > > > 
> > > > Add the "mediatek,mt8196-vcodec-enc" compatible string and
> > > > introduce
> > > > the "mediatek,vcp" property to reference the VCP device, which
> > > > is
> > > > required for MT8196 encoder operation.
> > > > 
> > > > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > > > ---
> > > >  .../media/mediatek,vcodec-encoder.yaml        | 19
> > > > +++++++++++++++++++
> > > >  1 file changed, 19 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > encoder.yaml
> > > > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > encoder.yaml
> > > > index ebc615584f92..4c8acebeb9d3 100644
> > > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > encoder.yaml
> > > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > encoder.yaml
> > > > @@ -24,6 +24,7 @@ properties:
> > > >                - mediatek,mt8188-vcodec-enc
> > > >                - mediatek,mt8192-vcodec-enc
> > > >                - mediatek,mt8195-vcodec-enc
> > > > +              - mediatek,mt8196-vcodec-enc
> > > >        - items:
> > > >            - const: mediatek,mt8186-vcodec-enc
> > > >            - const: mediatek,mt8183-vcodec-enc
> > > > @@ -58,6 +59,13 @@ properties:
> > > >      description:
> > > >        Describes point to scp.
> > > >  
> > > > +  mediatek,vcp:
> > > > +    $ref: /schemas/types.yaml#/definitions/phandle
> > > > +    description:
> > > > +      Reference to the VCP (Video Co-Processor) device that
> > > > loads
> > > > and executes
> > > > +      the video encoding firmware. The encoder communicates
> > > > with
> > > > the firmware
> > > > +      through VCP to perform encoding operations.
> > > > +
> > > >    power-domains:
> > > >      maxItems: 1
> > > >  
> > > > @@ -76,6 +84,17 @@ required:
> > > >    - iommus
> > > >  
> > > >  allOf:
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            enum:
> > > > +              - mediatek,mt8196-vcodec-enc
> > > > +
> > > > +    then:
> > > > +      required:
> > > > +        - mediatek,vcp
> > > 
> > > And here still did not implement the comment. So basically you
> > > did
> > > not
> > > implement fully v2 and v3.
> > 
> > If you are mean about the `else statement`, I left a comments and
> > want
> > to get an explanation from you, if you feel that my reply is
> > unsatisfactory or incorrect, please let me know.
> > 
> > The key point is that our patch can satisfy you and get a Reviewed-
> > by
> > from you.
> > 
> 
> Neither your answer, nor commit description here are actually
> ANSWERING
> to my comment at v3. If you answer with irrelevant/unrelated comment,
> the reviewer's feedback stays. OR explain please with different words
> why other devices have vcp but your commit msg says they do not have
> vcp.

Why other devices have vcp? because I didn't write 'mediatek,vcp:false'
in else statement?


> 
> Best regards,
> Krzysztof