From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AC5C433E1 for ; Sun, 14 Jun 2020 14:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3553A206D7 for ; Sun, 14 Jun 2020 14:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HJpq5dfL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726931AbgFNOkZ (ORCPT ); Sun, 14 Jun 2020 10:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726717AbgFNOkZ (ORCPT ); Sun, 14 Jun 2020 10:40:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FBECC05BD43 for ; Sun, 14 Jun 2020 07:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=Mr+YAzLD99XJJr7FqlLfOzEn6BvtdNusuprn3XV2Rvc=; b=HJpq5dfLZkPD8vSjn03StGVsVx +rpnzrhiNwX890IOUzCZ82hNyByeK0oDCBdAA9hae4vBl2glafmbmek7KcQc3qZ8Dm/OQciZR0D0/ cl3+Hs+sVrAOowB/hBm5OvIcYLDVqpokJI0NNF5DSwMWuJ017kvR3koz/Idi0gn4vBd8S379NSSNR 57QBvi50iFPXfE46ZcCcXn9wxc3LpAR6GNf/ClKpz9vdSlK2Y/5mxdP3yEX5hwaGouJ9iAN8FUnLp CKD19pdTCmggZJwyuCsTG61YmDefAbFmLHj0v3HoxW5IlwgHBy5MIkq1G1bdyotsA+Bw9+kn0ADdc ptE5SzXw==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkTo0-0000Ep-PX; Sun, 14 Jun 2020 14:40:16 +0000 Subject: Re: [Cocci] coccinelle issues To: Julia Lawall Cc: LKML , cocci@systeme.lip6.fr References: From: Randy Dunlap Message-ID: Date: Sun, 14 Jun 2020 07:40:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/20 12:39 AM, Julia Lawall wrote: > > > On Sat, 13 Jun 2020, Randy Dunlap wrote: > >> Hi, >> >> OK, I've not used Coccinelle and now I am trying to use it. >> It seems that I am having a few issues. >> The primary one is when I run spatch (via 'make coccicheck' in >> the kernel source tree), it tells me: >> >> Python error: No module named coccilib.elems >> >> I do see "elems.py" in /usr/local/lib64/coccinelle/python/coccilib. >> >> I am using coccinelle-master downloaded from github on >> Friday June 12, 2020. >> >> >> I have also made the following notes while building/installing it. >> >> >> Note1: The latest coccinelle tarball is not actually available >> at the coccinelle home page although the kernel documentation says it is. > > Yes, I'm aware of this problem. We're not able to update the home page at > the moment. This problem is being worked on. > >> >> Note2: https://github.com/coccinelle/coccinelle/blob/master/install.txt >> says that 'spatch' is a script, but it seems to be a binary executable >> file. > > Actually, it is a script, and the fact that you say it is a binary may be > the reason for your python problem. Normally there is a script > (scripts/spatch) that make install puts in place that refers back to where > your Coccinelle is installed. Yes, I saw scripts/spatch, but that script is not what is installed in /usr/local/bin. (see more below) >> Note3: https://github.com/coccinelle/coccinelle/blob/master/install.txt >> probably should say to use 'sudo make install' instead of just >> 'make install', just like 'coccinelle.rst' file in the kernel tree says. > > OK. A lot of documentation for a lot of projects seems to omit the sudo, > but I have indeed never understood why. > > Maybe try again with make distclean, ./autogen, ./configure, sudo make > install? OK, I did all of those. Is this expected? $ ./autogen cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory cat: VERSION: No such file or directory spatch is installed in /usr/local/bin/spatch: $ ll /usr/local/bin/spatch -rwxr-xr-x 1 root root 15547736 Jun 14 07:32 /usr/local/bin/spatch* $ file /usr/local/bin/spatch /usr/local/bin/spatch: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/l, BuildID[sha1]=2b658c12a1a49deae24010b71d22d262988ce041, for GNU/Linux 3.2.0, with debug_info, not stripped I still get this runtime error: Python error: No module named coccilib.elems -- ~Randy