From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753747Ab0AYOjZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753747Ab0AYOjZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2010 09:39:25 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752875Ab0AYOjY
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 25 Jan 2010 09:39:24 -0500
Received: from mail-pw0-f42.google.com ([209.85.160.42]:59681 "EHLO
	mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752786Ab0AYOjV convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2010 09:39:21 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=bsThN0nLz6T/Vt6hweBJLK9oB+eTXu7MlxasNW27P7cXS4kK0aZDvQ3xZAFFCZaBzY
         inaUfGChbQqRvIzNESakWiRxgV9jZqFk9g0/bwMXzuWlt+0ekS/U3JpYTsbO4y78Ptkc
         gkKDOmCs8OpS6ywAtSAo4Ay5YRi2/FZm9BrPo=
MIME-Version: 1.0
In-Reply-To: <daef60381001170536s79551f0drb573181d18db6369@mail.gmail.com>
References: <daef60381001170536s79551f0drb573181d18db6369@mail.gmail.com>
From: Hui Zhu <teawater@gmail.com>
Date: Mon, 25 Jan 2010 22:39:01 +0800
Message-ID: <daef60381001250639p6dce8308lf5a765d7015c7846@mail.gmail.com>
Subject: Re: [PATCH] Change hex to Math::BigInt->from_hex in markup_oops.pl
To: Andrew Morton <akpm@linux-foundation.org>,
       Arjan van de Ven <arjan@linux.intel.com>,
       Sam Ravnborg <sam@ravnborg.org>,
       =?ISO-8859-1?Q?Ozan_=C7aglayan?= <ozan@pardus.org.tr>,
       Matthew Wilcox <willy@linux.intel.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please ignore this patch.  Because it was included in "[PATCH]
markup_oops.pl: add options to improve cross-sompilation
environments".

Thanks,
Hui

On Sun, Jan 17, 2010 at 21:36, Hui Zhu <teawater@gmail.com> wrote:
> The hex cannot work well in x86 to parse the oops message for x8664.
> So this patch change it.
>
> Thanks,
> Hui
>
> Signed-off-by: Hui Zhu <teawater@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Ozan Çaglayan <ozan@pardus.org.tr>
> Cc: Matthew Wilcox <willy@linux.intel.com>
>
> ---
>  scripts/markup_oops.pl |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/scripts/markup_oops.pl
> +++ b/scripts/markup_oops.pl
> @@ -196,7 +196,7 @@ if ($module ne "") {
>        while (<FILE>) {
>                if ($_ =~ /^([0-9a-f]+) \<$function\>\:/) {
>                        my $fu = $1;
> -                       $vmaoffset = hex($target) - hex($fu) - hex($func_offset);
> +                       $vmaoffset = Math::BigInt->from_hex("0x$target") -
> Math::BigInt->from_hex("0x$fu") -
> Math::BigInt->from_hex("0x$func_offset");
>                }
>        }
>        close(FILE);
> @@ -212,7 +212,7 @@ sub InRange {
>        my ($address, $target) = @_;
>        my $ad = "0x".$address;
>        my $ta = "0x".$target;
> -       my $delta = hex($ad) - hex($ta);
> +       my $delta = Math::BigInt->from_hex($ad) - Math::BigInt->from_hex($ta);
>
>        if (($delta > -4096) && ($delta < 4096)) {
>                return 1;
>