From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932340Ab0BHC4H (ORCPT ); Sun, 7 Feb 2010 21:56:07 -0500 Received: from mail-px0-f189.google.com ([209.85.216.189]:54963 "EHLO mail-px0-f189.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932174Ab0BHC4E convert rfc822-to-8bit (ORCPT ); Sun, 7 Feb 2010 21:56:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=aYqajBRIhbNe4OSn6JWYB007tNuXfmiZWEGIxZLnAN91zwb8YUFDLIpWUXxjCpmtPs bOaeOp7huChkihsno3BCavhm1jcoZUSesOp/INGIvtk/NcoH6atm7VCYYID2+GFOMFPj JNcIjeqj806XachsyPd3v/nbSkzgid+cmZ9EI= MIME-Version: 1.0 In-Reply-To: <4B6C8FF0.3090106@suse.cz> References: <4B5E5D4F.50803@windriver.com> <2375c9f91001251905p6ed99405m3915ac56e230605f@mail.gmail.com> <4B5E9BE9.2030702@windriver.com> <2375c9f91001252353u52f437b0t7ddd643a57047e1c@mail.gmail.com> <4B5EB223.60307@windriver.com> <4B6344CA.10504@suse.cz> <4B666982.1020007@windriver.com> <4B6C8FF0.3090106@suse.cz> From: Hui Zhu Date: Mon, 8 Feb 2010 10:55:44 +0800 Message-ID: Subject: Re: [PATCH] markup_oops.pl: add options to improve cross-sompilation environments To: Michal Marek Cc: Hui Zhu , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Andrew Morton , Arjan van de Ven , Sam Ravnborg , ozan@pardus.org.tr, Matthew Wilcox , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, Looks you miss this one: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ef2b9b054580ef835078d8aa411bd06542cd5c1c Thanks, Hui On Sat, Feb 6, 2010 at 05:38, Michal Marek wrote: > On 1.2.2010 06:41, Hui Zhu wrote: >> I make a patch according to your mail. >> >> Best regards, >> Hui >> >> 1. Fix a little format issue. >> 2. Check the return of "Getopt::Long::GetOptions".  Output usage and >> exit if it get error. >> 3. Change $ARGV[$#ARGV] to $ARGV[0]. >> 4. Change the code which get $modulefile from modinfo.  Replace the >> pipeline with `modinfo -F filename $module`. >> 4. Change usage from "Specify the module directory name" to "Specify the >> module filename". >> >> Signed-off-by: Hui Zhu > > Thanks, I applied the previous and this patch. Just to make sure I > didn't miss any of your patches, can you check that > http://repo.or.cz/w/linux-kbuild.git/blob/refs/heads/for-next:/scripts/markup_oops.pl > has all your changes? If something is missing, please resend it, thanks. > > Michal > >> --- >> scripts/markup_oops.pl |   10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> --- a/scripts/markup_oops.pl >> +++ b/scripts/markup_oops.pl >> @@ -23,10 +23,10 @@ my $modulefile = ""; >> # Get options >> Getopt::Long::GetOptions( >>     'cross-compile|c=s'    => \$cross_compile, >> -    'module|m=s'    => \$modulefile, >> +    'module|m=s'        => \$modulefile, >>     'help|h'        => \&usage, >> -); >> -my $vmlinux_name = $ARGV[$#ARGV]; >> +) || usage (); >> +my $vmlinux_name = $ARGV[0]; >> if (!defined($vmlinux_name)) { >>     my $kerver = `uname -r`; >>     chomp($kerver); >> @@ -193,7 +193,7 @@ if ($target eq "0") { >> # if it's a module, we need to find the .ko file and calculate a load >> offset >> if ($module ne "") { >>     if ($modulefile eq "") { >> -        my $modulefile = `modinfo $module | grep '^filename:' | awk '{ >> print \$2 }'`; >> +        $modulefile = `modinfo -F filename $module`; >>         chomp($modulefile); >>     } >>     $filename = $modulefile; >> @@ -361,7 +361,7 @@ Usage: >> >> OPTION: >>   -c, --cross-compile CROSS_COMPILE    Specify the prefix used for >> toolchain. >> -  -m, --module MODULE_DIRNAME        Specify the module directory name. >> +  -m, --module MODULE_DIRNAME        Specify the module filename. >>   -h, --help                Help. >> EOT >>     exit; >> >> > >