From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-1-11.ptr.blmpb.com (sg-1-11.ptr.blmpb.com [118.26.132.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86C0C524D1 for ; Thu, 30 Oct 2025 02:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761792127; cv=none; b=I1H5zRLgPXfwicNAuA/rvbafJF7eBBKWTIYnmyodL+251lsz2JqekjcJrG2RZuxYU+UviD4wTfEYrvMAX+N3Ga6CdPEURc0UNeaBhuUvKxKBxOiMfwWmUp12DutwVkW0Re1SEVj38Xd1GCB6welrSIHLgMReS7pMfYcUYmY0HvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761792127; c=relaxed/simple; bh=TcyUSbo80Jx0DmY6uBc8ZIvIg0DwakU3w7Y1gSrDpVw=; h=References:From:Subject:Mime-Version:In-Reply-To:Date:Message-Id: Content-Type:To:Cc; b=uAJjlfcQ64SqWJYhpG3pm7TGf488zfOrb/La5KEqH/eJj+5LyHQjBLbpztj3bp0QllVe3lpncdMiBP1xF5M//6+2dHGasyGoGLybKJprMvhXWLIRb3xPVz4xWCvSbai0LQEBD05Q6+DK0USt5RiCI9bPocRKZ0vRIdSVUc/tWlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com; spf=none smtp.mailfrom=fnnas.com; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b=3eyi3/5p; arc=none smtp.client-ip=118.26.132.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b="3eyi3/5p" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1761792117; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=yh8djo7Nd21BgC+Yx2aUSeybVAkoleHM0MeaAP2URjo=; b=3eyi3/5pRMbR0mK6qLLwl5wwNN22NJn6h/53GYsFO3ggtlTRnxZOLi+ZrtKvyqQepMHU+v 2AsFOu3DJVwa7qgEKMLJEbD1SLaDYVWzQTc1OUD77IcsD5uGNFu2l4z9RkNZfRJE3FkJUg kP2YLTpL4B7YfxCETosBD92zhSmWHYBeJfGJGf4XpO+MARVf3x9K66L6n0Sw0Mr1wuTK3D 9jZ5Y1Z8JzGp+PeNCo3KPcfr4wDdIPnEIsRuPgca18py3WctDPy7qDwIVQQ1nqna/m9AWL 5Umgo6LceXya2LfSRsseufRC+4qWUtmQzSmddg83gSE2BPQpgm5cHob2zX37ew== X-Original-From: Yu Kuai Reply-To: yukuai@fnnas.com References: <20251027150433.18193-1-k@mgml.me> <20251027150433.18193-10-k@mgml.me> X-Lms-Return-Path: User-Agent: Mozilla Thunderbird From: "Yu Kuai" Subject: Re: [PATCH v5 09/16] md/raid10: fix failfast read error not rescheduled Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 In-Reply-To: <20251027150433.18193-10-k@mgml.me> Date: Thu, 30 Oct 2025 10:41:51 +0800 Message-Id: Content-Type: text/plain; charset=UTF-8 Received: from [192.168.1.104] ([39.182.0.168]) by smtp.feishu.cn with ESMTPS; Thu, 30 Oct 2025 10:41:54 +0800 To: "Kenta Akagi" , "Song Liu" , "Shaohua Li" , "Mariusz Tkaczyk" Cc: , , "Li Nan" , =E5=9C=A8 2025/10/27 23:04, Kenta Akagi =E5=86=99=E9=81=93: > raid10_end_read_request lacks a path to retry when a FailFast IO fails. > As a result, when Failfast Read IOs fail on all rdevs, the upper layer > receives EIO, without read rescheduled. > > Looking at the two commits below, it seems only raid10_end_read_request > lacks the failfast read retry handling, while raid1_end_read_request has > it. In RAID1, the retry works as expected. > * commit 8d3ca83dcf9c ("md/raid10: add failfast handling for reads.") > * commit 2e52d449bcec ("md/raid1: add failfast handling for reads.") > > This commit will make the failfast read bio for the last rdev in raid10 > retry if it fails. > > Fixes: 8d3ca83dcf9c ("md/raid10: add failfast handling for reads.") > Signed-off-by: Kenta Akagi > Reviewed-by: Li Nan > --- > drivers/md/raid10.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Yu Kuai