Re: [PATCH] phy: qualcomm: m31-eusb2: Add runtime pm ops

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/27/25 7:24 AM, Prashanth K wrote:
> Add runtime power management operation callbacks for M31 EUSB2 PHY.
> Enable/disable the clocks based on the runtime suspend/resume calls.
> 
> Signed-off-by: Prashanth K <prashanth.k@oss.qualcomm.com>
> ---

[...]

>  static int m31eusb2_phy_probe(struct platform_device *pdev)
>  {
>  	struct phy_provider *phy_provider;
> @@ -270,6 +298,17 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, PTR_ERR(phy->clk),
>  				     "failed to get clk\n");
>  
> +	dev_set_drvdata(dev, phy);
> +	pm_runtime_set_active(dev);
> +	pm_runtime_enable(dev);
> +
> +	/*
> +	 * Prevent runtime pm from being ON by default. Users can enable
> +	 * it using power/control in sysfs.
> +	 */
> +	pm_runtime_forbid(dev);

This screams "this patch is broken" or "there are bad issues" which
you did not describe at all.

Konrad