From: Valentin Schneider <valentin.schneider@arm.com>
To: Qian Cai <cai@lca.pw>
Cc: peterz@infradead.org, mingo@kernel.org,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: fix variable "done" set but not used
Date: Mon, 27 May 2019 14:25:42 +0100 [thread overview]
Message-ID: <daf5e5ef-80de-5eba-01b7-22e5163678b8@arm.com> (raw)
In-Reply-To: <090C3AE4-55E4-45F3-AEAB-3E7F26FB7D6D@lca.pw>
On 27/05/2019 01:53, Qian Cai wrote:
[...]
>> For some reason I can't get this warning to fire on my end (arm64 defconfig
>> + all the NO_HZ stuff set to nope + GCC 8.1). However I do think there are
>> things we could improve here.
>
> I like your approach more if it works. The warning can be reproduced by compiling with W=1.
>
Oh, duh, I thought this one would show up in the regular warnings. I gave it
a spin and the warning does disappear.
[...]
next prev parent reply other threads:[~2019-05-27 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 16:18 Qian Cai
2019-05-26 23:56 ` Valentin Schneider
2019-05-27 0:53 ` Qian Cai
2019-05-27 13:25 ` Valentin Schneider [this message]
2019-06-02 16:41 ` [PATCH] sched/fair: Cleanup definition of NOHZ blocked load functions Valentin Schneider
2019-06-03 9:38 ` Peter Zijlstra
2019-06-03 9:53 ` Vincent Guittot
2019-06-03 10:22 ` Valentin Schneider
2019-06-03 11:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daf5e5ef-80de-5eba-01b7-22e5163678b8@arm.com \
--to=valentin.schneider@arm.com \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®