mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bot+bpf-ci@kernel.org
To: vineet.gupta@linux.dev,bpf@vger.kernel.org
Cc: ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,martin.lau@linux.dev,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,john.fastabend@gmail.com,shuah@kernel.org,linux-kernel@vger.kernel.org,linux-kselftest@vger.kernel.org,jose.marchesi@oracle.com,david.faust@oss.qualcomm.com,vineet.gupta@linux.dev,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next v4 5/8] selftests/bpf: write the mixed arena/scalar ALU tests in asm
Date: Tue,  3 Nov 2026 18:57:28 +0000 (UTC)	[thread overview]
Message-ID: <daf9d2a5cb93efffb7a93acacf6db462120c05a9d39c7947210e904644908242@mail.kernel.org> (raw)
In-Reply-To: <20261103181816.254686-6-vineet.gupta@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 3260 bytes --]

> selftests/bpf: write the mixed arena/scalar ALU tests in asm

TL;DR: Commit message only, no code issues: it refers to a follow-up patch as
"6/8" and says an arena-capable GCC is needed; both should name the commit by
subject, since series numbers vanish from git history.

> selftests/bpf: write the mixed arena/scalar ALU tests in asm
>
> They fail to build with BPF_GCC:
>
>   progs/verifier_arena.c:566:5: error: optimization may eliminate reads and/or writes to register variables [-Werror=volatile-register-var]
>
> for
>
>   volatile register __u64 reg asm("r3");
>
> and GCC means it. With the warning silenced it drops both scalar
> accesses, leaving nothing that uses r3 as a scalar:
>
>   call	7
>   if w0 == 0 goto .L136
>   r9 = arena ll;r3 = 0;r3 = addr_space_cast(r3, 0, 1);
>   .L136:
>   r0 = 0
>   exit
>
> `reg = 1ULL << 32' and `reg += 1' are both gone. The tests need one
> instruction reached with r3 live as a scalar on one path and as an
> arena pointer on the other; what is left gives the verifier no reason
> to reject anything, so the __failure expectation would not hold. A
> local register variable is not guaranteed to survive a helper call
> either, which GCC is also entitled to act on.
>
> Nothing here needs a compiler to allocate registers, so write the
> whole body in asm like mixed_arena_stack_atomic below, which tests the
> same shape. Both compilers then emit the same sequence, with the
> branch landing on the shared ALU op:
>
>   call 7
>   r6=r0
>   r3=1
>   r3<<=32
>   if w6==0 goto 4          <- lands on r3+=1
>   r9=0 ll
>   r3=0
>   r3 = addr_space_cast(r3, 0, 1)
>   r3+=1                    <- scalar on one path, arena pointer on the other
>   r0=0
>   exit
>
> And while here also bring in __load_if_JITed(). A program binding an
> arena map is rejected in check_map_prog_compatibility() with "JIT is
> required to use arena" during map resolution, before do_check() can
> reach the shared instruction, so without a JIT these would fail on the
> wrong message rather than skip.
>
> Both tests become visible once 6/8 stops hiding them, and pass:
>
>   verifier_arena/mixed_arena_scalar_alu64_scalar_first   -> OK
>   verifier_arena/mixed_arena_scalar_alu64_arena_first    -> OK
>
> Notes:
>  - This does need an __arena capable BPF_GCC.
>  - Under clang the rewrite is not a no-op: the existing version spilled r3
>    to the stack and did the shared ALU op on r1 reloaded from it, so the
>    test was not exercising one register live as both a scalar and an arena
>    pointer.
>
> Signed-off-by: Vineet Gupta <vineet.gupta@linux.dev>
>

this isn't a bug, but could the changelog name the follow-up commit by its
subject instead of "6/8"?  The series number is not kept once the patches
are applied, so the reference no longer identifies anything in git history.

The same applies to the "Notes:" line "This does need an __arena capable
BPF_GCC", which only holds once that later commit has dropped the
__BPF_FEATURE_ADDR_SPACE_CAST guard around these tests.


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/41694978246

  reply	other threads:[~2026-11-03 18:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 18:18 [PATCH bpf-next v4 0/8] selftests/bpf: let the arena tests build with GCC Vineet Gupta
2026-11-03 18:18 ` [PATCH bpf-next v4 1/8] selftests/bpf: Build callx tests with GCC that defines __BPF_FEATURE_CALLX Vineet Gupta
2026-11-03 18:18 ` [PATCH bpf-next v4 2/8] selftests/bpf: don't pass clang-only warning flags to GCC Vineet Gupta
2026-11-03 18:18 ` [PATCH bpf-next v4 3/8] selftests/bpf: make arena_base() opaque to GCC's -Warray-bounds Vineet Gupta
2026-11-03 18:18 ` [PATCH bpf-next v4 4/8] selftests/bpf: spell the addr_space_cast address spaces in decimal Vineet Gupta
2026-11-03 18:57   ` bot+bpf-ci
2026-11-03 18:18 ` [PATCH bpf-next v4 5/8] selftests/bpf: write the mixed arena/scalar ALU tests in asm Vineet Gupta
2026-11-03 18:57   ` bot+bpf-ci [this message]
2026-11-03 18:18 ` [PATCH bpf-next v4 6/8] selftests/bpf: drop the arena guards and tag the tests that need arena Vineet Gupta
2026-11-03 18:57   ` bot+bpf-ci
2026-11-03 18:18 ` [PATCH bpf-next v4 7/8] selftests/bpf: cast explicitly in the struct_ops arena triggers Vineet Gupta
2026-11-03 18:18 ` [PATCH bpf-next v4 8/8] selftests/bpf: cast explicitly in the arena subprog and callback faults Vineet Gupta
2026-11-03 21:20 ` [PATCH bpf-next v4 0/8] selftests/bpf: let the arena tests build with GCC patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daf9d2a5cb93efffb7a93acacf6db462120c05a9d39c7947210e904644908242@mail.kernel.org \
    --to=bot+bpf-ci@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=david.faust@oss.qualcomm.com \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jose.marchesi@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mason@kernel.org \
    --cc=memxor@gmail.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=vineet.gupta@linux.dev \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®