From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbdLHVw2 (ORCPT ); Fri, 8 Dec 2017 16:52:28 -0500 Received: from mout.web.de ([212.227.15.3]:57967 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbdLHVwZ (ORCPT ); Fri, 8 Dec 2017 16:52:25 -0500 Subject: [PATCH 2/3] serial: ioc4: Improve four size determinations From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Pat Gefre Cc: LKML , kernel-janitors@vger.kernel.org References: <514232dd-7e91-00f9-b95c-3e8f740090ca@users.sourceforge.net> Message-ID: Date: Fri, 8 Dec 2017 22:52:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <514232dd-7e91-00f9-b95c-3e8f740090ca@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:qeExDwmKcy4y9+10WS9uGo8SmQQzB/xm+INCRQlhIXsyrOv0+4h QolwecvtJ3PpfOdRtZPfkn4a7AHjtG8AuWWKfeiA+VSnG0dRaDl3uWQsSJzpeJRBzLDa89N 6IHHGCsANZ9iOBcn6Zx8avy1/H7fDHaZpuDjYJfrJAJ7A6MoveNoAuM0bapgwPsbwfgDUwU lHLg2jkhe5Q1VYQ1mkT2w== X-UI-Out-Filterresults: notjunk:1;V01:K0:zl7IjcMXUsU=:Paqm8CSghtFLcG8jUS8sq/ 7sZkSqoqwgi7jYn3zRdeY2SEWssE3vDbZiAv2631xZvuvCfWLojEg2Y56avciPU9Q8NnGyWvg IyGK+FUUO8WV9HF3hLtA1IQaSj4ot1s8YNSVU7aKiPlCzgKt2dYwx+Kpnl2Nj4/oIbtvQ30OP OfekgQYynY7IFqmC4tkyt6waIR/7aQ3OsLPQSU1BuSKBZ0OqjFkbCYTxAulwd/Og/QG7p7I2c UxtC34inomwCe4iDV+zksmJgf82Tqb6INC/OMZTzJu9TTa72Wu8HnO5u6Dwj6H4EUIVIH1QFp Tuq4EYFDzJfhNbDPK+55yVuSDU24PP6M1EYIM56jPWbJabuB3p6JlE6NuXRVLngD/P1b4woTt 05q8pMb5vxmpqZcklTsl/LjjoIH+uYDfOBRtSU9U1qfGGBqSbJOjCXjBsymNyl/larii1R4XR ZcbWP3fl1tcwAvLabVh8mPbljNV1ZZnvASrN1AbvGjFZN56/uSMqKlpvZ5lcxetQDdexWd3+Q zbwfc5lVcKz/F3LdAJhhmOjbAO+7Wz2xOEwK0LVUFiI/G3Rl9GJy5yiOiIYdz2tiuG8D7Eqdj RidPlxbZAz7U749RyIZFAWEDd2BbvAr+D92thxoX1tdwNIBKT7I8IDPfNCGorvz6Ny5jhFjdl XuWC0KqHIC9wBTrbE+bjfHCaAR16i0QNQ8b4VDMCR1bTwwYTPEhNnN9/OCW5slGiVQNdvHLji X1zFJ42nXZukebZZ4IVyFOYlz2su1hIhuRNXjFj/U0iHwlr+ru+4mH5wIHvFJtB81Tkv3lbwh vUq0OlPCEwNTdU8BZSwtP5X3L9TCalc3fNIBV1PWkY0a4QzE6c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 22:22:25 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ioc4_serial.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/ioc4_serial.c b/drivers/tty/serial/ioc4_serial.c index 9524a6d3e1d8..6981ad2ca1b7 100644 --- a/drivers/tty/serial/ioc4_serial.c +++ b/drivers/tty/serial/ioc4_serial.c @@ -1075,7 +1075,7 @@ static inline int ioc4_attach_local(struct ioc4_driver_data *idd) /* Create port structures for each port */ for (port_number = 0; port_number < IOC4_NUM_SERIAL_PORTS; port_number++) { - port = kzalloc(sizeof(struct ioc4_port), GFP_KERNEL); + port = kzalloc(sizeof(*port), GFP_KERNEL); if (!port) goto free; @@ -2797,7 +2797,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) ret = -ENODEV; goto out1; } - serial = ioremap(tmp_addr1, sizeof(struct ioc4_serial)); + serial = ioremap(tmp_addr1, sizeof(*serial)); if (!serial) { printk(KERN_WARNING "ioc4 (%p) : unable to remap ioc4 serial register\n", @@ -2810,8 +2810,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) (void *)serial)); /* Get memory for the new card */ - control = kzalloc(sizeof(struct ioc4_control), GFP_KERNEL); - + control = kzalloc(sizeof(*control), GFP_KERNEL); if (!control) { ret = -ENOMEM; goto out2; @@ -2819,7 +2818,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) idd->idd_serial_data = control; /* Allocate the soft structure */ - soft = kzalloc(sizeof(struct ioc4_soft), GFP_KERNEL); + soft = kzalloc(sizeof(*soft), GFP_KERNEL); if (!soft) { ret = -ENOMEM; goto out3; -- 2.15.1