mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wenmeng Liu <quic_wenmliu@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Depeng Shao <quic_depengs@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
Date: Fri, 16 May 2025 15:34:28 +0800	[thread overview]
Message-ID: <db059233-523d-420b-81a7-73b02beef4d1@quicinc.com> (raw)
In-Reply-To: <4e81a1fe-3ee5-4f5f-b958-13e6cf9138f7@linaro.org>



On 2025/5/1 9:15, Bryan O'Donoghue wrote:
> On 30/04/2025 12:11, Konrad Dybcio wrote:
>> On 4/15/25 9:38 AM, Wenmeng Liu wrote:
>>> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
>>> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>>>
>>> SM8550 provides
>>> - 3 x VFE, 3 RDI per VFE
>>> - 2 x VFE Lite, 4 RDI per VFE
>>> - 3 x CSID
>>> - 2 x CSID Lite
>>> - 8 x CSI PHY
>>>
>>> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
>>> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
>>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>>> ---
>>
>> [...]
>>
>>> +                     <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
>>> +                     <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
>>
>> It *may* be 689 instead but I'm not 100% sure
>>
>> Otherwise the numbers look good
>>
>> Bryan, Vlad, please also take a look
>>
>> Konrad
>>
> 
> +                     <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
> This should be 689 yes
> 
> ---
> bod

Hi Bryan,Konrad,

I confirmed that the value is 688 instead of 689. The documentation 
incorrectly listed it as 689. To CC linux-media, I have resent the patch:
https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-quic_wenmliu@quicinc.com/

Thanks,
wenmeng

  reply	other threads:[~2025-05-16  7:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  7:38 Wenmeng Liu
2025-04-30 11:11 ` Konrad Dybcio
2025-05-01  1:15   ` Bryan O'Donoghue
2025-05-16  7:34     ` Wenmeng Liu [this message]
2025-05-16 10:15       ` Bryan O'Donoghue
2025-05-16 10:32         ` Wenmeng Liu
2025-05-16 10:41           ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db059233-523d-420b-81a7-73b02beef4d1@quicinc.com \
    --to=quic_wenmliu@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_depengs@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®