From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3126C175A6B for ; Mon, 17 Aug 2026 14:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977137; cv=none; b=VOVt9MotSpQoPnY2ZDhQPBNPurKyJvXg2nBpjtk3tywcVyPcHlby4vYXAeTsRDFqFkMmuzV6hV2nNnr0oY4RbA68W+A9YyHROSmArpRxMue0g8/NVb3kKCDNtgfvE8lxKwfMPqjxNf9ilZTaKi5UVg2MjfamA9eGtRP6aoCXFDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977137; c=relaxed/simple; bh=xwZgFuVB+a/x/YBNjBHaRQYJBj3ccpCUe6U9ChYIHv8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mKlKqq0okPuYHKeCAHSPK0t+qX7XR5IdQ3Pr3p8PP3xIykZfPtVgm0Oy1dKs1mvB7V7WgxzJOYr7W6XG2NC2WTXXaBG6UbAXGdVj69pJzE8vE8zmxYUcQCtsI7gd7OVSQxCE3fkXi4g3RuAYwv0Cb7ebXqlxbj4++QgyWoHdBpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a9I62IrA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B4Wqu6FI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a9I62IrA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B4Wqu6FI" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD61dM1929479 for ; Mon, 17 Aug 2026 14:32:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2gJlC7z96U2P7KeHUsrz93C7B3NJLrVoEmMO0j0t+PU=; b=a9I62IrA0sPgcTmW aZ4pQrHL0lwZDFgiX9zvh48qNCSjhRfT1CXGdJCTZsLQac087SYiAvupxU/74nZy OpC3YRNrkGLYet1Hb8IDGnYQfZbZLbcIEgUxVC+fs8y/Gw6TClvWw3Edg3oAsjOt WwZoxaUTZ/M/Cc/rAlnQdwAgt3d1wNt+OI7lwe8/B0ONr60yAAGSRT95gmiDiAfD zxiC2k+Bj78m4vZGzjyF/zfTE3nR3ynfQcJiqc92g5mj5/1e6f79YbxPrK9khsgp NapB4q/R3WITXod54E0bH3EUn5ZiEerf7UQehJkjVVC6D0XGC0racRORtDoAj7I3 4fHE8g== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3xx7haxm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 14:32:15 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5bf8356e54aso51870e0c.3 for ; Mon, 17 Aug 2026 07:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786977134; x=1787581934; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2gJlC7z96U2P7KeHUsrz93C7B3NJLrVoEmMO0j0t+PU=; b=B4Wqu6FIRvOrxBKun6bm8X4Ly3Ya0DRcqpFDw1oImim/2uB1tMH6e4L3IVVgZgzo2T zDCgb27yNkfnH9v2LBM3rg8AghqAPQofaV6mxisg78I4mP5JGwSTCU3KskkmzPVhaJuh J1WJ+xGPnFw6b0g0UCAWAZsTlDwiFugTZ4MmXRCpTqKvzZcEewWCZhrwICSNzd6prx9l bQc3Hvqn7i9S21xQ4s/jQezaucKTGjcmNRlkiEdQjAXLabBO8XT7jx7BiqJlk3tOBR/0 UcSC1TsiTnqkp5ajROJovAVGgsd6qlptkSuUkUMeclwWOCIrFBEzgt5cudNZe0/ZwlEc v5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786977134; x=1787581934; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2gJlC7z96U2P7KeHUsrz93C7B3NJLrVoEmMO0j0t+PU=; b=YjoU5W+4UGH7B6S4hI2b42aKV29utXmsFKmyZZR4mAEHVXh+NQoP98H1npGIcOiVnA UkvlrsHTh8+XLKsQoiTxNZdUksMv4AvIIq5VVcXk3fU1RTN9skBMGaxuogr5J91WztUD P108+yVzwFquKBCKXHA0zoEneeyNXLGi9Bg/nCQvH5ojpMm0XHA1+CU/79mhPJnI8t7o 9AD4NY3BmGLgTtP7MDo8Ltai1x2JzsMQNk8ZYXU1lnvMwV2re6A6ADsPKKhCqBMH8+ms cw64yEDPDfYr2QMyB7DnhlR1PYea+mMu8Eg6y2xbeIiT/PVbv8V00EmLieowwEzI5ej0 i8XQ== X-Forwarded-Encrypted: i=1; AHgh+RqNCoIVdCqPByDXV//2BAwz9Hre09fdTcsS854eid139jztrz7jolLmUSaIN1DGcVJtiY2SwqD79y+/zMg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5Pg4yWQN1KRnEmI0N9cw2TSztXzxfVfHo1stKo+WZ8yCeKASe 6LXe+e8X/fGQHcE8filq8q4m4cEc41nFW3B1edwl6v7YPbGHPG9YJY1tJmeoSUtCwtWoO7E6vfn j3+5FDWNjG6hLwO64Ttm9iYKJgtfPBi2pdorE4KkuDyjFH6xkIbpJVlg2pfU6pTB7lkQ= X-Gm-Gg: AR+sD10qEOLPkEFIzBdG73LMeBvkRqcWdaP5sgwq64/Kf04EbVtIUZYDqloyXH+y2Nb hsPY9n7QppV6HojYBpXsmz+tcYKZx5SOXHoDjubnY/vYuiIYDrcCUHRCuiFAxzq1TMnXg/Hjv5R 3i8sCeuBS7Ijor1+xxSelrCB3ruztNHp1j4OxaEDrBWGMk+uCJmehOxe0UyuHkt5Ynru6HATk/P a/2UQEHq4q+EaCqCr9iJgF7YM6DsVyRAunqb/Uqqt2V/7oM3Z1ElToiaUl1B94V898VrxD/QmdE sK8GRwR5SwFGI3H6Rr3tmyss1NqwcnX8LcI/rvgYRO8wOOJ8qHs/LtItLKyM9Qdp9GJrT6odhaQ MfwGbR/DzI9wY7y1WliFSs1Si X-Received: by 2002:a05:6102:5091:b0:74d:ce65:3e8b with SMTP id ada2fe7eead31-76f2c643703mr1642972137.2.1786977134372; Mon, 17 Aug 2026 07:32:14 -0700 (PDT) X-Received: by 2002:a05:6102:5091:b0:74d:ce65:3e8b with SMTP id ada2fe7eead31-76f2c643703mr1642778137.2.1786977130839; Mon, 17 Aug 2026 07:32:10 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d8530d3bsm833509a12.10.2026.08.17.07.32.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 07:32:09 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 16:32:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] power: supply: qcom_smbx: fix float voltage selector To: robin@snyders.xyz, Casey Connolly , Sebastian Reichel Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , stable@vger.kernel.org References: <20260812-qcom-smbx-fixes-v1-0-eb48246be599@snyders.xyz> <20260812-qcom-smbx-fixes-v1-3-eb48246be599@snyders.xyz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260812-qcom-smbx-fixes-v1-3-eb48246be599@snyders.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDExMSBTYWx0ZWRfXzQTnhkDTBIot 3rXZgg5+JqZU1oK5XsoKoSZv7Kpq1Z3TiD9hnJNFQqIs/3GsDfM7L+Hb394ptkfjf3q+07wdAQr 1l6mDiH1HVXbDdUBP6msFfatN3tQoyA= X-Authority-Analysis: v=2.4 cv=TK91jVla c=1 sm=1 tr=0 ts=6a831b6f cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=OsHF4jKAAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=d5mbiQXY12LgLljGaeIA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=XD7yVLdPMpWraOa8Un9W:22 a=aAwnOj5LE8VeXseigifb:22 X-Proofpoint-GUID: iIysGYEEafXYVOhbYH2FDZEBPOMbpcrw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDExMSBTYWx0ZWRfX1+AAZ8IDEmWY b6MDfUbSP4niEjEZ0v+9LHjpObjvXg/02wXTaByNxDyfvZNemRRYg05fUKLGeCpZX3py0/ezFAh AeFWc3yW0VO+m9QzRMZ65Uf/vR6zKf/TqxYwXf/xlr67zk/bDEjRntsT/4qiDao/nBxU0cyBSyx t/k8VuSeCEiJqRMgOVBEnUYMYyZFw5QhiHuOPXV8+ftiLa1qYRoF0/+OzCwkRryZzhKmvMe/2rK 8v7tZoWu6rPXusTqcsvhT6N+aS4loQakJWWgNVMYlmQf7o97cBsVVHhIxKFsjONFcqZWB59lX9j chbcleXVDOKg/b9aEjIQrD/uSR5dugEQ5a7SLEyiwhjpOVtRj3RuK7mvcDrTJtwiaoLj8/njI3F 6JTgR2oB7d0P8QsD+UWimNzQaSmhnbrmlLgGt9fCCaLAV+7TuZ/KFgmC3UVn1KdEooqffytwMRy GjclZEg3AU5EvUBOwkw== X-Proofpoint-ORIG-GUID: iIysGYEEafXYVOhbYH2FDZEBPOMbpcrw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170111 On 8/12/26 1:30 AM, Robin Snyders via B4 Relay wrote: > From: Robin Snyders > > FLOAT_VOLTAGE_CFG encodes 3,487,500 uV as selector zero and advances in > 7,500 uV steps. The current calculation adds one to that selector, so it > programs the requested float voltage one step too high. > > Remove the extra offset and name the hardware encoding constants. > > Fixes: 8648aeb5d7b7 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver") > Cc: stable@vger.kernel.org > Signed-off-by: Robin Snyders > --- Reviewed-by: Konrad Dybcio Konrad