From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbdJYPuo (ORCPT ); Wed, 25 Oct 2017 11:50:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54163 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdJYPuh (ORCPT ); Wed, 25 Oct 2017 11:50:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B00186A7EA Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=longman@redhat.com Subject: Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy To: Tejun Heo , Li Zefan , Johannes Weiner , Jonathan Corbet Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, Mike Galbraith , Christian Brauner , =?UTF-8?Q?St=c3=a9phane_Graber?= , Serge Hallyn References: <1507324230-22996-1-git-send-email-longman@redhat.com> From: Waiman Long Organization: Red Hat Message-ID: Date: Wed, 25 Oct 2017 11:50:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1507324230-22996-1-git-send-email-longman@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 25 Oct 2017 15:50:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2017 05:10 PM, Waiman Long wrote: > Given the fact that thread mode had been merged into 4.14, it is now > time to enable cpuset to be used in the default hierarchy (cgroup v2) > as it is clearly threaded. > > The cpuset controller had experienced feature creep since its > introduction more than a decade ago. Besides the core cpus and mems > control files to limit cpus and memory nodes, there are a bunch of > additional features that can be controlled from the userspace. Some of > the features are of doubtful usefulness and may not be actively used. > > After examining the source code of some sample users like systemd, > libvirt and lxc for their use of those additional features, only > memory_migrate is used by libvirt. > > This patch enables cpuset controller in the default hierarchy with a > minimal set of features. Currently, only memory_migrate is supported. > We can certainly add more features to the default hierarchy if there > is a real user need for them later on. > > For features that are actually flags which are set internally, they are > being combined into a single "cpuset.flags" control file. That includes > the memory_migrate feature which is the only flag that is currently > supported. When the "cpuset.flags" file is read, it contains either > "+mem_migrate" (enabled) or "-mem_migrate" (disabled). > > To enable it, use > > # echo +mem_migrate > cpuset.flags > > To disable it, use > > # echo -mem_migrate > cpuset.flags > > Note that the flag name is changed to "mem_migrate" for better naming > consistency. > > v3: > - Further trim the additional features down to just memory_migrate. > - Update Documentation/cgroup-v2.txt. > > Signed-off-by: Waiman Long Ping! Any comment on this patch? Cheers, Longman