From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 522112F8E8E for ; Wed, 16 Sep 2026 14:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789570120; cv=none; b=ApRwBLUti4qQRAjC0OuYD0NtL3RqZCCapHJEX3Wxpp7de6yazIQPa2RddXrWvDOSBWu6LRY32y2gR48rqWT6RQqKM4mDSS42lKSLbRiEahd3+p90rgBM7VepFaqONdnmAtmx6ceRnvNbSXgC9HJM4W62vsptB9nCmobdZHn7tzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789570120; c=relaxed/simple; bh=LFLlCZ6eo0An+zqE3d/JX6cVTgZD9Bf/pdv6Mf8v7Jg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZBeqKVBq2cZGi1c+n3YpwknpkL3VHzNdYX1zdgq0gF/KeyVwnT+w3H2wmI+183Z7PPTdqSpocOi1T651e4daI9qfK7yekIL1edYr9XZ6fbSKUrrkgQsCTyBjYa1AgSGQHXm8Ffl5l/4gJ/xid/k25rzp7PQ33IYIBBS7ywzZmJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mt/+REEc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IVR+NeoV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mt/+REEc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IVR+NeoV" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68GEYfFW4108854 for ; Wed, 16 Sep 2026 14:48:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MClUT4TtavLkI7XCoEvk0+UCbwWQqhP2+uEc+y3ikwQ=; b=mt/+REEc4uj4Arpu s7vtuKUSHba5OAClDsfs6CGNm7/nRvrLP0LgtOa9LE4hRVDHvWtuulEZB6LY4sGS VtQS7D2mFYeOIJ2JbJ8vUBuWnFVxmOHco4w/XwSpWOEDQHDJyewbAvY1FsvWC9bC 4houCnKE1u9gz2etICFZDjqsmCgU8jDvH2EROJtWI9R+AUYpZAdSxnNwna7yLoNK 1mOiNUGKpMaq2zP4xluLwWZLy59+zViuX9ww0ADgX5Gi7cEJmE10Dv8ibdEvuxRW YdxBLiKNMtymqHT8hZ0g1NWP0O5gBIfe0mn9GE+bzND71F/iL9APNSfeyQuUlScg kOmUzA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqefpbq1d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 14:48:37 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2db87f759c5so97336735ad.1 for ; Wed, 16 Sep 2026 07:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789570117; x=1790174917; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MClUT4TtavLkI7XCoEvk0+UCbwWQqhP2+uEc+y3ikwQ=; b=IVR+NeoV76uh9pO9qHWyOnve7qF6jUovXnqvADIlPP51r2I5BIOCLfZQiR8va2s43+ 9tflBWzrBTFlVX80VpfUCTxBO3RHGoh8Nbh5eNiJjNvHUGScuqEVyjUQVTbKU9X2WZ8c NxFiPSRc3JrrGJr9FxoWPmprR8d1eoZF5oeqBR9T5lK4XjKIIcdYzQwoq9X1iEuzwAGs w1s5YiI9wwa3XS0Qyb1Q/NfFQtIlgdeFL2sbCtz3hQgEGSKuS8YDeC8Oc3LAFRa0n2BI qOKkOC/hiy6wnzX3DCERuZDYAqg1IQNZuIIfV1xbNJ85aiSRG0H7pAAcObvZNba/kGin RRow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789570117; x=1790174917; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MClUT4TtavLkI7XCoEvk0+UCbwWQqhP2+uEc+y3ikwQ=; b=Wze/yNp1VprJFwBuTIkYNDYDbE4DOdIiw3+UfPCQVmRDzbo8YHkgQSnHyOQLqeSgoP ZtkdEBsQiRF67CpUnCjOSsP+33X0yfJ1xjPy8RdP8j9M4jXARDlA1QQh39JlO8WTthMf ss1yfPJ3CuyORYgHYQMuEMpPC6aGuKhM/h4eldvlWBi3g9J1Ngtx1riEGcpYNtXrfxNH 62jj8GNYHqvmkiSY/ti0edZuvum0DGFw/xphEAMwOtPj2Su7nIqsJ/kCr7pHuK2KrOrg XfO27qdJCn1PZeTUHQD3PaTF5y19+BL2N5nYfXEbYzWPbtAh1w46n5VOJAPs6IOfWuOI eiuw== X-Forwarded-Encrypted: i=1; AKwUvBx+EB5z9j5dWtGA7fT06j3i+rVsYLrL5VhYRxJGRPlP4Y+eHQYlUy9El4S8AnhkACRbaJUW5O81htV6Jv8=@vger.kernel.org X-Gm-Message-State: AFuF++m6I5VY5qlmfTz/hgA2Vs2zXf9tqeI69lH+U25mRdmS1iX8K+mP rEQNiU15tuJj1G9EgintLnjdx00XFz5pg/ZbASu23cEmY6ICEwYlqmWWFEZBxoqP9N/K8vXhzrE lQoG/rEVz8WfGW9Z6N2dXNGWxGasb8AYfUI8mfEZFZIN/DfQlLzkF68WzbK3kItxrbdSol/G5gP Lu0Q== X-Gm-Gg: AYBFou1B9gz+HYdhx2q1uoiKVW9SdICH5gNf/sNh/IEDFI7Dy7C5YySkb47wxW8/pVN G7SUVyuAh8XkKaIEQCoDiF4mhluGf9BeoibgVm3+KJTkSx0C5iSI7moTM664jpyjAHT3MmZsiXT sOVFo6e0KBRfhvU2mX8jFxteEKOUlFd99CVzOld4vvsFZhhtuTuLa06EOzkL+nT1fM84GtWAe0X NY9NvpxRneuA5B81jymOa7UjFptx6sciuz+f/4OnCPLHiIQoXLNqgHaM0nTNOZuHitWenFLTbj4 +MhWgJ8NEWmrPZ41lJrMm1YhlHNRsz9wVdK7f/W+U57mSj8NO8baxex9zr1M70LfMPkU9B1+GjA MA8ogX18ccR2dsdfwrx5OqJ8KjYKAGw1dNp2fTbYT X-Received: by 2002:a17:902:d582:b0:2d8:d4d0:7932 with SMTP id d9443c01a7336-2dd8e7aa6eemr64251305ad.22.1789570116619; Wed, 16 Sep 2026 07:48:36 -0700 (PDT) X-Received: by 2002:a17:902:d582:b0:2d8:d4d0:7932 with SMTP id d9443c01a7336-2dd8e7aa6eemr64250545ad.22.1789570116191; Wed, 16 Sep 2026 07:48:36 -0700 (PDT) Received: from [10.216.41.130] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dd89f02fc2sm13008905ad.59.2026.09.16.07.48.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2026 07:48:35 -0700 (PDT) Message-ID: Date: Wed, 16 Sep 2026 20:18:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: qcom: glymur: Add UFS nodes To: Abel Vesa Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , gopikrishna.garmidi@oss.qualcomm.com, jagadeesh.kona@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, nitin.rawat@oss.qualcomm.com, sibi.sankar@oss.qualcomm.com, Taniya Das References: <20260911-glymur_ufs_qcb_enablement-v1-0-b9fc5e2ee99a@oss.qualcomm.com> <20260911-glymur_ufs_qcb_enablement-v1-3-b9fc5e2ee99a@oss.qualcomm.com> Content-Language: en-US From: Pradeep Pragallapati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE5OSBTYWx0ZWRfX10NaQ4GPMdcp oY9zdEG6RbkJZi8EIW+pvU6TzNHBHDQJxXA1cQKgJlvy0Nv4NFeuT0xa7ZTVPE7koi/iw7BkJCd k69fTzpShVMukf3I+u/MdMF1SvG7/+8= X-Authority-Analysis: v=2.4 cv=HrTjiETS c=1 sm=1 tr=0 ts=6aaaac45 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=VTBryuNdlAkkI53dnxMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: AdQKBc20vtWloy6huuC--k9SdUzuaaHm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE5OSBTYWx0ZWRfX9Mki/ao9hgbR Ui9SHnKZ7XTvG44x44O0F2hj7zRttfI3dTfeHL0kFXithAJCF9XgWfH34QRLZOFKL70i+PfAOzT gArU/bcHpGMJx4Pad4exqq4YKP8C2YmC+izO9UtcLCcOfu4EJpmpzq1mhUVI9kE43RRsw1axVTt cceA2hgLFo5JzmKUsTJiOR6Tjucl51tW20JcUPCKWcaj0ExLtYjAz84GZAG0gk7srIgtQZsohcY jhvmnBD+J/ZyTW1SxO+0ldCq740gToTldF9JgDAQtUcktPnQjV433+uP23Zpi7B/u58bqOPxzbU WiXHi38LuaX5fovcOelHRnjWrbsd3DQAkMhean6apCw22B6TMz7LtAlYsRRalfQsO4WlKwbJVzk 3RV+rdFgwZPPYX6hPbl445CmgTOh0CJDUbkUNOydBbVvkaQJy1i5TG/Rh4VJL2WeCwHOvdKKQP0 CJmAwtxmLJM1TEQv+Eg== X-Proofpoint-GUID: AdQKBc20vtWloy6huuC--k9SdUzuaaHm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-16_02,2026-09-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160199 On 9/14/2026 7:36 PM, Abel Vesa wrote: > On 26-09-11 22:17:07, Pradeep P V K wrote: >> Add UFS PHY and UFS host controller nodes for Glymur SoC. >> >> Signed-off-by: Pradeep P V K > > One nit below. > > With Konrad's comments addressed, I think it looks good, so: > > Reviewed-by: Abel Vesa > >> --- >> arch/arm64/boot/dts/qcom/glymur.dtsi | 114 ++++++++++++++++++++++++++++++++++- >> 1 file changed, 111 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >> index 624a9edd602c..7bbc804ed340 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >> @@ -812,9 +812,9 @@ gcc: clock-controller@100000 { >> <0>, /* QUSB4 1 PHY RX 1 */ >> <0>, /* QUSB4 2 PHY RX 0 */ >> <0>, /* QUSB4 2 PHY RX 1 */ >> - <0>, /* UFS PHY RX Symbol 0 */ >> - <0>, /* UFS PHY RX Symbol 1 */ >> - <0>, /* UFS PHY TX Symbol 0 */ >> + <&ufs_mem_phy 0>, /* UFS PHY RX Symbol 0 */ >> + <&ufs_mem_phy 1>, /* UFS PHY RX Symbol 1 */ >> + <&ufs_mem_phy 2>, /* UFS PHY TX Symbol 0 */ >> <&usb_0_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, >> <&usb_1_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, >> <&usb_2_qmpphy QMP_USB43DP_USB3_PIPE_CLK>, >> @@ -4103,6 +4103,114 @@ rng: rng@10c3000 { >> reg = <0x0 0x010c3000 0x0 0x1000>; >> }; >> >> + ufs_mem_phy: phy@1d80000 { >> + compatible = "qcom,glymur-qmp-ufs-phy"; >> + reg = <0x0 0x01d80000 0x0 0x2000>; >> + >> + clocks = <&rpmhcc RPMH_CXO_CLK>, >> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, >> + /* UFS and PCIE4 shares the same clkref on glymur */ > > On top of Konrad's comment, I'd drop the "on glymur" part entirely here. sure, i will remove it in my next patchset.