From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36D0C4743D for ; Fri, 4 Jun 2021 21:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4B01611CA for ; Fri, 4 Jun 2021 21:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231329AbhFDVgC (ORCPT ); Fri, 4 Jun 2021 17:36:02 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:45672 "EHLO mail-oi1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbhFDVgB (ORCPT ); Fri, 4 Jun 2021 17:36:01 -0400 Received: by mail-oi1-f179.google.com with SMTP id w127so11092718oig.12 for ; Fri, 04 Jun 2021 14:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=26qfIffr86s4CSx7aIeetFiHkRJ+glhHxzWGfwTGLAA=; b=YowtD1Oz+2avuyj9t2u/Nc5zkHV1OLwMPRVYhMsEHWudqRKyR4U2MdpJ6u2a2cPl36 ZOLls3XfcRLeIb5SnMf4QPboprBKXMhV1QeKwzu2VsQJ88v67+PG3sTLlh+sAjlm0M6A XHp8cG0k5bN4gJQciZ3Jj/LgPIl1BAohIAAq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=26qfIffr86s4CSx7aIeetFiHkRJ+glhHxzWGfwTGLAA=; b=HLB/1872Efq6HIg+MI69dI9OPomX4v3gDD5GS2nIU5tXOv+OD6CbSNEZWL0SqMd/rf F+o/P2r3NEzqgxKUwimQNMGIRTNQfrydnYVRNhQyWEz/FgaCrDblBoHp6hJ0dTAi7jf2 Dt2P6GOmsHJsvdeU8eRDrkx1lNfs3+EoYgp9hipKT5tFNDLhaTMFYZSqH66p//Ei8XKj auCFSduDbZj+ynWnvsj4YgHYrXMltJvOzB10kC5WE9iZ3z5+KkS5LRWa0vvP/jC/Du+Y 8pyVr0xEzNyNavFBEluc8nkrmHUil/aBAz/c6pAiNlYWEAW4PoywVRVKxhWW2KGnMKXD IdTg== X-Gm-Message-State: AOAM530/Mzvz3uxWJfxmJ2EaANDSVkOujot5pbsErBBnMZH73rqSEDBB x4YtjN6oc8kQA4xLc1MjDPsrog== X-Google-Smtp-Source: ABdhPJxtMs37Tt5c2q7sz8sRDm/dVdIgrxzsqhKbaUQGuWslfv7/PkAd/2Wf8nLaDSxYV7UfT4Xb6Q== X-Received: by 2002:aca:4a4b:: with SMTP id x72mr3786591oia.18.1622842394563; Fri, 04 Jun 2021 14:33:14 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id s15sm111743oih.15.2021.06.04.14.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 14:33:14 -0700 (PDT) Subject: Re: [PATCH][RESEND] selftests: splice: Adjust for handler fallback removal To: Kees Cook , Shuah Khan Cc: kernel test robot , Christoph Hellwig , linux-kselftest@vger.kernel.org, Al Viro , linux-kernel@vger.kernel.org, Shuah Khan References: <20210527032537.3730425-1-keescook@chromium.org> From: Shuah Khan Message-ID: Date: Fri, 4 Jun 2021 15:33:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210527032537.3730425-1-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/21 9:25 PM, Kees Cook wrote: > Some pseudo-filesystems do not have an explicit splice fops since adding > commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops"), > and now will reject attempts to use splice() in those filesystem paths. > > Reported-by: kernel test robot > Link: https://lore.kernel.org/lkml/202009181443.C2179FB@keescook/ > Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops") > Cc: Christoph Hellwig > Cc: Shuah Khan > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Kees Cook > --- > Resend of https://lore.kernel.org/linux-kselftest/20201005204517.2652730-1-keescook@chromium.org/ > --- > .../selftests/splice/short_splice_read.sh | 119 ++++++++++++++---- > 1 file changed, 98 insertions(+), 21 deletions(-) Will pick this up for 5.14 thanks, -- Shuah