From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9FBC433EF for ; Thu, 2 Jun 2022 03:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233500AbiFBDOM (ORCPT ); Wed, 1 Jun 2022 23:14:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233470AbiFBDOL (ORCPT ); Wed, 1 Jun 2022 23:14:11 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB42E2AE9D6; Wed, 1 Jun 2022 20:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1654139650; x=1685675650; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=vtq2/jv6E7he02OBQkaRLx57XKXT76AR0NCvMqUoMWU=; b=SWlaBu4jNWH3vGfEYLCXWfyKxVr/zTSZtbG8yxOk/1lKV6mVU7fONNY8 alO/moXnmBFEVPT1mAr97OSFPXUHSMdxBMaPVMKJlTulWqsYVWqvcMirp l8HLiudslPHW/31OA5P0BpG5yCZ0q3ii78Tq3QVzOsNc3kDX4ADtJt/KH s=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 01 Jun 2022 20:14:09 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 20:14:09 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 1 Jun 2022 20:14:09 -0700 Received: from [10.253.36.238] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 1 Jun 2022 20:14:04 -0700 Message-ID: Date: Thu, 2 Jun 2022 11:14:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7 02/10] Coresight: Add coresight TPDM source driver Content-Language: en-US From: Jinlong Mao To: Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach CC: Greg Kroah-Hartman , , , , Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , , Bjorn Andersson References: <20220509133947.20987-1-quic_jinlmao@quicinc.com> <20220509133947.20987-3-quic_jinlmao@quicinc.com> <38bb1ec9-56bc-0cdf-6c46-d448a46ec886@arm.com> <7d6b2e24-21f4-eef1-a722-23cdcd1d8a88@quicinc.com> <006b7edd-20d2-3165-7c83-352b7fb312e7@arm.com> <2da46bcb-c1e4-dbde-c4ee-1d6983565dc9@quicinc.com> In-Reply-To: <2da46bcb-c1e4-dbde-c4ee-1d6983565dc9@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/2022 5:56 PM, Jinlong Mao wrote: > > On 6/1/2022 5:30 PM, Suzuki K Poulose wrote: >> On 01/06/2022 10:21, Jinlong Mao wrote: >>> Hi Suzuki, >>> >>> On 5/24/2022 3:00 PM, Jinlong Mao wrote: >>>> Hi Suzuki, >>>> >>>> Thank you for the review. >>>> >>>> On 5/23/2022 4:57 PM, Suzuki K Poulose wrote: >>>>> Hi >>>>> >>>>> On 09/05/2022 14:39, Mao Jinlong wrote: >>>>>> Add driver to support Coresight device TPDM (Trace, Profiling and >>>>>> Diagnostics Monitor). TPDM is a monitor to collect data from >>>>>> different datasets. This change is to add probe/enable/disable >>>>>> functions for tpdm source. >>>>>> >>>>>> Signed-off-by: Tao Zhang >>>>>> Signed-off-by: Mao Jinlong >>>>>> --- >>>>>>   drivers/hwtracing/coresight/Kconfig          |  13 ++ >>>>>>   drivers/hwtracing/coresight/Makefile         |   1 + >>>>>>   drivers/hwtracing/coresight/coresight-core.c |   5 +- >>>>>>   drivers/hwtracing/coresight/coresight-tpdm.c | 146 >>>>>> +++++++++++++++++++ >>>>>>   drivers/hwtracing/coresight/coresight-tpdm.h |  26 ++++ >>>>>>   include/linux/coresight.h                    |   1 + >>>>>>   6 files changed, 191 insertions(+), 1 deletion(-) >>>>>>   create mode 100644 drivers/hwtracing/coresight/coresight-tpdm.c >>>>>>   create mode 100644 drivers/hwtracing/coresight/coresight-tpdm.h >>>>>> >>> >>>>>> +/** >>>>>> + * struct tpdm_drvdata - specifics associated to an TPDM component >>>>>> + * @base:       memory mapped base address for this component. >>>>>> + * @dev:        The device entity associated to this component. >>>>>> + * @csdev:      component vitals needed by the framework. >>>>>> + * @lock:       lock for the enable value. >>>>>> + * @enable:     enable status of the component. >>>>>> + */ >>>>>> + >>>>>> +struct tpdm_drvdata { >>>>>> +    void __iomem        *base; >>>>>> +    struct device        *dev; >>>>>> +    struct coresight_device    *csdev; >>>>>> +    struct mutex        lock; >>>>> >>>>> Why mutex lock ? Couldn't this be a spinlock ? >>>> 1. There is no irq for TPDM >>>> 2. As there are 7 dataset types, there will be some FOR loop to >>>> configure >>>> tpdm registers which may cause some time. >> >> How long does it take to configure ? Is it too long enough to trigger >> RCU stalls ? as long as we don't do any sleeping/blocking operations >> we should be fine with a spinlock. >> >> Suzuki > > Let me check on internal device and get back to you. > > Thanks > Jinlong Mao The time of configuring the registers doesn't reach RCU stall timeout value. I will use spin_lock for both tpdm and tpda. Thanks Jinlong Mao >> >>>> >>> I think we can use mutex lock here. Do you have any more comments >>> for this ? >> >>> >>> Thanks >>> Jinlong Mao >>>>> >>>>>> +    bool            enable; >>>>>> +}; >>>>>> + >>>>>> +#endif  /* _CORESIGHT_CORESIGHT_TPDM_H */ >>>>>> diff --git a/include/linux/coresight.h b/include/linux/coresight.h >>>>>> index 247147c11231..a9efac55029d 100644 >>>>>> --- a/include/linux/coresight.h >>>>>> +++ b/include/linux/coresight.h >>>>>> @@ -61,6 +61,7 @@ enum coresight_dev_subtype_source { >>>>>>       CORESIGHT_DEV_SUBTYPE_SOURCE_PROC, >>>>>>       CORESIGHT_DEV_SUBTYPE_SOURCE_BUS, >>>>>>       CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE, >>>>>> +    CORESIGHT_DEV_SUBTYPE_SOURCE_DATA_ONLY, >>>>> >>>>> super minor nit: I find the choice of name a bit odd. >>>>> We could simply make it something like : >>>>> >>>>>     CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS: >>>>> >>>>> Suzuki >>>> I will check and update. >>>>> >>>>>>   }; >>>>>>     enum coresight_dev_subtype_helper { >>>>> >>>>> _______________________________________________ >>>>> CoreSight mailing list -- coresight@lists.linaro.org >>>>> To unsubscribe send an email to coresight-leave@lists.linaro.org >>>> _______________________________________________ >>>> CoreSight mailing list -- coresight@lists.linaro.org >>>> To unsubscribe send an email to coresight-leave@lists.linaro.org >> >> _______________________________________________ >> CoreSight mailing list -- coresight@lists.linaro.org >> To unsubscribe send an email to coresight-leave@lists.linaro.org > _______________________________________________ > CoreSight mailing list -- coresight@lists.linaro.org > To unsubscribe send an email to coresight-leave@lists.linaro.org