From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759334AbcILNGR (ORCPT ); Mon, 12 Sep 2016 09:06:17 -0400 Received: from foss.arm.com ([217.140.101.70]:49770 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758676AbcILNGN (ORCPT ); Mon, 12 Sep 2016 09:06:13 -0400 Subject: Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text To: Colin King , Russell King , Vineet Gupta , Hans-Christian Noren Egtvedt , Joerg Roedel , Jesper Nilsson , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org References: <20160912125212.32739-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Robin Murphy Message-ID: Date: Mon, 12 Sep 2016 14:06:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160912125212.32739-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/16 13:52, Colin King wrote: > From: Colin Ian King > > A dev_warn message spans two lines and the literal string is missing > a white space between words. Add the white space. > > Signed-off-by: Colin Ian King > --- > arch/arm/common/dmabounce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c > index 3012816..f47767b 100644 > --- a/arch/arm/common/dmabounce.c > +++ b/arch/arm/common/dmabounce.c > @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev) > > if (!device_info) { > dev_warn(dev, > - "Never registered with dmabounce but attempting" > + "Never registered with dmabounce but attempting " > "to unregister!\n"); Per Documentation/CodingStyle, better to put the whole thing onto one line so that, say, "git grep 'attempting to unregister'" doesn't leave one scratching ones head in confusion. Of course, even better would be to get rid of the whole thing and convert ARM to use SWIOTLB, but hey, one thing at a time ;) Robin. > return; > } >