From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E5228CF77 for ; Tue, 9 Jun 2026 13:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011503; cv=none; b=fbCVv43ZsYPL17ckn+uB3tnTLEFFIPy/v9/vl03Cc3d4MHqpn9gqRf65IhSCGGfYMJ1Zm7GaNVQhREHFoqGVdCCwsBDiP7pPmq/oCm6Ht2oV8Esy5y40vrLaA4a8w7I4hTFC/wDGcXrD63aC08YBHdEOzFk2EGo3qy28Gn6eT8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011503; c=relaxed/simple; bh=TGP3thYwS5cQEvKp3bq6AQJmDxlBqvBlj4kGcWvPqvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WdV/VSj0+RVwirNzxQ6H+LLhbQJFGvdbSa56BLoIc0ocmXmSjyd8rSDuNHw/GR+QswdwemXvPIL+MxvmqCwumnmek5dLopbLP1zwkeRy5WrXdWHyp45pSWa5OZCH5l0XhCklE2lHyZEHxqJlmIJb5RlVP2vlqoiN0+vBxGAlXag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z69CVyS/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NICOCO43; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z69CVyS/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NICOCO43" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659ClVQH2706172 for ; Tue, 9 Jun 2026 13:24:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0GSvQb4RyHDcKwjA04narD1yN7pysrwi3CeTU0bbhZE=; b=Z69CVyS/18J9r58K qULq/j/zWPbC3t5keUjm+Z+ATHHfCJ6YtmcZP8DEB8+t10j5DGIJk7t/uWQUggqj +r8WtH5cMOs3kyw58aEzDh22qBUSK9qzZzjfmDaWln+oYKwflwfRN/1dEShTo20D c4AhMURJladJhfo8oWohK5thhRHYjSc+fhAs3SKF/vOTh9EtmY3WHpIzGQ/149K6 xdfKbiuNZXntU41dBKprZ55v/490uB77CWuIvrEJ0uPrYmJXrzYwrDceOnLcpuTu m0XksTQAJvY7js9cUjBnp2CpoJnxyKW96PxbOybzDgpLBy7mpXX+K94FRr2pL9Ro reIDQg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epfdt18pm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 13:24:59 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c857ebbb0easo3719523a12.1 for ; Tue, 09 Jun 2026 06:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781011499; x=1781616299; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0GSvQb4RyHDcKwjA04narD1yN7pysrwi3CeTU0bbhZE=; b=NICOCO43Di7sYRKHfbUg2tz3/RHDKcZ24DQgZrYfVCwklVXw7d8z8TEhB437V9y6CK 2ZnF7IgkOzHBYnmwmAZ8RXZArG2XAd3dOAWsO2BceWx2Bhbh3qBu44kEOJDvqAVhQKD1 9JoSLSp/pbLhMGeYNmoolQIFtWPVVzR0z4ccc3jenDywImuSPdZGWJml8n57WKHLEQSd 1Lh+sakCCspgY0k2HZ7DNGvn/vg2cCEZvOR6iQ5OY38cv31BuvyEGZ1CsE04v/0LPkK2 WrmtJmG5R9vwVLo3izLIPywyJntyEeYWoGhAXl2ijTXiTuyYmrfwSNuEQ//l3zsICuUY /WRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781011499; x=1781616299; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0GSvQb4RyHDcKwjA04narD1yN7pysrwi3CeTU0bbhZE=; b=l7Qy6BA5Bnp1r0BNGOiKPFCfkBfGYxo8rPpEcP4J2Q8W7M6YKcIluVQJ/gX/J/L3vH 6a79+BlUn566Kz61U7G4k7F6YsjBsD5QH4YvWj0mPyKZVfSw+eDvShLunhuMpwg9Byws FFUBeMhB0rb4Pcxri7Iq+EjQL9zUqw9IqDsc2Sv8/WAi8uI2YWGxuE4mOl0Q4IxdvHrD SO/O32pgV1lRhXZNYBS5+GNDRAj6u5ojQFsGxo6wmhgEnkjbenkDqyhhy0Eo1nq+hSd/ lUKRSIYng8NlDXsTXMKYkF90e+W+iZOGKBj4oE/0rf82n0nSYdmeQ3t+vpgAtD7kdre5 Kg4A== X-Forwarded-Encrypted: i=1; AFNElJ/eRb/4RToe8K4JtTGEz5VhvTwRThFC0n/2Vpj2r/Qn3n33c9aqC89sP0REvFJI9/zlN/sdH+untp34nqo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0d0M7uEUA+QO6DkMf95NLaIRoVVELbyGt9Gy1H88vAUlvsQxo gEgCWHYBBs+lUXCGumEJJs0piPABumhbDJptDCmtvqpUNtCmRXn4Oa4xkUtpAepimXDbn2//cjp hfU3bGrkXWToDhqHtIRtXvjZ6yOkX2l2j9F2mxtPsY+ENn4z8rMC9ze9ox7fUlVRKufo= X-Gm-Gg: Acq92OHPWcyu65cneglGr5rKvGalCfBMOU9uZm7Q8jCG5S6RX+YF18yBtO07DCSZ8qB i3sUxBbFwf1u19q3VfiYQhCpUAAaVseVGN2QRrSWeYzDOnFnn3shShk9dJa9cfY/ayYQfBDJLGs WMnZEhE8ZwRhBU4pMq+3tqZbO5fZg8Dl+ejCfLs+FVECaqMuK5NTsZhqqPhzDAknIM/up1a4vWq egH+0/jpUGYfooSRx0xTXj2fVllzeeFMTb5TKVzGcXSbej/xsKTGrGldE38Ma6BaUD6VbIhSlIo E2rWhS5/mWKSmp0Ec8CIRzboexdCoVT+Npy/MmLDEzA5TyT3tqOfWYfM09qgPc8ftX+R6y3WF4u UyUcooDaSMBEsCVuL9bUvIWIeprL9GwJsZhHfgTdZedNtXYnynR/SSgCK+Xca0pU9sTo= X-Received: by 2002:a17:902:cf07:b0:2b9:cabe:ce37 with SMTP id d9443c01a7336-2c1ec3f5cb8mr168553045ad.1.1781011498611; Tue, 09 Jun 2026 06:24:58 -0700 (PDT) X-Received: by 2002:a17:902:cf07:b0:2b9:cabe:ce37 with SMTP id d9443c01a7336-2c1ec3f5cb8mr168552765ad.1.1781011498094; Tue, 09 Jun 2026 06:24:58 -0700 (PDT) Received: from [10.92.193.107] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164fa072asm212244575ad.34.2026.06.09.06.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 06:24:57 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 18:54:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver To: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Gaurav Kohli References: <20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com> <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> Content-Language: en-US From: Manaf Meethalavalappu Pallikunhi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: loUgrDTOfqEGCvmlqVSXC3gRMLdnK36e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEyNyBTYWx0ZWRfXy2yD0h59b8vK 0GHledh+YaZ79FZr+BX77ZUPh1UlJg7aXjIY2gPbtJzMMwu2JjB7thV5XaOaC/GOrxSY5r6D3pM IesPs/uMmmY6nNO/TDzF+m9cIVy7SVvQhXZn7QnELUOs3A9zmMMCD1LajEjAHp+lIJGNXaLYnH6 1ueXjrGNIftkBh1MXWEafnL6ZtNH46P86s/f791giDBQb+6Gr+TsBqBlsHWeISCY/rshIhpSYzy te7uXgFfl6vFmGcGdKdHDmgk65OU7cBJeEVv18tpk1QqB7vB1MR9XV/y2BlAvQiQ3cQgIL7AdY1 4TaK830pOy4O30P1pmuyLZLLlVweNp0CctgCtP3SJc93ykNmp8bgjMfylNPW9W1g2qo68CAnsV8 NZ3daQQS9ihkfHYkB5BxvMI1P6Q0gONRrpYaedknivAUebbWEUphY9rKLEXl9HS0ncrVz7sPqz6 e6X26n8EehFkf4Q6ROA== X-Proofpoint-GUID: loUgrDTOfqEGCvmlqVSXC3gRMLdnK36e X-Authority-Analysis: v=2.4 cv=doTrzVg4 c=1 sm=1 tr=0 ts=6a28142b cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=fz3elM8aSJ4FunxCNjAA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090127 Hi Konrad, On 5/21/2026 4:47 PM, Konrad Dybcio wrote: > On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote: >> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >> based power monitoring and limiting capabilities for various power >> domains including System, SoC, CPU clusters, GPU, and various other >> subsystems. >> >> The driver integrates with the Linux powercap framework, exposing SPEL >> capabilities through powercap sysfs interfaces. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> --- > > [...] > >> +/* Constraint configuration */ >> +static struct spel_constraint_info constraints[] = { >> + /* SYS domain constraints */ >> + { 0x10, 0x70, BIT(0), SPEL_DOMAIN_SYS, POWER_LIMIT1 }, >> + { 0x14, 0x74, BIT(1), SPEL_DOMAIN_SYS, POWER_LIMIT2 }, >> + { 0x18, 0x78, BIT(2), SPEL_DOMAIN_SYS, POWER_LIMIT3 }, >> + { 0x1C, 0x7C, BIT(3), SPEL_DOMAIN_SYS, POWER_LIMIT4 }, >> + /* SOC domain constraints */ >> + { 0x00, 0x60, BIT(4), SPEL_DOMAIN_SOC, POWER_LIMIT1 }, >> + { 0x04, 0x64, BIT(5), SPEL_DOMAIN_SOC, POWER_LIMIT2 }, >> + { 0x08, 0x68, BIT(6), SPEL_DOMAIN_SOC, POWER_LIMIT3 }, >> + { 0x0C, 0x6C, BIT(7), SPEL_DOMAIN_SOC, POWER_LIMIT4 }, > > Lowercase hex, please > > Can this data be const? ACK Thanks, Manaf > > Konrad