From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD9235CB90 for ; Tue, 27 Jan 2026 15:27:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527656; cv=none; b=H1YMt+bxwHXgx7nFoSw61OxUPbSQOkZQa/y0OmenZOyR2GZZb1ajN5TEFaziKnQddTRvKgZey2UWqdFlhL09a4f1W82xQg/hCxAsSUeLPIZvXQ+wfARafAGp2ScQQnTgQr9nOf6rjTZKnsonrc3koiQQLqNsjCWjH0aG8ZYTA/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527656; c=relaxed/simple; bh=MlddXsYf87hGYfOKVa1wJHVVYJztAWf5FHysi4CL61M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pu5I8PJyPJGDwwt+IibTWfwsEh3bRCjCfCyWvU53kITgVQHc3PJVwmKgfSTERIDeH3JsGBXV4jiUyiJsxrUeGfp/nwOTvrBk6P8/BPE6B+G8kRJMWdRz2nylkn3YkWpYogj22XhUY2zr7YW2U5VEA42VbiTtjcn2gUfpqHl8cdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=AfNrCqwM; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="AfNrCqwM" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R6a6u8029828; Tue, 27 Jan 2026 15:27:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=phj5gm gA0p5xZvUpGcKouuV8NL9H6J/RLD0i/eQBMoU=; b=AfNrCqwMtXIP6LLlPkJo7N CIRt9w5L7GNKWbQcfC0BAyMbsXdBd2gCnl2DUBiNP+w/7hlzRNuCqKd4V3H6D//Z TuV1ECZQtiHpCHxvJ1VXkY/qCLtPp5/DFbbtsRj5Rc2vnwv/+Ry3nAaimtUWyXPl kEZ9G3ubTeQN4HFVfLZpwo8C4aF/mLqXYe48pSV44nzBD1WtWdBZnDgZcKrDZd8E CSigJDnDpfv+v1BjdyU+a4QivvsamQwiLhJerdNV9RXDgn1c3peVV/0Ke6XlUkn5 ESxyq3Nmf2+hPyvkR07ZhsqZvWNwQgKV7PhuP8vv4FninEifgaxixUjsoXzHDZcg == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvnrte331-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:27:31 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60RD691e019647; Tue, 27 Jan 2026 15:27:30 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bw9dn15x7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:27:30 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFRTHi37683878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:27:30 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BCBF558056; Tue, 27 Jan 2026 15:27:29 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8FFC958052; Tue, 27 Jan 2026 15:27:29 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:27:29 +0000 (GMT) Message-ID: Date: Tue, 27 Jan 2026 09:27:29 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/13] fsi: i2cr-scom: Convert to fsi bus probe mechanism To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <694a7d077316c3e2883a8410eade67cd578ee556.1765279318.git.u.kleine-koenig@baylibre.com> Content-Language: en-US From: Eddie James In-Reply-To: <694a7d077316c3e2883a8410eade67cd578ee556.1765279318.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0AamFmR78QY9CzWfeaj21qtDpDdJY756 X-Authority-Analysis: v=2.4 cv=Uptu9uwB c=1 sm=1 tr=0 ts=6978d963 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=tBGaI7FyF7HGntYExgwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: 0AamFmR78QY9CzWfeaj21qtDpDdJY756 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyMSBTYWx0ZWRfX/YviyT6tL4Sx PSDbkOowLNb3QxYgGAJUVf2iwZ9OZwHckA9sPv1CS56AFAreyXk8sgwu47T8gP1mI01fQptWpSd 3lXsUUVxPJb1iP0QX71SZ7j8G7F9gMgDISwb2ips2VF2j7k4uJy3RNPdkSOQbSDCJUB1dta91OS PAIL1XbyXPkQ05zTl5ecG3jMrPEoER08HQBlh9dMXlgZbHkwuy5GKs7TvCSIyC8KletNzEEdHSN Yf2WoHLqhRnezo3pAEu706WYAx+lNBDkXpB9Iq7bLDwJf563SKT2WkA2YOe263YgZEPPVSiGQqO 1nYvseCFE1i6v1xrCM2JSeWPVGbj8jSv5GGDaQEBI9u3p+14mkJ9H5TgvMS4IMcA/k0VOCh3Sis jm47g3SRg95+U7IqIdUFmbihkmvibNCVth/bvwhgksdcMUlZy6l9EWOahBgn+FRVriJocldjyDM jVvblYqyEBncxKyaiXw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270121 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > The fsi bus got a dedicated probe and remove callback. Make use of them. > This fixes a runtime warning about the driver needing to be converted to > the bus methods. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > --- > drivers/fsi/i2cr-scom.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/fsi/i2cr-scom.c b/drivers/fsi/i2cr-scom.c > index dfdb16afd205..3efca2e944bb 100644 > --- a/drivers/fsi/i2cr-scom.c > +++ b/drivers/fsi/i2cr-scom.c > @@ -81,9 +81,9 @@ static const struct file_operations i2cr_scom_fops = { > .write = i2cr_scom_write, > }; > > -static int i2cr_scom_probe(struct device *dev) > +static int i2cr_scom_probe(struct fsi_device *fsi_dev) > { > - struct fsi_device *fsi_dev = to_fsi_dev(dev); > + struct device *dev = &fsi_dev->dev; > struct i2cr_scom *scom; > int didx; > int ret; > @@ -115,14 +115,12 @@ static int i2cr_scom_probe(struct device *dev) > return ret; > } > > -static int i2cr_scom_remove(struct device *dev) > +static void i2cr_scom_remove(struct fsi_device *fsi_dev) > { > - struct i2cr_scom *scom = dev_get_drvdata(dev); > + struct i2cr_scom *scom = dev_get_drvdata(&fsi_dev->dev); > > cdev_device_del(&scom->cdev, &scom->dev); > fsi_free_minor(scom->dev.devt); > - > - return 0; > } > > static const struct of_device_id i2cr_scom_of_ids[] = { > @@ -137,12 +135,12 @@ static const struct fsi_device_id i2cr_scom_ids[] = { > }; > > static struct fsi_driver i2cr_scom_driver = { > + .probe = i2cr_scom_probe, > + .remove = i2cr_scom_remove, > .id_table = i2cr_scom_ids, > .drv = { > .name = "i2cr_scom", > .of_match_table = i2cr_scom_of_ids, > - .probe = i2cr_scom_probe, > - .remove = i2cr_scom_remove, > } > }; >