mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Linux regressions mailing list <regressions@lists.linux.dev>,
	Jarkko Sakkinen <jarkko@kernel.org>
Cc: keyrings@vger.kernel.org,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	 Pengyu Ma <mapengyu@gmail.com>
Subject: Re: [regression] significant delays when secureboot is enabled since 6.10
Date: Tue, 10 Sep 2024 08:22:00 -0400	[thread overview]
Message-ID: <db275ab4fb73fc089c66738ffbcab23557e53055.camel@HansenPartnership.com> (raw)
In-Reply-To: <0b4a5a86-a9f6-42d1-a9ba-ec565b336d3a@leemhuis.info>

On Tue, 2024-09-10 at 11:01 +0200, Linux regression tracking (Thorsten
Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker.
> 
> James, Jarkoo, I noticed a report about a regression in
> bugzilla.kernel.org that appears to be caused by this change of
> yours:
> 
> 6519fea6fd372b ("tpm: add hmac checks to tpm2_pcr_extend()") [v6.10-
> rc1]
> 
> As many (most?) kernel developers don't keep an eye on the bug
> tracker, I decided to forward it by mail. To quote from
> https://bugzilla.kernel.org/show_bug.cgi?id=219229 :
> 
> > When secureboot is enabled,
> > the kernel boot time is ~20 seconds after 6.10 kernel.
> > it's ~7 seconds on 6.8 kernel version.
> > 
> > When secureboot is disabled,
> > the boot time is ~7 seconds too.
> > 
> > Reproduced on both AMD and Intel platform on ThinkPad X1 and T14.
> > 
> > It probably caused autologin failure and micmute led not loaded on
> > AMD platform.
> 
> It was later bisected to the change mentioned above. See the ticket
> for more details.

We always suspected encryption and hmac would add overheads which is
why it's gated by a config option.  The way to fix this is to set

CONFIG_TCG_TPM_HMAC to N

of course, TPM transactions are then insecure, but it's the same state
as you were in before.

James



  parent reply	other threads:[~2024-09-10 12:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10  9:01 Linux regression tracking (Thorsten Leemhuis)
2024-09-10  9:05 ` Roberto Sassu
2024-09-10 12:39   ` Jarkko Sakkinen
2024-09-10 12:48     ` Jarkko Sakkinen
2024-09-10 12:57       ` James Bottomley
2024-09-10 13:28         ` Jarkko Sakkinen
2024-09-11  8:53           ` Roberto Sassu
2024-09-11 12:21             ` James Bottomley
2024-09-12 13:16               ` Jarkko Sakkinen
2024-09-12 13:26                 ` James Bottomley
2024-09-12 13:36                   ` Roberto Sassu
2024-09-12 14:13                     ` James Bottomley
2024-09-12 14:52                       ` Roberto Sassu
2024-09-12 14:26                   ` Jarkko Sakkinen
2024-09-14 10:42               ` Jarkko Sakkinen
2024-09-14 10:51                 ` Jarkko Sakkinen
2024-09-14 10:58                   ` Jarkko Sakkinen
2024-09-11 15:14             ` Jarkko Sakkinen
2024-09-12  8:13               ` Roberto Sassu
2024-09-12 14:23                 ` Jarkko Sakkinen
2024-09-13 20:50                 ` Jarkko Sakkinen
2024-09-13 22:06                   ` Jarkko Sakkinen
2024-09-15  9:43                 ` Jarkko Sakkinen
2024-09-15 10:07                   ` Jarkko Sakkinen
2024-09-15 13:59                     ` James Bottomley
2024-09-15 14:50                       ` Jarkko Sakkinen
2024-09-15 14:55                         ` Jarkko Sakkinen
2024-09-15 15:00                         ` James Bottomley
2024-09-15 16:22                           ` Jarkko Sakkinen
2024-09-21 15:40                             ` Jarkko Sakkinen
2024-09-22 14:11                               ` Jarkko Sakkinen
2024-09-10 12:22 ` James Bottomley [this message]
2024-09-10 12:41   ` Linux regression tracking (Thorsten Leemhuis)
2024-09-10 22:40     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db275ab4fb73fc089c66738ffbcab23557e53055.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mapengyu@gmail.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®