From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F0C3FADF4 for ; Fri, 15 May 2026 08:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833788; cv=none; b=rwjp/6OSDxOIjPC3ZyPxSai1zgUqp63jBu/V9uG3q11rwJJ7CImqASpfqa2tIgb2d7O0M6yDmyAtdXSDRnldB8nV5+5jB8huTrG7v7g7+faDKXU/kkXgyzT9cE46mYM71/U33za0Q7I7X4vE8xfvITAiulO87+MFVMa6T1YSdX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778833788; c=relaxed/simple; bh=x7CFAFj5m9ZA6ar4UuYjjngctLltesIcNx9zgE6N7Zk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=muJB+hx0FCosKPn4U9CoRED651fpu317vSHfDYwq/7wU+ufawBhDLadTZTPcWkBNsPQCORH9rC9XPTDZlaD3i9PM/ypc5/e/JobHTzZqH/leg19UjRLRKsBNDmDloonb+rwDxcEYZKdWh9Piy1hb34K5nhPUmcpyMy96j/yy8xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U78OPecd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PojPeHyi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U78OPecd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PojPeHyi" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F55okR3512832 for ; Fri, 15 May 2026 08:29:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UllOcT04Arph9Lb63WObBizd6O2TUa0jc9E2byhLXl4=; b=U78OPecdnUfCWohB YQsmtqT0T2tkg8OR8wfWdAdSEZq3xPHwMfbSnHGBgnglliTFLfpFj0vsgDPFbTcx m4AtF4pLinB53TeA4SJtZgf1N0Vpiz5Z3hJ4YxbWrIJNaDxOLKbodlakIyHyWPoJ JsuJ/gSbsyIkqCWU59I3FBjHe3r61+/pNusiKQ+DP8NTiJ2Ex8Vvbhz8r8RvJ+he EjLP5YqRRh41J3rDq6yqp7z/jCWYzhukQV3UwSI1I0P/iLapTdniNs3FcZyc4Kop IwAcwqfPkO2zXRfZK25LFc8v5fKPmZ7FZWzp0uYsCcqr/JntzL/VLaJye47bT7Oj eeJ2tQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1vad20-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 08:29:45 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51494d74d4bso19342501cf.1 for ; Fri, 15 May 2026 01:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778833785; x=1779438585; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UllOcT04Arph9Lb63WObBizd6O2TUa0jc9E2byhLXl4=; b=PojPeHyiBay2OIBMKWvcMmxVCFUPglGzC63qJtEO9s2S977C/hUPZzWWyFw6mvKPiM h6BQR81R5clS5q6umwxja0VXEDiG6h0fYDvq/tOzonUkcf0uJY8gCo+SJO2J8oZyRK9W 0qMG/ZFBv01dlE9X5ljYHSwbowIbCsx8AwMpZjlPzarSaUPwXsOrYZnxDHYMNQe37G1W XTDspmwxgcmVfeHsIQqognbI1wzRBq1b1CtITpXcigBR070tLf47wVHXOYLY2h0MIk/y crPxwcEhjdo0kgKIfjtgYjXvFjcnTu2JkZd6+eHe4WWJxk93PC4+MweB4AmbhZTLps+C WviA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778833785; x=1779438585; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UllOcT04Arph9Lb63WObBizd6O2TUa0jc9E2byhLXl4=; b=oKcNK93NZJqk5vc8YPWuyO8CU/I4zUBRzH8ZhiblwvQITZhuVH+a9HOupVIqGfOjPI o8It45TTgtZ7DqbOxNlvgcyhp4FpWXs56jRPDUCH91F1LV9JnVT3skmYIdC7+qpoh/kx vMvl8QOm1Ot5c1XuLsxTjhnCXZiZPiu6Qd6MZAFSdxKtzvmErAx1MJO5qPAxRZQ/3yuP ojmRIFdRz6SVuLf7Wse52yAxSVg6IzaYbHjBFb3KNCowE0jhLsiCSE/3BzxikC1EMjFr 0ptRJWOhjW6NZvYGtUiDh7ZeebIA7ORmLW7f/AhX7Cemm6yretWsYMFeSYg3ZO7BvFVl 9uaw== X-Forwarded-Encrypted: i=1; AFNElJ8f9Vk1ygXvmomg5WJDWOuasOfQJG/EZfxT0iT4i/l0J+K54LwHQFblePxNN6K4M0vlXgab/sMKamomoPc=@vger.kernel.org X-Gm-Message-State: AOJu0YxHjvdVXS4b6mNgqk6GX7ZhRBg2DjtfQIB+zxLUmB4xF107RdC7 YcNt7Eem/yi7EoGp8DZYEV3ALb4+sqjqNRfWou74UOMqtlBD4B6Uhk/xoGA4ft7RYo+xfw6Go3R iPOM4fl5kYIoWuE+gapZyxNzRDnA7zrhB29K2x3NCAhdwmMr+j8vhpV1moatup08ooCFGop4oFf o= X-Gm-Gg: Acq92OGtHCU4GJHN3GSpyGgajbkGWosO5KgwXuZn44z8p9JSDyBre+HIiPU/Q2dVMl4 3ROyPX2k4JvIWwvT0q2wbOOdJU8l4RHNQ4wsmbmdttJGGVfar2Tnd80X/+C/UUt8qqXntRYWLSR ZHyBPX921xuSncSOjgcCQ7cx/psXpptoc0e/slXgu56iH5OOEC3z2A86KT2NeiKWEV4tdnjKk4F B9cK8dVHyUduJioZRzXcNi3Jj452J3B3N5BlnSqQkPFxE1pNX19RoqU4IACkUd6KvuxnSaZLBq4 XD4hyxod5rCR4nXpYX9wFWpBCApM6JULKrA1CUSo9mOnJe+Gzgkr7NanNZnP59moCB2NRMXydgb jCw71JRjGDkzULlkL0Vg/MvKq/m2CCJh4fujdhwC88lo25PSsxu1h5+w7z4Y= X-Received: by 2002:a05:622a:a6d2:b0:50d:9f3e:e1a with SMTP id d75a77b69052e-5164155af1emr72149141cf.9.1778833785318; Fri, 15 May 2026 01:29:45 -0700 (PDT) X-Received: by 2002:a05:622a:a6d2:b0:50d:9f3e:e1a with SMTP id d75a77b69052e-5164155af1emr72148901cf.9.1778833784838; Fri, 15 May 2026 01:29:44 -0700 (PDT) Received: from [192.168.68.112] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-48fe53ab671sm43751045e9.1.2026.05.15.01.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 01:29:44 -0700 (PDT) Message-ID: Date: Fri, 15 May 2026 08:29:43 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] arm64: dts: qcom: agatti: add LPASS devices To: Konrad Dybcio , lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, sboyd@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, r.mereu@arduino.cc, srini@kenrel.org References: <20260223133950.221234-1-srinivas.kandagatla@oss.qualcomm.com> <20260223133950.221234-4-srinivas.kandagatla@oss.qualcomm.com> <07cb095b-7765-4810-a8e3-db2bd9ba6276@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <07cb095b-7765-4810-a8e3-db2bd9ba6276@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA4NCBTYWx0ZWRfX2aBmjdMx12Kq cCOPAY07jIN6+gASXoQw641T8jpYrnttu6In/vJN2TytUVHTUNAiWVU0DKrntk8Ud3UyzfgmpEN VDaG+h1Hm9Hj6nSjQzkGuuXKKaKPzghwVy+eJON475CJi3FBNYZa+Wt/Qngc/8dIzlxuiB7v7Vv vsIAvWBX/afUCm327bYT4GYCEu/7wJXhdpRXXRn5xwxHqR683ivCSHl7zpjQ7CXS1WBGLAEVF3S zBw1uAAL0kQNKB+FJCweLGmN2A7bOl8FDUt0QyzvtFJnj8vuuLgnOFg6Af0hqxEWJjacOkO+9WE bvVwGTGBeiWZUzP7iNkhNn2Kv8sl2szco0GT6SvgsM+Cuyt4cf7ZTUh64SBOrGj6TI+KUKg7t1x TbFKUWDahB8HUrPS9Jsd2hIK4mF/DP4QOdFljTtuI61Qx0NBRo00oEuVoR20ZUwIMktCzft3Mfb qYICCwGlkHRm+G67uAw== X-Proofpoint-GUID: TURB33UBDdEvrAGXqRcvY6D1t-VBYqmG X-Proofpoint-ORIG-GUID: TURB33UBDdEvrAGXqRcvY6D1t-VBYqmG X-Authority-Analysis: v=2.4 cv=BvqtB4X5 c=1 sm=1 tr=0 ts=6a06d979 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=APSRQGo-bA5DRRouejwA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150084 On 2/24/26 12:28 PM, Konrad Dybcio wrote: > On 2/23/26 2:39 PM, Srinivas Kandagatla wrote: >> From: Alexey Klimov >> >> The rxmacro, txmacro, vamacro, soundwire nodes, lpass clock >> controllers are required to support audio playback and >> audio capture on sm6115 and its derivatives. >> >> Signed-off-by: Alexey Klimov >> Signed-off-by: Srinivas Kandagatla >> --- > > [...] > >> + lpass_audiocc: clock-controller@a6a9000 { >> + compatible = "qcom,sm6115-lpassaudiocc"; >> + reg = <0x0 0x0a6a9000 0x0 0x1000>; >> + #reset-cells = <1>; >> + }; > > This should be called "qcom,sm6115-lpass-audio-csr" and should probably > have a syscon fallback as there's a lot of various magic tunables in > there, in addition to the CGCR bits. The clock driver can continue to > bind to this new compatible, like we do with the SoC-side TCSR on e.g. > 8550 and the tcsrcc-sm8550 driver. Are you expecting this to be a reset-controller interface or just syscon so that drivers can poke into this register space. The reason to take the full address space here and represent the HW control bits as reset controller is that we have room for adding these various magic tunables with some standard interface when required in this driver. I could have done the way as you suggested with syscon and let the drivers poke the whatever values it want, but that is not scalable and clutters the interfaces and encourage to use the way it was done in downstream. This is same for all the Qualcomm SoCs, why sm6115 has to do this change alone? And its going to break the Device tree abi. Sorry but I can not do the changes that you suggested here. I would suggest that we use the existing mechanism which is more future proof. Please suggest otherwise, I would like to move on with enabling audio on UNO Q platform. --srini > > [...] > >> + lpasscc: clock-controller@a7ec000 { >> + compatible = "qcom,sm6115-lpasscc"; >> + reg = <0x0 0x0a7e0000 0x0 0x12000>; >> + #reset-cells = <1>; >> + }; > > All the same, except "qcom,sm6115-lpass-tcsr" > > I'm once again sorry for not getting this right n years ago, but I did not > have the sufficient documentation back then > > Konrad