From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5609C3DA66 for ; Fri, 25 Aug 2023 05:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238637AbjHYFlP (ORCPT ); Fri, 25 Aug 2023 01:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238506AbjHYFlN (ORCPT ); Fri, 25 Aug 2023 01:41:13 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C8781BDA; Thu, 24 Aug 2023 22:41:10 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RX7xs1CdpztSMB; Fri, 25 Aug 2023 13:37:21 +0800 (CST) Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 25 Aug 2023 13:41:06 +0800 Subject: Re: [PATCH v6 1/7] perf evlist: Add perf_evlist__go_system_wide() helper To: Ian Rogers , Adrian Hunter CC: , , , , , , , , , , , , , References: <20230821012734.18241-1-yangjihong1@huawei.com> <20230821012734.18241-2-yangjihong1@huawei.com> From: Yang Jihong Message-ID: Date: Fri, 25 Aug 2023 13:41:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2023/8/25 12:51, Ian Rogers wrote: > On Sun, Aug 20, 2023 at 6:30 PM Yang Jihong wrote: >> >> For dummy events that keep tracking, we may need to modify its cpu_maps. >> For example, change the cpu_maps to record sideband events for all CPUS. >> Add perf_evlist__go_system_wide() helper to support this scenario. >> >> Signed-off-by: Yang Jihong >> Acked-by: Adrian Hunter >> --- >> tools/lib/perf/evlist.c | 9 +++++++++ >> tools/lib/perf/include/internal/evlist.h | 2 ++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c >> index b8b066d0dc5e..3acbbccc1901 100644 >> --- a/tools/lib/perf/evlist.c >> +++ b/tools/lib/perf/evlist.c >> @@ -738,3 +738,12 @@ int perf_evlist__nr_groups(struct perf_evlist *evlist) >> } >> return nr_groups; >> } >> + >> +void perf_evlist__go_system_wide(struct perf_evlist *evlist, struct perf_evsel *evsel) >> +{ >> + if (!evsel->system_wide) { >> + evsel->system_wide = true; >> + if (evlist->needs_map_propagation) >> + __perf_evlist__propagate_maps(evlist, evsel); >> + } >> +} > > I think this should be: > > void evsel__set_system_wide(struct evsel *evsel) > { > if (evsel->system_wide) > return; > evsel->system_wide = true; > if (evsel->evlist->core.needs_map_propagation) > ... > > The API being on evlist makes it look like all evsels are affected. > This part of the code is implemented according to Adrian's suggestion. Refer to: https://lore.kernel.org/linux-perf-users/206972a3-d44d-1c75-3fbc-426427614543@intel.com/ The logic of both is the same, and either is OK for me. If really want to change it, please let me know. Thanks, Yang