From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 015FB4D8D91; Wed, 3 Jun 2026 22:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780526023; cv=none; b=YsDra37IIct9MgNTGukn6MvDrANIToNF8FR820XUhkmdW14p/Komoe5V6oCjfVa5yOFmYSz9CtX3PWS5N7O7uQl5vXyvsLFfRmz899VepCTNRxfWePy+3p8HvWpy/ia+u/GiJrf7v05nDKRz0eaZpUWLvgxHEMDU3yQcMAc93lE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780526023; c=relaxed/simple; bh=lq9rb8PQRol3H/21t01viHr+r3b/JLoK/P8J0muQN9E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ni2zviU4fxOAOSvtmyvz4/cANF/4tsyq4vAAgtow98CBkrl6q0+zK95AN15si87rctBA6W3RAdrLz6tC0+hjI37XWAeRaFV7Xe9r83OTDLd7T4xmS6HTLPw1sa+fSTxQpmn3uNAQme44SQC3A9YCbH0FazphdsOoYX8gMhL2F3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MTWx7lia; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MTWx7lia" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780526022; x=1812062022; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lq9rb8PQRol3H/21t01viHr+r3b/JLoK/P8J0muQN9E=; b=MTWx7liaqRimDyq/yrkBILED+rVmP8F5YsEyymF2rQtlCaCqNxA7euUY sH/X7S+DnhFZxIsd3029J3f3ssllEvHXEuK/6lBsDm1QbLRCv7pghY7Oc UuTnnGRWi8GO6sZZ1blOHOpcmI12TtRyy7U4RTgugnJaOAzl1Q6/OQED3 DvN4c0KcqNcRuHKLKFH+fEuRDZygzr9LbhSiZlq3klh4642dLgmu5NBwI zfaHxgB/qp4y8RSxzXIa/tePIQNlUkBv6Dypgjp6E25vhzRNivZQxKc1+ NmShumSJbuJeCL8gkc7RrBenEoA5htz19/umAryJoJbsYUbspe6YjiO27 g==; X-CSE-ConnectionGUID: EbpjLe5FTWuw5Or9FARfFg== X-CSE-MsgGUID: k+erKbGPSIW1xO5tdrfB7w== X-IronPort-AV: E=McAfee;i="6800,10657,11806"; a="81475583" X-IronPort-AV: E=Sophos;i="6.24,186,1774335600"; d="scan'208";a="81475583" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 15:33:41 -0700 X-CSE-ConnectionGUID: ZZryN3C3R3Kl8hb6uutvqw== X-CSE-MsgGUID: eOEXuPvqQDyqTfI5qOtdYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,186,1774335600"; d="scan'208";a="244217143" Received: from dnelso2-mobl.amr.corp.intel.com (HELO [10.125.108.116]) ([10.125.108.116]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 15:33:40 -0700 Message-ID: Date: Wed, 3 Jun 2026 15:33:39 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] ACPI: NFIT: core: Fix possible NULL pointer dereference To: "Rafael J. Wysocki" , Linux ACPI Cc: Dan Williams , LKML , Vishal Verma , nvdimm@lists.linux.dev, Alison Schofield , Xiang Chen References: <5110904.31r3eYUQgx@rafael.j.wysocki> <2418508.ElGaqSPkdT@rafael.j.wysocki> Content-Language: en-US From: Dave Jiang In-Reply-To: <2418508.ElGaqSPkdT@rafael.j.wysocki> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/3/26 10:56 AM, Rafael J. Wysocki wrote: > From: "Rafael J. Wysocki" > > After commit 9b311b7313d6 ("ACPI: NFIT: Install Notify() handler before > getting NFIT table"), acpi_nfit_probe() installs an ACPI notify handler > for the NFIT device before checking the presence of the NFIT table. If > that table is not there, 0 is returned without allocating the acpi_desc > object and setting the driver data pointer of the NFIT device. If the > platform firmware triggers an NFIT_NOTIFY_UC_MEMORY_ERROR notification > on the NFIT device at that point, acpi_nfit_uc_error_notify() will > dereference a NULL pointer. > > Prevent that from occurring by adding an acpi_desc check against NULL > to acpi_nfit_uc_error_notify(). > > Fixes: 9b311b7313d6 ("ACPI: NFIT: Install Notify() handler before getting NFIT table") > Signed-off-by: Rafael J. Wysocki > Cc: All applicable Reviewed-by: Dave Jiang > --- > drivers/acpi/nfit/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 5cab62f618c8..8024cd3cad14 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -3442,6 +3442,9 @@ static void acpi_nfit_uc_error_notify(struct device *dev, acpi_handle handle) > { > struct acpi_nfit_desc *acpi_desc = dev_get_drvdata(dev); > > + if (!acpi_desc) > + return; > + > if (acpi_desc->scrub_mode == HW_ERROR_SCRUB_ON) > acpi_nfit_ars_rescan(acpi_desc, ARS_REQ_LONG); > else