From: Joe Perches <joe@perches.com>
To: Steffen Vogel <post@steffenvogel.de>, linux-kernel@vger.kernel.org
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Subject: Re: [PATCH 2/9] w1: improve coding style by following strict 80 column line limit
Date: Sun, 28 Oct 2018 16:03:25 -0700 [thread overview]
Message-ID: <db30f8d56061f5cfec82e75e986149ac76f1ef11.camel@perches.com> (raw)
In-Reply-To: <20181028220927.56227-3-post@steffenvogel.de>
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote:
> This satisfies a checkpatch warning
Perhaps run your patches through checkpatch with --strict
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
[]
> @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev)
> sl->master->slave_count--;
> }
>
> -static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf)
> +static ssize_t name_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
atypical alignment.
> []
> @@ -170,7 +173,9 @@ static void w1_netlink_queue_status(struct w1_cb_block *block,
> block->msg->len = 0;
> block->msg->status = (u8)-error;
> if (req_cmd) {
> - struct w1_netlink_cmd *cmd = (struct w1_netlink_cmd *)block->msg->data;
> + struct w1_netlink_cmd *cmd =
> + (struct w1_netlink_cmd *) block->msg->data;
unnecessary space after cast
next prev parent reply other threads:[~2018-10-28 23:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 22:09 w1: coding style and checkpatch fixes Steffen Vogel
2018-10-28 22:09 ` [PATCH 1/9] w1: add SPDX identifiers Steffen Vogel
2018-10-28 22:09 ` [PATCH 2/9] w1: improve coding style by following strict 80 column line limit Steffen Vogel
2018-10-28 23:03 ` Joe Perches [this message]
2018-10-28 22:09 ` [PATCH 3/9] w1: add newlines after declarations Steffen Vogel
2018-10-28 22:09 ` [PATCH 4/9] w1: cleanup whitespaces according to coding style document Steffen Vogel
2018-10-28 22:09 ` [PATCH 5/9] w1: use octal numbers instead of macros for file mode Steffen Vogel
2018-10-29 13:46 ` Sebastian Reichel
2018-10-28 22:09 ` [PATCH 6/9] w1: do not log errors about failed memory allocations Steffen Vogel
2018-10-28 22:09 ` [PATCH 7/9] w1: use __func__ for logging the function name Steffen Vogel
2018-10-28 22:09 ` [PATCH 8/9] w1: fix whitespaces of struct declarations Steffen Vogel
2018-10-29 1:52 ` Joe Perches
2018-10-29 2:02 ` Steffen Vogel
2018-10-29 2:04 ` Joe Perches
2018-10-28 22:09 ` [PATCH 9/9] w1: using linux instead of asm prefix for includes Steffen Vogel
2018-10-28 22:53 ` w1: coding style and checkpatch fixes Linus Torvalds
2018-10-29 0:29 ` Steffen Vogel
2018-10-29 1:31 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db30f8d56061f5cfec82e75e986149ac76f1ef11.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=post@steffenvogel.de \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®