From: Marek Vasut <marex@nabladev.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>, linux-usb@vger.kernel.org
Cc: stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
kernel@dh-electronics.com, linux-kernel@vger.kernel.org,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH] usb: typec: mux: Fix typec_switch_match()
Date: Tue, 18 Aug 2026 10:58:48 +0200 [thread overview]
Message-ID: <db311b41-ce2c-4018-aba2-8ebb7e9f1b31@nabladev.com> (raw)
In-Reply-To: <2719a7f9-71cf-447b-b4fa-a53e598d3d5a@leemhuis.info>
On 8/18/26 10:32 AM, Thorsten Leemhuis wrote:
> On 8/17/26 20:22, Marek Vasut wrote:
>> The fwnode_typec_switch_get() sporadically returns NULL instead of an
>> -EPROBE_DEFER for orientation-switch described in DT.
>
> Hi Marek! Just to make sure, have you seen the patch submission
> "usb: typec: mux: initialize orientation switch array"?
> https://lore.kernel.org/all/20260804083434.20885-1-i@4t.pw/
>
> It has a fixes tag for the commit you mention and reads: ""Commit
> a53b4f9c51a9 ("usb: typec: mux: avoid duplicated orientation switches")
> started using the orientation switch result array as state for duplicate
> detection, but left the array uninitialized.
>
> The first match therefore scans indeterminate stack contents before any
> result has been stored. [...]""
That seems like a different issue -- even if the sw_devs[] array is
NULL-initialized, if to_typec_switch_dev() returns NULL, then the
comparison between to_typec_switch_dev() and sw_devs[] would still be
true and the match callback would return NULL instead of EPROBE_DEFER.
next prev parent reply other threads:[~2026-08-18 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 18:22 Marek Vasut
2026-08-18 8:32 ` Thorsten Leemhuis
2026-08-18 8:58 ` Marek Vasut [this message]
2026-08-18 16:24 ` Sebastian Reichel
2026-08-18 16:56 ` Marek Vasut
2026-08-18 17:05 ` Jens Glathe
2026-08-18 17:43 ` Marek Vasut
2026-08-18 17:01 ` Jens Glathe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db311b41-ce2c-4018-aba2-8ebb7e9f1b31@nabladev.com \
--to=marex@nabladev.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=kernel@dh-electronics.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sebastian.reichel@collabora.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®