From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757439AbcJYLQF (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Oct 2016 07:16:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53536 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751905AbcJYLQE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Oct 2016 07:16:04 -0400
Subject: Re: [PATCH v3] x86/msr: Add write msr notrace to avoid the debug
 codes splash
To: Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org
References: <1477364285-14756-1-git-send-email-wanpeng.li@hotmail.com>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>, Ingo Molnar <mingo@kernel.org>,
        Mike Galbraith <efault@gmx.de>, Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <db33df3d-93e6-acca-7957-1f05a3a401bb@redhat.com>
Date: Tue, 25 Oct 2016 13:15:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1477364285-14756-1-git-send-email-wanpeng.li@hotmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 25 Oct 2016 11:16:04 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 25/10/2016 04:58, Wanpeng Li wrote:
> @@ -319,7 +319,7 @@ static void kvm_guest_apic_eoi_write(u32 reg, u32 val)

This needs to be notrace too.

Paolo

>  	 */
>  	if (__test_and_clear_bit(KVM_PV_EOI_BIT, this_cpu_ptr(&kvm_apic_eoi)))
>  		return;
> -	apic_write(APIC_EOI, APIC_EOI_ACK);
> +	apic->native_eoi_write(APIC_EOI, APIC_EOI_ACK);
>  }
>