From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 772AB426D03 for ; Mon, 17 Aug 2026 15:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786982357; cv=none; b=ueWMQxsCrqseKYvhbBE3kPM1gJFYxQ7Lmg4HNQQiYSPg/bz85OOvPjxBDa6PJ5S2uR9NnN09nby5CNeELxY08PxZWvddvZwZDn7MiUp4ZY/sqzM16rjVgtXecUwC8KLatrEkPPwGOOxXxyt5EAeydbZEh8pWsZzCnpYD7m0kFmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786982357; c=relaxed/simple; bh=aaH9lbVuJj0q9BWXv+5Hkwn1QmGhneskXi8mbAoYU5w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PrrextmEDlkPjBs9uqyB+9SpFRJ6588VLGu/1Nx1RVU8DGNOqdCm+J38vUwt0DSafvCf71WSsF4nLgvf4xk01Khod8ojeQv4Rc7/zs8hQfhLvhMQuqETvkHsyG5uc1dkZE54z1nfdEHYCti5giZDTFAQIH/WNvh/SQmzq+tJgss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IrcC47oC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RtJc7pAo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IrcC47oC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RtJc7pAo" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HFYh952263478 for ; Mon, 17 Aug 2026 15:59:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ACldy0aiVSHL8k6IBZhXMiInAvqs3SiE9+icRfANvIU=; b=IrcC47oCgczwrEfb ooUgjXIwljq4P96rWO2Noz1JZFvdyV1g5px+AImCT9D0glgVslNnjj3KAl7eBeoH RCEWKameg6JQF+lUJE/31LASyusw9zGQOcAH4o1JM4BmWu0pSM8XOajJpu0KnvZ3 VJa/jjzjWUBBinjWXOevcpau47jXXHQh35AyMMJPWANFnGOkezLRIgKBX+1qm6h5 7V6vsNHbS5W8fInJ7oM9kAWZQ4ilQF9wd4N6ZZNcrj6I5CS2d+oWq+9YAJ32PCxH +nTxibx6e8geu8a+tVK68JzQYpmHlF6AK+hTZshyQUnDa6aRGwKIF5a4i5yZxfIY iWDezw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3xx7hqxn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 15:59:15 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51e9d892f0dso10473101cf.2 for ; Mon, 17 Aug 2026 08:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786982354; x=1787587154; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ACldy0aiVSHL8k6IBZhXMiInAvqs3SiE9+icRfANvIU=; b=RtJc7pAok8/kblbs2+zKYDshMELhhdXS+lUDe16yI/VItG5N1/bcAE4aHvBtrenjVE LoiStEnnnf1qITin/HpBiO3B830ccgUa410qRyuGCza2l8+Nbqn/QLFbcP7oNdbz2k2Y 6VOs+5nXQjl6ce/oLry/e9csQm232DZPpxw4XKrka2rqxPLYSpMi53ywinaFBUdg9jjS txm1MxQG8JKBaXSINrgz13RGm82gDN8PIwm3lXegsVNxQ14bHVkJB7WF4Uzc9WRkINPF 1SBckfsLZipaLUzrckGcJdh+NdEbmkeJWLuuSYpl4nb55f/f/PdbmA7AE9SdgjDKt7WN x5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786982354; x=1787587154; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ACldy0aiVSHL8k6IBZhXMiInAvqs3SiE9+icRfANvIU=; b=nQNZLOW1P3RJLRUl1cgh9U5RGqTuTr7ba8uaJSod4YUbZlCwII0i73PGpQUacxpShU dtit7eqdYdUQcocD7ilphNTNfPghhCJfgwrwuyRVS2B6KG61y7yy4xiAGgvtm3yaxKw+ cAzhN/r/eOpVHpI/jp3uHw/+XSOH7WBmYgLdO2sjMU4ux/VX+k77UeNTpz9M96YNo4wp ICHI9mDw+VGKUYzXCFU5eOO7dGOUdSNyxx/ByP/2D1ND0vwCOQvqD1pqhoUHLMbeKXSU r6HlN6Ojk7prhbZPvgcx/ofNbIbRiiFTXvQtTrfsi3QR38ydh7zo8pfSD//qSJxy/6at ZSaQ== X-Forwarded-Encrypted: i=1; AHgh+RrExB4kT32RtQ8EWW9nO0jDakob732osTtWOgumx6ZiTyVkTkZ/w4/3ZG734c2zv9wXdgW0c0LJ89grVZE=@vger.kernel.org X-Gm-Message-State: AOJu0YwtG27wkYzn2XGvKTkjxG2UAXfXx+IqwZNfEuQkrJG1ThWzBg/W bV7PsMQFvgPgUXrB+fnPrjwtOz6JfzOZO34DUnM6f7tWLC13GiuPjDYVEsbYWFOBR8TBv4u4eeO DC88MoX2r9iLJfDUXOFetW+Cn7QcAPWvPqNodu7a7qJjqPiLDO6lGBEQRJryFiBEaBBMmN2HnPs 8= X-Gm-Gg: AR+sD12rcrioBQ6YkTcxkrfZv3+KLZtSCidQDvEjN3PPAAluvOZJjyL9gxqEqaEtszg 4BE0cTTxd/BOZOtvPv8O5fzJ+sgWtVDJpXcjHhLuSCn+KW1DJBW9CbhbJY9RMK9uLLA56iAfLZ1 pvrZAXqnBSdy2y5mAVRxRGPOYKfNtdTIuhdxIGeytes/i9tUlNZvTee3z8P8STeCRb99mGsIbOO Jfk/V3emxkue2UKicrkBT+QNdx5uWiXPjUpjWWvHI5ECcEeOMnFt3ioqqvuoQPZMV0nq7k27Ig8 uecxk7xEFSKX1qSNgjtCByY1zyHBTmhNIWlt0I2nFsSn3rLm1cbRedz/QB2crncxntYIwivGbqy jXFNK7eJsv+dK+w0Z5dqeMGyV X-Received: by 2002:ac8:5fd1:0:b0:51b:f40b:2fa2 with SMTP id d75a77b69052e-52d852d4f3dmr190512651cf.1.1786982354404; Mon, 17 Aug 2026 08:59:14 -0700 (PDT) X-Received: by 2002:ac8:5fd1:0:b0:51b:f40b:2fa2 with SMTP id d75a77b69052e-52d852d4f3dmr190512041cf.1.1786982353825; Mon, 17 Aug 2026 08:59:13 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185b74059sm45883166b.38.2026.08.17.08.59.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 08:59:13 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 17:59:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] arm64: dts: qcom: Add Motorola One To: Adam Skladowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260810-next-patches-v1-0-79a779d76173@gmail.com> <20260810-next-patches-v1-3-79a779d76173@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260810-next-patches-v1-3-79a779d76173@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDEyMiBTYWx0ZWRfXyD5YPuAw3doX zOFe6PogG0TR0YjSSY2AJpSwgDqKsp2HKBgbgOGkLulIZwRihlgzvY8WaEWAwF7uVHtG/yaHpqb GHrDuRdj/Q+iTtPrGKfuRUXg+X7STCI= X-Authority-Analysis: v=2.4 cv=TK91jVla c=1 sm=1 tr=0 ts=6a832fd3 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=kDiaLF9t6-FkB4tI0JsA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: YB6tLox2Rb-JNGD4IpHIQK7rwR5V7k1z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDEyMiBTYWx0ZWRfX+8KeMTOfUr1b MnycSIs6k+9F8fy2215prIjMw0C3CxsHR0DqaC9s3su0Icbwz7vpbZCYFRRBowgaujCIkLpW/Pm O4IT1/mKVjq+8K5xgtHWUpdbHJs8XqCqIeu8YWbzmQnTqNc67lF+LHvdxwFemJ//tfjeS/hNavi sTPt7cPZmat5v7dlmlAVlHEsC7Ys089aC+jxaYvT9YKzn8uoW3WhMkb3fe+HiYvG3zByzCRjzav l4BAqA1+wc1RIxNr4HhcgwXR7SeBE8xgaNoc55dAeOnq/wEJzFg5OXJ54FfB+j6D0WdopwCf4/4 w02WKD/C9iOgrXSywCatx0JJQlC83Ju/xYk6F6CtRaRGAsQ+E1GRcs/gf1AJ6fa5GS5UYdl1DpG h66+I29x+YPF5xn4chqwkQRFJyxD3XRJXJ1hweo3S9kbE0CWnwZBKT9d1IztuHlCRo//LpmA9h7 kleQ6Ht/d2Fm6c9SxvA== X-Proofpoint-ORIG-GUID: YB6tLox2Rb-JNGD4IpHIQK7rwR5V7k1z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_02,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170122 On 8/10/26 6:55 PM, Adam Skladowski wrote: > Add a devicetree for the Motorola One smartphone, which is based > on the Jacala/MSM8953 SoC. [...] > +&i2c_1 { > + status = "disabled"; > + > + typec-portc@22 { > + compatible = "fcs,fusb302"; > + reg = <0x22>; > + interrupts-extended = <&tlmm 9 IRQ_TYPE_EDGE_RISING>; > + > + status = "disabled"; Why are the bus and this chip disabled? [...] > +&tlmm { > + gpio-reserved-ranges = <96 4>, <111 1>, <126 1>; Preferably one a line with a best-effort set of comments describing what these pins correspond to (see glymur-crd.dtsi) > + > + disp_reset_n_active: disp-reset-n-active-state { > + pins = "gpio61"; > + function = "gpio"; > + drive-strength = <8>; > + bias-disable; > + output-high; Drop output-foo from TLMM pins, the consumer driver should set the output state via the GPIO APIs Konrad