From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C741C433F5 for ; Fri, 18 Feb 2022 17:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238461AbiBRRXs (ORCPT ); Fri, 18 Feb 2022 12:23:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238455AbiBRRXq (ORCPT ); Fri, 18 Feb 2022 12:23:46 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 897C912342A for ; Fri, 18 Feb 2022 09:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645205008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wLmxSPunZdkKjVW0sxyYdXHyDxLpVVtwITCTa0ESLxY=; b=VWcHXHkeQ5XwyCp/mxDus7JZW1eqnhMm91nP9Gpv9MJc9lVz60iqf4Ikz5nCwzp6j6AMio Lf7XGDwERsDYARdZf7IXDkga+PRiFlNGFbnHElH6nodDoitP7grThMbnZHKdsaNfeEH3cq vHicfg3WXjfG/iyDqlhzuAd+SITbK0Q= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-dIwtGsc6PECMwDyUbJy7eA-1; Fri, 18 Feb 2022 12:23:27 -0500 X-MC-Unique: dIwtGsc6PECMwDyUbJy7eA-1 Received: by mail-ej1-f69.google.com with SMTP id q3-20020a17090676c300b006a9453c33b0so3324817ejn.13 for ; Fri, 18 Feb 2022 09:23:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wLmxSPunZdkKjVW0sxyYdXHyDxLpVVtwITCTa0ESLxY=; b=sKGyqqqyvgjzqmgZeh7YeG3eDVrvMynnaU3QVgYixaGJyrjKBsedGqgjvF4vTSZcmd beyCYyItIfn4QNJqTUiFHE8qooBaoM3qgpLfO23BgKXv2FWlCIj/MSYFpTpMUq2BX0u2 bXcvp3Vm9wcO6HTA+ckzo/xMI7NNLXixrOBxeQSICcbKvPBoBoKpwiMYJ0Ihb2iziILt x4moKc+Wm9XJmSfKsd7Gmz1tyrm1z4e9MSboQnwZucXfg2NhzxPPzmmGV/fap6Y1iWE1 45ROz3SFLFOfxOnxympxZniBkxBFSDpFRmG1iqVT3Cma4jPX1Xgd9TAGRT5trNkp595q Xv2A== X-Gm-Message-State: AOAM533dc0Q6pCPWVjWfJPwyrnoK3KpQuJj145rXLjPpDy76Ijn8CYYg WP0R7z5Jcon99+WlxVNOo5pU6BTeYC7WYiwMvlSl+xsSgpepG8/HTW6cJHWp2bse6oc6otYKMpI rvP3YYyExBBpLlJrqG7HFK/G8 X-Received: by 2002:a05:6402:2744:b0:404:ba60:fec6 with SMTP id z4-20020a056402274400b00404ba60fec6mr9180010edd.235.1645205005949; Fri, 18 Feb 2022 09:23:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdIaWlXASY65HPZXhodkvuJC5wJqCuuyoymnUNW/je7psQin+hEy5z4WOcHvtLjzv6WrXDMQ== X-Received: by 2002:a05:6402:2744:b0:404:ba60:fec6 with SMTP id z4-20020a056402274400b00404ba60fec6mr9179996edd.235.1645205005723; Fri, 18 Feb 2022 09:23:25 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id b19sm1466874edd.91.2022.02.18.09.23.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Feb 2022 09:23:25 -0800 (PST) Message-ID: Date: Fri, 18 Feb 2022 18:23:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 03/18] KVM: x86/mmu: WARN if PAE roots linger after kvm_mmu_unload Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20220217210340.312449-1-pbonzini@redhat.com> <20220217210340.312449-4-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/22 18:14, Sean Christopherson wrote: > Checkpatch doesn't like it, and IMO the existing asserts > are unnecessary. I agree that removing the assertions could be another way to go. A third and better one could be to just wait until pae_root is gone. I have started looking at it but I would like your opinion on one detail; see question I posted at https://lore.kernel.org/kvm/7ccb16e5-579e-b3d9-cedc-305152ef9b8f@redhat.com/. For now I'll drop this patch. Paolo