mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: YueHaibing <yuehaibing@huawei.com>,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()
Date: Wed, 23 Sep 2020 12:21:56 +0200	[thread overview]
Message-ID: <db50f472-eb61-2f45-191a-94e8f53e7dd4@arm.com> (raw)
In-Reply-To: <20200922132410.48440-1-yuehaibing@huawei.com>

On 22/09/2020 15:24, YueHaibing wrote:
> There is no caller in tree, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  kernel/sched/core.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
>  	return clamp_value / UCLAMP_BUCKET_DELTA;
>  }
>  
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> -	return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
>  static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
>  {
>  	if (clamp_id == UCLAMP_MIN)
> 

LGTM.

It got introduced in commit 60daf9c194106 ("sched/uclamp: Add bucket
local max tracking") but was never used.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

  reply	other threads:[~2020-09-23 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 13:24 YueHaibing
2020-09-23 10:21 ` Dietmar Eggemann [this message]
2020-09-25 14:12 ` Vincent Guittot
2020-09-29  7:56 ` [tip: sched/core] " tip-bot2 for YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db50f472-eb61-2f45-191a-94e8f53e7dd4@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=bsegall@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®