From: "Du, Bin" <bin.du@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Sultan Alsawaf <sultan@kerneltoast.com>
Cc: mchehab@kernel.org, hverkuil@xs4all.nl,
laurent.pinchart+renesas@ideasonboard.com,
bryan.odonoghue@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
pratap.nirujogi@amd.com, benjamin.chan@amd.com, king.li@amd.com,
gjorgji.rosikopulos@amd.com, Phil.Jawich@amd.com,
Dominic.Antony@amd.com, richard.gong@amd.com, anson.tsao@amd.com,
Alexey Zagorodnikov <xglooom@gmail.com>
Subject: Re: [PATCH v7 4/7] media: platform: amd: isp4 subdev and firmware loading handling added
Date: Thu, 15 Jan 2026 13:56:33 +0800 [thread overview]
Message-ID: <db6d11e2-0131-44a5-858f-e255923b9d5e@amd.com> (raw)
In-Reply-To: <bc665c1d-f2a6-495a-bda8-012b2619f0c4@amd.com>
On 1/15/2026 5:08 AM, Mario Limonciello wrote:
>>>
>>> Unless the firmware API structs are all __packed in a future firmware
>>> update, I
>>> think the memsets should remain.
>>
>> If you want to be certain of the size of the structs, use BUILD_BUG_ON().
>>
>
> static_assert is another option here too. I did something like that in
> drivers/acpi/platform_profile.c to make sure that a structure got
> updated from new members.
Thank you, Sakari and Mario, for your informative sharing.
--
Regards,
Bin
next prev parent reply other threads:[~2026-01-15 5:56 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 9:13 [PATCH v7 0/7] Add AMD ISP4 driver Bin Du
2025-12-16 9:13 ` [PATCH v7 1/7] media: platform: amd: Introduce amd isp4 capture driver Bin Du
2025-12-22 9:23 ` Sakari Ailus
2026-01-06 8:30 ` Du, Bin
2025-12-16 9:13 ` [PATCH v7 2/7] media: platform: amd: low level support for isp4 firmware Bin Du
2025-12-16 9:13 ` [PATCH v7 3/7] media: platform: amd: Add isp4 fw and hw interface Bin Du
2025-12-22 9:37 ` Sakari Ailus
2026-01-07 8:44 ` Du, Bin
2026-01-14 20:55 ` Sakari Ailus
2026-01-15 2:24 ` Du, Bin
2026-01-20 9:22 ` Du, Bin
2026-01-27 8:38 ` Du, Bin
2026-02-02 9:10 ` Sakari Ailus
2026-02-03 6:37 ` Du, Bin
2025-12-16 9:13 ` [PATCH v7 4/7] media: platform: amd: isp4 subdev and firmware loading handling added Bin Du
2025-12-22 10:11 ` Sakari Ailus
2026-01-07 7:33 ` Sultan Alsawaf
2026-01-14 21:03 ` Sakari Ailus
2026-01-14 21:08 ` Mario Limonciello
2026-01-15 5:56 ` Du, Bin [this message]
2026-01-15 7:21 ` Sultan Alsawaf
2026-01-20 9:29 ` Du, Bin
2026-01-27 8:39 ` Du, Bin
2026-01-15 10:36 ` Du, Bin
2026-01-14 10:34 ` Du, Bin
2026-01-14 21:07 ` Sakari Ailus
2026-01-15 7:51 ` Du, Bin
2026-01-14 9:45 ` Markus Elfring
2025-12-16 9:13 ` [PATCH v7 5/7] media: platform: amd: isp4 video node and buffers " Bin Du
2025-12-22 17:07 ` Sakari Ailus
2026-01-09 10:08 ` Du, Bin
2026-01-29 21:17 ` Sakari Ailus
2026-02-03 6:32 ` Du, Bin
2025-12-16 9:13 ` [PATCH v7 6/7] media: platform: amd: isp4 debug fs logging and more descriptive errors Bin Du
2025-12-16 9:13 ` [PATCH v7 7/7] Documentation: add documentation of AMD isp 4 driver Bin Du
2025-12-17 7:36 ` [PATCH v7 0/7] Add AMD ISP4 driver Sultan Alsawaf
2025-12-17 7:47 ` Du, Bin
2025-12-17 10:29 ` Du, Bin
2025-12-17 11:04 ` Sakari Ailus
2025-12-31 9:03 ` Kate Hsuan
2026-01-06 5:49 ` Kate Hsuan
2026-01-06 8:35 ` Du, Bin
2026-01-13 14:11 ` Kate Hsuan
2026-01-13 17:14 ` Nirujogi, Pratap
2026-01-14 8:59 ` Kate Hsuan
2026-01-15 6:47 ` Du, Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db6d11e2-0131-44a5-858f-e255923b9d5e@amd.com \
--to=bin.du@amd.com \
--cc=Dominic.Antony@amd.com \
--cc=Phil.Jawich@amd.com \
--cc=anson.tsao@amd.com \
--cc=benjamin.chan@amd.com \
--cc=bryan.odonoghue@linaro.org \
--cc=gjorgji.rosikopulos@amd.com \
--cc=hverkuil@xs4all.nl \
--cc=king.li@amd.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=pratap.nirujogi@amd.com \
--cc=richard.gong@amd.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sultan@kerneltoast.com \
--cc=xglooom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®