From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout04.his.huawei.com (canpmsgout04.his.huawei.com [113.46.200.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24EE72206AC for ; Wed, 29 Oct 2025 06:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761720021; cv=none; b=gNBj0wQVBQCtvsC0olKKAwEF4GgzFEHH7pUaDyoB3hQGrd+n4x8VJWXfUDDp58gMl00+rZ7rfm7vD8bnfcpC4DqTtST3eB8SWYFDYMTM9jgGPFIVAErMub7rJFbAsBATJUJ6Ne+UKg4pXB9F4WC9gReVu9zPLNagGkeal5zSygI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761720021; c=relaxed/simple; bh=UK3Oazws8lU0QcFGb6Imol0JxiYdY4nsY1S0YRrN4uY=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=qp3QK5iyb6pMP46qFMtJznC9Vu9mQve4WXQ1O7b5EAyHKpvTlxGTRki0hZYBorupmLyOGaZYYreAfmNeTMXFZ4Kwp3YajCWRsDwfjxRyhjfIiE+bgxza//VDOhkFSFHENPSxkZ6l2/quem7MwjBmlyKqnA2fXTlypH+lL3CCWgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=IpMOnKmo; arc=none smtp.client-ip=113.46.200.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="IpMOnKmo" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=R2FdD5J/Lr6BnGwMKRTDIEW2p4Dh3z/n14/cPtSxKg4=; b=IpMOnKmoS6zK+4EVtk8S3WHaTh5AL00RQBseN5kgB2Ev70POZb4Je5zUJWtprvuJpp47OgMEq MOXFez0vV1bPbCJ4ziREV4gK0zcNxU3m1eII/EP21O++DpFU7LSEZsnLYqk6jaxqESBjosdlxTd uSlw04DKUcdrRNDy8XH4TYQ= Received: from mail.maildlp.com (unknown [172.19.162.254]) by canpmsgout04.his.huawei.com (SkyGuard) with ESMTPS id 4cxHfV2CvBz1prQ0; Wed, 29 Oct 2025 14:39:46 +0800 (CST) Received: from dggemv706-chm.china.huawei.com (unknown [10.3.19.33]) by mail.maildlp.com (Postfix) with ESMTPS id 8643D18048D; Wed, 29 Oct 2025 14:40:15 +0800 (CST) Received: from kwepemq500010.china.huawei.com (7.202.194.235) by dggemv706-chm.china.huawei.com (10.3.19.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 29 Oct 2025 14:40:15 +0800 Received: from [10.173.125.37] (10.173.125.37) by kwepemq500010.china.huawei.com (7.202.194.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 29 Oct 2025 14:40:14 +0800 Subject: Re: [PATCH v2 1/1] mm/ksm: recover from memory failure on KSM page by migrating to healthy duplicate To: Long long Xia CC: , , , , , , , , Longlong Xia , , References: <20251016101813.484565-1-xialonglong2025@163.com> <20251016101813.484565-2-xialonglong2025@163.com> <7c069611-21e1-40df-bdb1-a3144c54507e@163.com> From: Miaohe Lin Message-ID: Date: Wed, 29 Oct 2025 14:40:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <7c069611-21e1-40df-bdb1-a3144c54507e@163.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq500010.china.huawei.com (7.202.194.235) On 2025/10/28 15:54, Long long Xia wrote: > Thanks for the reply. > > 在 2025/10/23 19:54, Miaohe Lin 写道: >> On 2025/10/16 18:18, Longlong Xia wrote: >>> From: Longlong Xia >>> >>> When a hardware memory error occurs on a KSM page, the current >>> behavior is to kill all processes mapping that page. This can >>> be overly aggressive when KSM has multiple duplicate pages in >>> a chain where other duplicates are still healthy. >>> >>> This patch introduces a recovery mechanism that attempts to >>> migrate mappings from the failing KSM page to a newly >>> allocated KSM page or another healthy duplicate already >>> present in the same chain, before falling back to the >>> process-killing procedure. >>> >>> The recovery process works as follows: >>> 1. Identify if the failing KSM page belongs to a stable node chain. >>> 2. Locate a healthy duplicate KSM page within the same chain. >>> 3. For each process mapping the failing page: >>>     a. Attempt to allocate a new KSM page copy from healthy duplicate >>>        KSM page. If successful, migrate the mapping to this new KSM page. >>>     b. If allocation fails, migrate the mapping to the existing healthy >>>        duplicate KSM page. >>> 4. If all migrations succeed, remove the failing KSM page from the chain. >>> 5. Only if recovery fails (e.g., no healthy duplicate found or migration >>>     error) does the kernel fall back to killing the affected processes. >>> >>> Signed-off-by: Longlong Xia >> Thanks for your patch. Some comments below. >> >>> --- >>>   mm/ksm.c | 246 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>   1 file changed, 246 insertions(+) >>> >>> diff --git a/mm/ksm.c b/mm/ksm.c >>> index 160787bb121c..9099bad1ab35 100644 >>> --- a/mm/ksm.c >>> +++ b/mm/ksm.c >>> @@ -3084,6 +3084,246 @@ void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc) >>>   } >>>     #ifdef CONFIG_MEMORY_FAILURE >>> +static struct ksm_stable_node *find_chain_head(struct ksm_stable_node *dup_node) >>> +{ >>> +    struct ksm_stable_node *stable_node, *dup; >>> +    struct rb_node *node; >>> +    int nid; >>> + >>> +    if (!is_stable_node_dup(dup_node)) >>> +        return NULL; >>> + >>> +    for (nid = 0; nid < ksm_nr_node_ids; nid++) { >>> +        node = rb_first(root_stable_tree + nid); >>> +        for (; node; node = rb_next(node)) { >>> +            stable_node = rb_entry(node, >>> +                    struct ksm_stable_node, >>> +                    node); >>> + >>> +            if (!is_stable_node_chain(stable_node)) >>> +                continue; >>> + >>> +            hlist_for_each_entry(dup, &stable_node->hlist, >>> +                    hlist_dup) { >>> +                if (dup == dup_node) >>> +                    return stable_node; >>> +            } >>> +        } >>> +    } >> Would above multiple loops take a long time in some corner cases? > > Thanks for the concern. > > I do some simple test。 > > Test 1: 10 Virtual Machines (Real-world Scenario) > Environment: 10 VMs (256MB each) with KSM enabled > > KSM State: > pages_sharing: 262,802 (≈1GB) > pages_shared: 17,374 （≈68MB） > pages_unshared = 124,057 (≈485MB) > total ≈1.5GB > chain_count = 9, not_chain_count = 17152 > Red-black tree nodes to traverse: > 17,161 (9 chains + 17,152 non-chains) > > Performance: > find_chain: 898 μs (0.9 ms) > collect_procs_ksm: 4,409 μs (4.4 ms) > Total memory failure handling: 6,135 μs (6.1 ms) > > > Test 2: 10GB Single Process (Extreme Case) > Environment: Single process with 10GB memory, > 1,310,720 page pairs (each pair identical, different from others) > > KSM State: > pages_sharing: 1,311,740 （≈5GB) > pages_shared: 1,310,724 （≈5GB) > pages_unshared = 0 > total ≈10GB > Red-black tree nodes to traverse: > 1,310,721 (1 chain + 1,310,720 non-chains) > > Performance: > find_chain: 28,822 μs (28.8 ms) > collect_procs_ksm: 45,944 μs (45.9 ms) > Total memory failure handling: 46,594 μs (46.6 ms) Thanks for your test. > > Summary: > The find_chain function shows approximately linear scaling with the number of red-black tree nodes. > With a 76x increase in nodes (17,161 → 1,310,721), latency increased by 32x (898 μs → 28,822 μs). > representing 62% of total memory failure handling time (46.6ms). > However, since memory failures are rare events, this latency may be acceptable > as it does not impact normal system performance and only affects error recovery paths. > IMHO, the execution time of a kernel function must not be too long without any scheduling points. Otherwise it may affect the normal scheduling of the system and leads to something like performance fluctuation. Or am I miss something? Thanks. .