From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8056AC04EB8 for ; Thu, 6 Dec 2018 19:48:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F6032054F for ; Thu, 6 Dec 2018 19:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F6032054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbeLFTsX (ORCPT ); Thu, 6 Dec 2018 14:48:23 -0500 Received: from smtprelay0157.hostedemail.com ([216.40.44.157]:42073 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725935AbeLFTsW (ORCPT ); Thu, 6 Dec 2018 14:48:22 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 94334100E806B; Thu, 6 Dec 2018 19:48:21 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: north87_65f83cb04f71b X-Filterd-Recvd-Size: 1354 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Thu, 6 Dec 2018 19:48:20 +0000 (UTC) Message-ID: Subject: Re: [PATCH 00/13] hwmon: Introduce SENSOR_DEVICE_ATTR_{RO, RW, WO} and variants From: Joe Perches To: Guenter Roeck , linux-hwmon@vger.kernel.org Cc: Jean Delvare , linux-kernel@vger.kernel.org Date: Thu, 06 Dec 2018 11:48:19 -0800 In-Reply-To: <1544124153-23961-1-git-send-email-linux@roeck-us.net> References: <1544124153-23961-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-12-06 at 11:22 -0800, Guenter Roeck wrote: > Introduce SENSOR_DEVICE_ATTR_{RO,RW,WO} and SENSOR_DEVICE_ATTR_2_{RO,RW,WO} > as simplified variants of SENSOR_DEVICE_ATTR and SENSOR_DEVICE_ATTR_2 to > simplify the source code, improve readbility, and reduce the chance of > inconsistencies. > > This series introduces the new macros and converts some of the drivers. Thanks, eliminating the S_ uses would be nice and more consistent with the other DEVICE_ATTR_{RO,RW,WO} uses.