From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 047F81BCA0A for ; Mon, 18 Nov 2024 16:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731946206; cv=none; b=R3yjZZo1B6ZE07Dgq2wDRDYFAQgxQ0HFTwVhhU0uH9T1jYTZjlvOE6ozyg2A43Fp8eFtykyis79mIWDStMZ+DiNHxGT9GqvanRhoSKvl8N1S4pex5xatvveDS2ml6FOnzb5l9o+hBpuAuLJVQmRZ7xG2ea0Dx3Itu6tTYoqZT9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731946206; c=relaxed/simple; bh=QfPXYHL5fsdkIoYd0xVznS8WD1LBbFDqzny4ASgLKbY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ccbVm92pVcQkJpGBI3Kdhdmq5qWyQR0lD6zPRHzGPpd53rMt9F9HQ1X0u90Cn4sIeN+/HJBaWKlkINS2JLBSmA2nBJkPmddufQjtCIbT3rkDx4XsqjHve7yoXabl01WQ1WeFXUmdheFafOfXguOazfcGa9SQCSaTCd4HvToFUIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=kT4Vfeyj; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="kT4Vfeyj" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5ebc0dbc566so2005452eaf.3 for ; Mon, 18 Nov 2024 08:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731946203; x=1732551003; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nEQPAT/nZnphZ6rlK9fU/8h4DP7I7h6rQ06FLczHMWs=; b=kT4VfeyjDq2hCSc49aJrxb/3/ICQKZs6xx5e/vL8xTGZWjMlcHNC9/e0kbUECv3h0T +cuuysC88gtsxqoM0WXgpIGE9TNRFjwo75tqNVRldkEvF7TLksaO59Mp7/HhlUq7UU3n Rshp9A1IgKsM3XZADnTFgpHBoj+kVUsBGW8byq2V8HB2Tk2YNT7q6ta4bB0zyoF6aQgC sNaVMoITA5GVPVx1+XZIN52ATzc+I25GBvJBnyedzQi1MvWAA4Yth7RtuOhXCjhw4I9d KttJNal6oRolNDWRxxxkpfmOUX56rwyR6z3AVK6YstOgilx7+LuEIMKPykxS9AZCFrIK yN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731946203; x=1732551003; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nEQPAT/nZnphZ6rlK9fU/8h4DP7I7h6rQ06FLczHMWs=; b=rafqtHLSET2M0FLvO0LhaH5o6XjMQMFxBwd2hKyOnDNIS4g0lozKNcb02cyOx79vsL LTlR0iaxgSPUfhSiBakU0W4yLGO247+ag4GvGnehWPbeNESRgzraVIUOLgOQ5iw8ra5o uq3ayD//aqmylFF3En+UZm15qCQA7SeoPAmrF37tNd8F0h4gZATGmm3JuwGG6vHhblor /GSLT+GgcCrPOiqu9vw2g7UH94fjBx1C/CtXOsxKv9ah+7mT2uHTkyIIULVq5zYFhpUT xCgwa8pdGgUnBMsPK1b0k3uJ1J4PX+Iq8upE2vqR+eJ3ORRZahAMx0LEhlh84d8XXuOr FgZw== X-Forwarded-Encrypted: i=1; AJvYcCUJwRa5r8UUBvPAodLowZDYH17TfQg+0GM41Wto0f8KzeN/1YgVtTYYDWNINeG/zCBUPA3YBgtUHiTkGcQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywdbo1sfHRXQ9Wd/NPTXUHfL7IymSX5uDKZ2cM96dejbEXvTDOR kM5LenKr12th783mHP1xeemP9OuG0aid+TJm1tFtIUqyYlq2YnvPuzjXed+R4ww= X-Google-Smtp-Source: AGHT+IHhbH8HnsWWc2oM5+X6l6Jxm01cBB+zT4adkJw5m0vc06zcpCay0UFQ6Bdl2zk+kGL7rOU9RA== X-Received: by 2002:a05:6820:2018:b0:5ee:bb2:bdd4 with SMTP id 006d021491bc7-5eeab294512mr9840034eaf.1.1731946203194; Mon, 18 Nov 2024 08:10:03 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-71a78214f08sm2768949a34.70.2024.11.18.08.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Nov 2024 08:10:02 -0800 (PST) Message-ID: Date: Mon, 18 Nov 2024 09:10:00 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] rust: block: simplify Result<()> in validate_block_size return To: Miguel Ojeda , manas18244@iiitd.ac.in Cc: FUJITA Tomonori , Trevor Gross , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andreas Hindborg , Boqun Feng , Miguel Ojeda , Alex Gaynor , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Shuah Khan , Anup Sharma , netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: <20241118-simplify-result-v3-0-6b1566a77eab@iiitd.ac.in> <20241118-simplify-result-v3-1-6b1566a77eab@iiitd.ac.in> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/18/24 9:05 AM, Miguel Ojeda wrote: > On Mon, Nov 18, 2024 at 3:37?PM Manas via B4 Relay > wrote: >> >> From: Manas >> >> `Result` is used in place of `Result<()>` because the default type >> parameters are unit `()` and `Error` types, which are automatically >> inferred. Thus keep the usage consistent throughout codebase. >> >> Suggested-by: Miguel Ojeda >> Link: https://github.com/Rust-for-Linux/linux/issues/1128 >> Signed-off-by: Manas > > If block wants to pick this one up independently: > > Reviewed-by: Miguel Ojeda I can grab it. -- Jens Axboe