From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755857AbdJLKrc (ORCPT ); Thu, 12 Oct 2017 06:47:32 -0400 Received: from mout.web.de ([212.227.15.14]:63596 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbdJLKra (ORCPT ); Thu, 12 Oct 2017 06:47:30 -0400 Subject: [PATCH 07/10] staging/irda/net: Delete an unnecessary variable initialisation in four functions From: SF Markus Elfring To: devel@driverdev.osuosl.org, netdev@vger.kernel.org, Al Viro , Corentin Labbe , David Howells , "David S. Miller" , Georgiana Chelu , Greg Kroah-Hartman , Johannes Berg , Julia Lawall , Samuel Ortiz , Srishti Sharma , Stephen Hemminger , Yuan Linyu Cc: LKML , kernel-janitors@vger.kernel.org References: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Message-ID: Date: Thu, 12 Oct 2017 12:47:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8152401b-d68d-c4fe-2619-82a09e0c52ec@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:XrrDicspOXSmKJESRwnlJrGTnrdlCvXz6rnbKLSxmoVqKcHffLH Vy4soalaCMaqX81ypgk5Px4iR0BFrJL8ZXxZrs3TE73ZL3HMuvSscQKbGJXhKWyxTwQ+qAP tNt6EgUOLQ57FqIheVMDiM2Ogj1wLhYssiunYK3kG9sIoS30IB4JvyKhQjR/XQWczGdIYM4 Mha/aGvaj3zQy6SdAjslA== X-UI-Out-Filterresults: notjunk:1;V01:K0:bgTDBXBRdiE=:iR76souecfyJC/SSVwab36 Hge8dRRnqkPTm1nRNcRHQDA8gxvqT0vOLmr+z17Z7WKhOc5NPZwMlDmRfsa+zf7T2JpfFTP83 kagDhIT8XEy7sfvYZfv128i9HuyIzwXYcN82ULmM87bmrKW/Ff8HOPz+A0T9fYHco/bCb89z+ aEi2mkACQ2ThHZYL8LrGSnFWvvMbkXMVWvS//j+CXJZ/LEPpz+uGayCSmo2xUOjULotc+f7zM Ci2KBGA2a4CDZ13s+Vvdy6k7mIuCh50mu0Ww5N0YvEN4Jgj5RphcybgluHyUxsHvY3UaLWotj xfwVgaDsmM9gAT1pEFNHZG5ERHb1wvB0ixk7PEZDShacVkoxd1ycu2H60TdmNAreUqQltlN+F /q+8UYDoUcYQ/mYXHHVbu6M+NWUZr6tzbb+w60PK8/w0B8xMpFfK9DQDW7eYWyWxQ8vVOJpxw 1Kk6L/B/QfsRpYMmUbHKCAl6/kMa1mdl26hR6l4ifYSkGOJTk2c0C797oKHFJb9K/Pl3UWZmU 3Cson5pn/c8OBAWbJQbhc9Dau56FX3dNcrx6hMgm0K/8ulqchFb5T0XMfJkr+PCms5+oVERYq vDqH1uYjDzlqHjNzC/Bkq5gWFrDUATBAoPwKpZ0ff9OupX9XF+5gFPnHHWM7aV5O61l59cTkP Tu93W0GrvkYgFmPAdRXh9JgH4k0ST8nkASdxqvlAKKBuP5dwH5S9opODMC7UCwX2aBl9npPpb zPf4mfKhrHMOYzhXdlGymYGA4+ID4f3nf0udt73DLMxnjxlQWazhR9qfSb1tYavKWTifdKfDf jHj7lhnlpmgu0QIOnq7TB5SQ8UVivZQdIfVf9eMjanNGfvkr/c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 11 Oct 2017 22:26:00 +0200 The variable "tx_skb" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/irda/net/irlap_frame.c | 6 +++--- drivers/staging/irda/net/irttp.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/irda/net/irlap_frame.c b/drivers/staging/irda/net/irlap_frame.c index 25ceb06efd58..16fe7f53fdb7 100644 --- a/drivers/staging/irda/net/irlap_frame.c +++ b/drivers/staging/irda/net/irlap_frame.c @@ -258,7 +258,7 @@ void irlap_send_ua_response_frame(struct irlap_cb *self, struct qos_info *qos) */ void irlap_send_dm_frame( struct irlap_cb *self) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; struct dm_frame *frame; IRDA_ASSERT(self, return;); @@ -288,7 +288,7 @@ void irlap_send_dm_frame( struct irlap_cb *self) */ void irlap_send_disc_frame(struct irlap_cb *self) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; struct disc_frame *frame; IRDA_ASSERT(self, return;); @@ -315,7 +315,7 @@ void irlap_send_disc_frame(struct irlap_cb *self) void irlap_send_discovery_xid_frame(struct irlap_cb *self, int S, __u8 s, __u8 command, discovery_t *discovery) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; struct xid_frame *frame; __u32 bcast = BROADCAST; __u8 *info; diff --git a/drivers/staging/irda/net/irttp.c b/drivers/staging/irda/net/irttp.c index 2adba87aeb68..bc612227cdc3 100644 --- a/drivers/staging/irda/net/irttp.c +++ b/drivers/staging/irda/net/irttp.c @@ -811,7 +811,7 @@ static void irttp_run_tx_queue(struct tsap_cb *self) */ static inline void irttp_give_credit(struct tsap_cb *self) { - struct sk_buff *tx_skb = NULL; + struct sk_buff *tx_skb; unsigned long flags; int n; -- 2.14.2