From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Drokin, Oleg'" <oleg.drokin@intel.com>,
James Simmons <jsimmons@infradead.org>
Cc: "<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"<lustre-devel@lists.lustre.org>" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask
Date: Tue, 10 Nov 2015 00:44:48 +0000 [thread overview]
Message-ID: <db7639785c8048ed966aca6908516797@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <5F41E759-F653-4A35-B2E5-15544BCF4BD2@intel.com>
>> We need cfs_str2mask exported for our server code.
>> Even with the server code not available upstream
>> it would be nice to use the upstream code on Lustre
>> servers.
>>
>> Signed-off-by: James Simmons <jsimmons@infradead.org>
>> ---
>> .../staging/lustre/lustre/libcfs/libcfs_string.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>> index d40be53..05630f8 100644
>> --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>> +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
>> @@ -111,6 +111,7 @@ int cfs_str2mask(const char *str, const char *(*bit2str)(int bit),
>> *oldmask = newmask;
>> return 0;
>> }
>> +EXPORT_SYMBOL(cfs_str2mask);
>
>If this is the case of it being used out of tree, I suspect a comment here to that effect would be
>useful, otherwise next person running a script to eliminate unused EXPORT_SYMBOLs would kill it again.
I will send another patch with comments not to remove the new code.
next prev parent reply other threads:[~2015-11-10 0:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 16:34 [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl James Simmons
2015-11-08 16:34 ` [PATCH] staging: lustre: Handle nodemask on UMP machines James Simmons
2015-11-09 11:19 ` Sudip Mukherjee
2015-11-10 0:46 ` [lustre-devel] " Simmons, James A.
2015-12-21 22:08 ` Greg Kroah-Hartman
2015-12-22 0:30 ` [lustre-devel] " Dilger, Andreas
2015-11-08 16:34 ` [PATCH] staging: lustre: add sparse locking annotations James Simmons
2015-11-08 16:34 ` [PATCH] staging: lustre: added debugging ability for LFSCK James Simmons
2015-11-08 16:34 ` [PATCH] staging: lustre: enum lu_object_header_flags comma style fix James Simmons
2015-11-08 16:34 ` [PATCH] staging: lustre: export cfs_str2mask James Simmons
2015-11-09 11:08 ` [lustre-devel] " Drokin, Oleg
2015-11-10 0:44 ` Simmons, James A. [this message]
2015-12-21 22:05 ` Greg Kroah-Hartman
2015-11-08 16:35 ` [PATCH] staging: lustre: add libcfs version of cfs_strrstr James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db7639785c8048ed966aca6908516797@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®