mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>, Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c
Date: Mon, 8 Feb 2021 17:05:52 -0700	[thread overview]
Message-ID: <db7c4310-503b-f84f-99a6-0d8d58da99b6@linuxfoundation.org> (raw)
In-Reply-To: <1612506839-27225-1-git-send-email-yangtiezhu@loongson.cn>

On 2/4/21 11:33 PM, Tiezhu Yang wrote:
> When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>   tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index ad41ea6..e704181 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>   
>   	if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
>   		ksft_print_msg(
> -			"ptrace(PTRACE_SINGLESTEP) failed: %s\n",
> +			"ptrace(PTRACE_CONT) failed: %s\n",
>   			strerror(errno));
>   		return false;
>   	}
> @@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>   	}
>   	alarm(0);
>   	if (WIFEXITED(status)) {
> -		ksft_print_msg("child did not single-step\n");
> +		ksft_print_msg("child exited prematurely\n");
>   		return false;
>   	}
>   	if (!WIFSTOPPED(status)) {
> 

Thank you. Applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah

      reply	other threads:[~2021-02-09  0:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  6:33 Tiezhu Yang
2021-02-09  0:05 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db7c4310-503b-f84f-99a6-0d8d58da99b6@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®