From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Simon Horman" <horms@kernel.org>,
"Boon Khai Ng" <boon.khai.ng@altera.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] net: altera-tse: Warn on bad revision at probe time
Date: Mon, 3 Nov 2025 14:42:28 +0100 [thread overview]
Message-ID: <db7e920d-a03e-40fd-9b37-71e836f0faf8@lunn.ch> (raw)
In-Reply-To: <20251103104928.58461-3-maxime.chevallier@bootlin.com>
On Mon, Nov 03, 2025 at 11:49:25AM +0100, Maxime Chevallier wrote:
> Instead of reading the core revision at probe time, and print a warning
> for an unexecpected version at .ndo_open() time, let's print that
> warning directly in .probe().
>
> This allows getting rid of the "revision" private field, and also
> prevent a potential race between reading the revision in .probe() after
> netdev registration, and accessing that revision in .ndo_open().
>
> By printing the warning after register_netdev(), we are sure that we
> have a netdev name, and that we try to print the revision after having
> read it from the internal registers.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-11-03 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 10:49 [PATCH net-next v2 0/4] net: altera-tse: Cleanup init sequence Maxime Chevallier
2025-11-03 10:49 ` [PATCH net-next v2 1/4] net: altera-tse: Set platform drvdata before registering netdev Maxime Chevallier
2025-11-05 2:20 ` Jakub Kicinski
2025-11-03 10:49 ` [PATCH net-next v2 2/4] net: altera-tse: Warn on bad revision at probe time Maxime Chevallier
2025-11-03 13:42 ` Andrew Lunn [this message]
2025-11-03 10:49 ` [PATCH net-next v2 3/4] net: altera-tse: Don't use netdev name for the PCS mdio bus Maxime Chevallier
2025-11-03 10:49 ` [PATCH net-next v2 4/4] net: altera-tse: Init PCS and phylink before registering netdev Maxime Chevallier
2025-11-05 2:20 ` [PATCH net-next v2 0/4] net: altera-tse: Cleanup init sequence patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db7e920d-a03e-40fd-9b37-71e836f0faf8@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®