From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262050AbVERB6T (ORCPT ); Tue, 17 May 2005 21:58:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262046AbVERB6S (ORCPT ); Tue, 17 May 2005 21:58:18 -0400 Received: from relay02.mail-hub.dodo.com.au ([202.136.32.45]:23476 "EHLO relay02.mail-hub.dodo.com.au") by vger.kernel.org with ESMTP id S262061AbVERB6H (ORCPT ); Tue, 17 May 2005 21:58:07 -0400 From: Grant Coady To: Yani Ioannou Cc: Greg KH , LKML , LM Sensors Subject: Re: [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Date: Wed, 18 May 2005 11:58:01 +1000 Organization: Message-ID: References: <2538186705051703479bd0c29@mail.gmail.com> <2538186705051704181a70dbbf@mail.gmail.com> <0pik81hjboqvbf2jhgdut861cfpgl7sata@4ax.com> <2538186705051713565d07e66b@mail.gmail.com> <25381867050517162126d18704@mail.gmail.com> In-Reply-To: <25381867050517162126d18704@mail.gmail.com> X-Mailer: Forte Agent 2.0/32.652 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Yani, On Tue, 17 May 2005 19:21:41 -0400, Yani Ioannou wrote: >Ah..OK, that is probably why, I've put the macros which would be >expanded in the first level in a separate header because it will >probably be shared amongst many drivers. Although I still don't see >where SENSOR_blah is coming from at all at the moment, if you can >track that down I'd be interested to know if its just something to do >with the script or a problem with the patch. Oops, my script, sorry. I'll fix that. >> Not singletons, 3 of each (from an intermediate file): . . . > >Well I said mainly singletons :-), some of the attributes don't >benefit from the dynamic sysfs callbacks simply because they already >only use one callback for a few different attributes, I believe that's >the case with the non-singletons in this case. Not quite that, one sysfs name, one value. The multiple sysfs names that were 'missed' by your changes don't use the usual macro. Three instances of each attribute in the source, instead. --Grant.