mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolai Buchwitz <nb@tipi-net.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Linus Walleij" <linusw@kernel.org>,
	"Alvin Šipraga" <alsi@bang-olufsen.dk>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses
Date: Wed, 03 Jun 2026 14:38:22 +0200	[thread overview]
Message-ID: <db861659b03b355cb3860231e54176d8@tipi-net.de> (raw)
In-Reply-To: <20260603112011.230890-1-andriy.shevchenko@linux.intel.com>

On 3.6.2026 13:20, Andy Shevchenko wrote:
> Convert to %pM instead of using custom code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/net/dsa/realtek/rtl8366rb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/realtek/rtl8366rb.c 
> b/drivers/net/dsa/realtek/rtl8366rb.c
> index d96ae72b0a5c..103039fe3086 100644
> --- a/drivers/net/dsa/realtek/rtl8366rb.c
> +++ b/drivers/net/dsa/realtek/rtl8366rb.c
> @@ -573,8 +573,7 @@ static int rtl8366rb_set_addr(struct realtek_priv 
> *priv)
> 
>  	eth_random_addr(addr);
> 
> -	dev_info(priv->dev, "set MAC: %02X:%02X:%02X:%02X:%02X:%02X\n",
> -		 addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
> +	dev_info(priv->dev, "set MAC: %pM\n", addr);
>  	val = addr[0] << 8 | addr[1];
>  	ret = regmap_write(priv->map, RTL8366RB_SMAR0, val);
>  	if (ret)

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks
Nicolai

  parent reply	other threads:[~2026-06-03 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 11:20 Andy Shevchenko
2026-06-03 12:25 ` Andrew Lunn
2026-06-03 12:38 ` Nicolai Buchwitz [this message]
2026-06-04 20:18 ` Linus Walleij
2026-06-05  1:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db861659b03b355cb3860231e54176d8@tipi-net.de \
    --to=nb@tipi-net.de \
    --cc=alsi@bang-olufsen.dk \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®