From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47AC1396596 for ; Fri, 13 Mar 2026 13:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408553; cv=none; b=Bm6CmzJhKV4pwG5ZcTKgv1qaPRpguKrVTL8uQ6z3xgIsEP7QoqegzlMCRD/0jD4jqkn3vOTUL9exivgGfZK8KeAyUOOPpBRgqWapefgSWW9ioItdCpWoAiGHlVHBnuleBVEp94XOVxcbJKZw1r/+5aBO2tKqsB0yMXfJIuyHkWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408553; c=relaxed/simple; bh=W+oJvqnLEifFCeBQyBdAn57oCqIxPD8AugBnx9rd9yQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HemTNFRnoZfYFVTr0gk42a1rc7lJSPT7YxVj+oysimjHlG2Mz+heSqGrsJgEuY7OAgxcCA2HvX0+JWMhN31lmVRhX/YwlyEwVvuOI2CUJbMxgGT7uUPV1cvGlETVF/4jX4aj9A2Zu5ifwA0NWHQjmqh7UMXVOiFQfxHQ0k5os0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YftBR75F; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YftBR75F" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82989744ee0so2120198b3a.2 for ; Fri, 13 Mar 2026 06:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773408551; x=1774013351; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ajhis7YBLb7dOjMFcfePYTC4MgS14P3pGiFFUMVogos=; b=YftBR75Fqt3T0F/NQXaI/IJYCR9xFhyr8CzrH2QL43E6Pqd5JcTCWgFBgJL64ONYTS /AqbsgRdfPrhAep0s9QOj0Ksdx+lRDovROXj1HEWmV19FmZBCj86qVwhlJ1DaAXlWvvP YV6FZeSi80gqtL1RiB83Wj4U4jUGpSoF/RV6WRN51GKCh7QZjTP91P7aKWHArBzpPaBE WzxGp6L5nnj1y6XgoPGSzSCzImDERRJLoGpsQKxjV5y+iBI4Hj8/AbALRR0yfrZuprRV w064v8Jt7NSmWxGHG6FZ13VhsQXMT11KsUGC+zkcRnHAh5d8S2i7k0wvKKaKw3hbwqp2 b2Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773408551; x=1774013351; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ajhis7YBLb7dOjMFcfePYTC4MgS14P3pGiFFUMVogos=; b=j70Yo2GV63wphmiM1xqBAsKxPtxpMuVl5OLeZTRBdywCfwUrj0wDybY7vRaAKTeb8r ev28rYa+qfy46n0vaMxMiYkuXEaEQxAvP9JDTwpogiOJc/U/MiVeM+Zp0F6d6Ckv3CUn YqvQxnP+vXmjEGG7hNT0PomK9PefoU9ApEluCl/x9e1Jo8F2yVVFUx3CI/wcCFvQcRE1 z21uLXZrbdTwyvWzaoS9zoERtljwhWlpl92Jrh1oposYgJ8vbxNCFjA+QwMylEIKWj+W etKVCxdlMB2wGXdrFbdxZ37KKvMzbN+Cpybu2knsbKPXWELyptwBC05mVkYNXux/9/5o OSwA== X-Forwarded-Encrypted: i=1; AJvYcCUBUlEjo3cY65vvq9nGt8Hngi6OMyNEC8FZaT39s1BxzKDU0QRIBcvau3MuR75SIDlhHSaqEXP3eNVSdq0=@vger.kernel.org X-Gm-Message-State: AOJu0YzKQF4ZLKHxcqoaqCx/4G+QKqqLmb/jfP/dfhks6fgyTHYk6hza H4XZcxAlmRwcCngcra/J4nsnIZksqZQpm4LAXDydj5xt7XzUUSgXY4Hj X-Gm-Gg: ATEYQzwpmtEebYPzKCymeW3FG+H0VyAE+3Vf9IH2bTFm96vU932JHVarbnk4RZLtXOz Qu62uR4oKPdZQeMbnXEnR9yydtON3IyKqXWD/QjFiP7jiXsF7DKLGnjqOgJuUB41TXoyGnzJc3h rSJrcqEx2ZjEp+FDpKF8QX/NDB1HXGgCHwynrhdFFWKgtex63vzQ+bKAUhey0UfcCQa77Z1KwTD 8oaEDpSwH2obVifjy3PAgePRTsPm6YucrsYUFkl/+VmaRGj5RAf26G+ITp1sWtFi/jJhUWe4Q9a qhnYKEXDaLkMXWA5RQFdxEg9HPck5WA/UlANmaJCYPg61vWAO1t7zw7zoycKVnearkBW5D+t9us 44wyb8zY9t91JGlxEdXws1ZsgNO07m6fef+lNPXVCL5RDTU/IG7llTQy0wy/Gtlt7yJ+IPmpNE+ InuJrijlSlC9/PbJpI/yGpkWlutEPCKFkSMZRXSixNI5vZRMXFrOWDtLI= X-Received: by 2002:a05:6a00:94e3:b0:81f:9b09:ad02 with SMTP id d2e1a72fcca58-82a196f589emr3056858b3a.1.1773408550556; Fri, 13 Mar 2026 06:29:10 -0700 (PDT) Received: from [192.168.1.5] ([27.7.215.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0738bca8sm5870880b3a.60.2026.03.13.06.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 06:29:10 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 18:59:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] dt-bindings: usb: atmel,at91sam9rl-udc: convert to DT schema To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Claudiu Beznea , Herve Codina , Nicolas Ferre , Alexandre Belloni , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260307-atmel-usb-v3-0-3dc48fe772be@gmail.com> <20260307-atmel-usb-v3-5-3dc48fe772be@gmail.com> <20260308-cherubic-misty-cricket-80fad0@quoll> Content-Language: en-US From: Charan Pedumuru In-Reply-To: <20260308-cherubic-misty-cricket-80fad0@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08-03-2026 14:59, Krzysztof Kozlowski wrote: > On Sat, Mar 07, 2026 at 09:16:22AM +0000, Charan Pedumuru wrote: >> + >> + reg: >> + maxItems: 2 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 2 > > Drop Sure. > >> + maxItems: 2 >> + >> + clock-names: >> + minItems: 2 >> + maxItems: 2 >> + items: >> + enum: [pclk, hclk] > > No, list the items instead. Why is this flexible? Nothing in commit msg > explains that. Some of the DTS files use those clock-names in different order, I will write this in the commit message. > >> + >> + atmel,vbus-gpio: >> + description: GPIO used to detect the presence of VBUS, indicating that >> + the USB cable is connected. >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + gadget@fff78000 { >> + compatible = "atmel,at91sam9g45-udc"; >> + reg = <0x00600000 0x80000 >> + 0xfff78000 0x400>; >> + interrupts = <27 IRQ_TYPE_LEVEL_HIGH 0>; >> + clocks = <&pmc PMC_TYPE_PERIPHERAL 27>, <&pmc PMC_TYPE_CORE PMC_UTMI>; >> + clock-names = "pclk", "hclk"; >> + atmel,vbus-gpio = <&pioC 15 GPIO_ACTIVE_HIGH>; >> + }; >> +... >> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt >> deleted file mode 100644 >> index 12183ef47ee4..000000000000 >> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt >> +++ /dev/null >> @@ -1,125 +0,0 @@ >> -Atmel SOC USB controllers >> - >> -OHCI >> - >> -Required properties: >> - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers > > Why do you remove OHCI here? There is no conversion of this compatible. > Don't combine multiple different changes in one commit. I will remove each binding from the text file for each patch while converting them. > > > Best regards, > Krzysztof > -- Best Regards, Charan.