From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65AFB2BE7DF for ; Thu, 4 Dec 2025 06:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764831116; cv=none; b=B0HLxnX+Kpywzjsls/OVctG7pwU/GmnoGpnJJWj+yc05kvOmn97aaKZVgCLO9W34cdqhmQrJpJ2vu7GFdCrlrwgLF7QHHDJOgKmVGNb6m2T8oYkYRPsf1ubzoE4ztusvplqzWZrKhG/kjUyIzmZePbsAb5NnDxJ1SmUWsachC9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764831116; c=relaxed/simple; bh=KT2QYR2wXHJ2g64QXkiAxDnQTrNBOsJcBtPqzT2t4EU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s5WVShRUGQnpicRfIf5QkzwQQIt4s9mP0mQUelGwW0Qx7vlqobx1jmnhALjctiomgq4B/jFZwbHWg4/8dlXIUkXzp8UktGI+bnaWI6YDCjgFakHDa+Mtf2PXqcyHjkGTXWGGRhGuU6WNc5vj9agFWpINCDU8Yj518sa2WGe/gwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F8kdsRl5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fZj7Y/Ak; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F8kdsRl5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fZj7Y/Ak" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B468nMW823778 for ; Thu, 4 Dec 2025 06:51:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SwIvTqC0vtcEcT4pWezqNiZK3gnYXhecWCg8UTidylM=; b=F8kdsRl5LEWN6Tn1 5FHZaLrLxQxo6Ra1PVUCwutZw95KlEYi7QFYpdKATUS2mFCN4XjCHExVsRsnEb44 JC+qVhYS/ltNcipCo0tQwqtYXCRp6tmmJlX6IIQ8kuAUl9Sjfm58JFlcubu6EgzZ w9yovQTDhluuYULnJAkhHXIgwKct8Im6KmyCRfHS46zLONINXS+CCReEGa4tlz8u 6vvdPDaWaFvOfBXArh7m2ZqQmqn4tHMjUmKgjDW0i7n1z+wpcnXkwRrYzCW5bixI b+i48exmM7ddaX3CnAPIldhqGYxsCD3Qesban++Vq9HMGzJcdgKfAJoFGk/IH7bL HNjuog== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atm12b2jj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 06:51:54 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-297f48e81b8so10089855ad.0 for ; Wed, 03 Dec 2025 22:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764831113; x=1765435913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SwIvTqC0vtcEcT4pWezqNiZK3gnYXhecWCg8UTidylM=; b=fZj7Y/Ak96pqEEPk00NzlcMs6BSUJCryfLrb4BHhorAuZuzF0cBSHY57FqujQWSxRi hN8ifA1f/n+jgdiu27991I98jqP7bYknReUa9jC4G4y2NogA69R3GP35XJp6+GbAvcrT 3Yuj7hNu6L0zIquZBcYLtD/BNoRZiGd1aOkrFo18GlTBdHqM5IaEtBCj2Sx9ykAdvFhg PKTw9JzJ3Wg+DndyWkovaC63AXvFTrRpZhf8i8Uh1C9RTMGkhf+Nfnebhcr8kYQfBDBG FwNhBWXBuwtYlqLKU04Bta06ZVFpoo0zm5RONhPTsZSysbVDaJggI7hDev8GD2zj859d EhPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764831113; x=1765435913; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SwIvTqC0vtcEcT4pWezqNiZK3gnYXhecWCg8UTidylM=; b=exGSXZMXY8FmdPZknEDcykG2UPxt6ptwj0HUuGWw3RW/6uO4eBux2ipOWt/OGJjS9y Wcv4Xct9nD/rvP9KrqG89XVvErX53hCcwl94tIyvy/Fi0cKk03F4Pt3ih37AvuOz3/wT iFZ7NJLEbhsQ+bfIr0CO8RD7TElW3gTL9dDXEAAR7iTH7wO1TuScwTrb48DwxPu5eRv9 MQCOaoUNsw4y0yeo5+A+DRWlHhJBQVOS5gqVMp38ikX7mhCTSMJ4fNPFwhgqwcNncaKi v2hI0X9M4wp2NnvFTrgkn9hn/T3bjcyWnBaz9+zxDVMQlVFQtOjzBghTNK3Mbq1oqYhd ILrQ== X-Forwarded-Encrypted: i=1; AJvYcCUm3RwELzLKsH7DF/sLd+RacMXavjk7/9nB2sh+4WRoqrQ2H+1WQe+Q832h+4+FV3HY4kfzH4ua4o3lpUk=@vger.kernel.org X-Gm-Message-State: AOJu0YxQMs0PVuX4gK56x8iuynBPgGsJmqeMtW+lybgzjI6PBQsymlhY 8kX7OHmkBRgf8r7nYXVyP4532ybjZEqpexbUPWueNPEZg1YWM1yOiphYNcJVaZ2HYS+ArIIXW9z A0trZlbSw7D7H4JggGDpQ+WF6yzoGcikjKc5IWfaUqbJAScs7H0tee9DGfKBfjLlSUu0= X-Gm-Gg: ASbGnct3xF9GApscNxfJAtZ/s1Y5UIuGAHkZ0O2/+5k1D+q6dsNmxF6lo85h5rSuWFU hIDq12MV13wiOo3dZbC5JBAt5dgC+NqZTtbbOdSpOsz7vcQaxzSux1LPWHqhBqMrSVGrou9w7jF Ce8GdLPx5HSRjTKU/hRvx8K6AL07tnk+0heh8CSDq/q8bumiqd/0M8h8WRfnmScV28KvPW0WsII MgiPuZu97zhAan0zTygAyfzCWlyed82eoT5v5CgytUwGLkHKunF2fKPIRa1p50yagcOh7wZGNWD oc9AgsynljBCY9po68iMyIs1ygFbOm/l6he9T3/CSyS5PhIXGk1iY0hD4d+OSFydMRv0Zugq3Yv 8eVINSMu8RPjBam8NlxS6HoKJc60zh+9AMWRMGg== X-Received: by 2002:a17:902:f544:b0:297:eb3c:51ed with SMTP id d9443c01a7336-29d9ed0b4fbmr26080655ad.16.1764831113141; Wed, 03 Dec 2025 22:51:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEK/6jD4CnU7c208zP0SLAeyIoeJRxRQ14N6apIAj0JxvDPjIPkL429Mbb2KAq5S0NdCutI0g== X-Received: by 2002:a17:902:f544:b0:297:eb3c:51ed with SMTP id d9443c01a7336-29d9ed0b4fbmr26080225ad.16.1764831112660; Wed, 03 Dec 2025 22:51:52 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae4d3b5dsm9082855ad.40.2025.12.03.22.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 22:51:52 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 12:21:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/11] clk: qcom: Add support for VideoCC driver for Kaanapali To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Vladimir Zapolskiy , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20251125-kaanapali-mmcc-v2-v2-0-fb44e78f300b@oss.qualcomm.com> <20251125-kaanapali-mmcc-v2-v2-10-fb44e78f300b@oss.qualcomm.com> <850c172d-66e0-4d28-903d-fbcef7ad7444@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <850c172d-66e0-4d28-903d-fbcef7ad7444@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDA1NCBTYWx0ZWRfX2oaTV5/ZiohP Bq18GfMDKR4h5aGLYfFqh1gRdw7T5sVngpxYW2jT40E6B6HUhPPEI5frzIofyo7BmDPCXiEOL1o TeViWU4HUEkBMB6iqKfiLDBoYw0EB3uy6h7Ia1c0rYG7rVE2aexelC82Wy4b8fVs8nvdC6l02gj 9f2n+Z1yfqGaXiMKPi9/p6QmawuO3ESjhpCwynZyK2quSINpk3LBR7jiekbIuBVkbKO+EBdys6a J7Rndld0xOxWbITohgDexZ6yggJKrk6QXXpPs6hclq3zm1VnNWmJoMFydp1I/PifVKdY70vTO46 vcdZ7/v8SxRl0fsgVdSd76Bf4SCtJnRgiqUpjdKAN2z1V1iJ2+vf/Gco3r4Zt9lUVjel790iF9R 0wCAgYUPuEHeZ6eMQ8KvsazivhDoOA== X-Authority-Analysis: v=2.4 cv=JY6xbEKV c=1 sm=1 tr=0 ts=69312f8a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6AvYVb4XUzzG-8MtstsA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: IVkHv8s1NS-b6Egp3curcyJ4FzjFXEM8 X-Proofpoint-ORIG-GUID: IVkHv8s1NS-b6Egp3curcyJ4FzjFXEM8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_02,2025-12-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040054 On 12/1/2025 6:45 PM, Konrad Dybcio wrote: > On 11/25/25 6:45 PM, Taniya Das wrote: >> Enable Kaanapali video clock driver for video SW to be able to control >> the clocks from the Video SW driver. >> >> Signed-off-by: Taniya Das >> --- > > [...] > >> +static struct clk_mem_branch video_cc_mvs0_freerun_clk = { >> + .mem_enable_reg = 0x80E4, >> + .mem_ack_reg = 0x80E4, > > hex must be lowercase > Sure, will fix this. >> + .mem_enable_mask = BIT(3), >> + .mem_enable_ack_mask = 0xc00, > > GENMASK(11, 10) > will fix this as well. >> + .mem_enable_invert = true, >> + .branch = { >> + .halt_reg = 0x80e0, >> + .halt_check = BRANCH_HALT, >> + .clkr = { >> + .enable_reg = 0x80e0, >> + .enable_mask = BIT(0), >> + .hw.init = &(const struct clk_init_data) { >> + .name = "video_cc_mvs0_freerun_clk", >> + .parent_hws = (const struct clk_hw*[]) { >> + &video_cc_mvs0_clk_src.clkr.hw, >> + }, >> + .num_parents = 1, >> + .flags = CLK_SET_RATE_PARENT, >> + .ops = &clk_branch2_ops, >> + }, > > The indentation is a little malformed > will check this and fix. > >> +static void clk_kaanapali_regs_configure(struct device *dev, struct regmap *regmap) >> +{ >> + /* >> + * Enable clk_on sync for MVS0 and VPP clocks via VIDEO_CC_SPARE1 >> + * during core reset by default. >> + */ >> + regmap_update_bits(regmap, 0x9f24, BIT(0), BIT(0)); > > regmap_set_bits() > Will replace with the new API. > lgtm otherwise > > Konrad -- Thanks, Taniya Das