From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756246AbdJJNlt (ORCPT ); Tue, 10 Oct 2017 09:41:49 -0400 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:13827 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755919AbdJJNls (ORCPT ); Tue, 10 Oct 2017 09:41:48 -0400 From: X-LoopCount0: from 10.166.132.152 X-IronPort-AV: E=Sophos;i="5.42,505,1500958800"; d="scan'208";a="71693706" X-DLP: DLP_GlobalPCIDSS To: CC: , , , , , , , , , Subject: RE: [PATCH v6 13/14] platform/x86: wmi: create character devices when requested by drivers Thread-Topic: [PATCH v6 13/14] platform/x86: wmi: create character devices when requested by drivers Thread-Index: AQHTQbfXVJPkCX96dkG+nEPDiaGWEqLdFyKw Date: Tue, 10 Oct 2017 13:41:45 +0000 Message-ID: References: <897883f9b8c45dc2cb24de1bb4642513734852d3.1507589249.git.mario.limonciello@dell.com> <20171010110637.GB16994@kroah.com> In-Reply-To: <20171010110637.GB16994@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9ADg1er012643 > -----Original Message----- > From: Greg KH [mailto:greg@kroah.com] > Sent: Tuesday, October 10, 2017 6:07 AM > To: Limonciello, Mario > Cc: dvhart@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-x86@vger.kernel.org; > Andy Lutomirski ; quasisec@google.com; > pali.rohar@gmail.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de > Subject: Re: [PATCH v6 13/14] platform/x86: wmi: create character devices when > requested by drivers > > On Mon, Oct 09, 2017 at 05:51:51PM -0500, Mario Limonciello wrote: > > --- /dev/null > > +++ b/include/uapi/linux/wmi.h > > @@ -0,0 +1,19 @@ > > +/* > > + * User API methods for ACPI-WMI mapping driver > > + * > > + * Copyright (C) 2017 Dell, Inc. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > +#ifndef _UAPI_LINUX_WMI_H > > +#define _UAPI_LINUX_WMI_H > > + > > +#define WMI_IOC 'W' > > +#define WMI_IO(instance) _IO(WMI_IOC, instance) > > +#define WMI_IOR(instance, type) _IOR(WMI_IOC, instance, type) > > +#define WMI_IOW(instance, type) _IOW(WMI_IOC, instance, type) > > +#define WMI_IOWR(instance, type) _IOWR(WMI_IOC, instance, type) > > Are these really needed in a uapi .h file? Who needs them? And why not > just use a "normal" ioctl macro in your individual driver .h file? Do > these really help? > Since this is setting precedent that WMI drivers will use the IOC 'W' and the WMI bus driver will dispatch calls to the proper drivers, I think they make sense to include. I'm a little unclear - do you disagree? Or do you just think I need to include a comment in the header file with this information? Thanks,