mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>,
	<p.zabel@pengutronix.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
	<jassisinghbrar@gmail.com>, <fparent@baylibre.com>,
	<yongqiang.niu@mediatek.com>, <hsinyi@chromium.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH V5 3/6] dt-bindings: display: mediatek: revise enum to const
Date: Thu, 3 Mar 2022 17:44:49 +0800	[thread overview]
Message-ID: <db8c94fc5a7401af2d8a2d8c4135f6e13d6eac08.camel@mediatek.com> (raw)
In-Reply-To: <Yh+3fPzns86LSIdi@robh.at.kernel.org>

Hello Rob,

Thanks for your review.
I have sent v6 to fix this error.


https://lore.kernel.org/all/20220303065725.23384-3-rex-bc.chen@mediatek.com/

BRs,
Rex

On Wed, 2022-03-02 at 12:29 -0600, Rob Herring wrote:
> On Tue, Mar 01, 2022 at 04:01:02PM +0800, Rex-BC Chen wrote:
> > There won't be more than 1 fallback for these bindings, so we
> > modify
> > them to use const instead of enum.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml    | 2
> > +-
> >  .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml  | 2
> > +-
> >  .../devicetree/bindings/display/mediatek/mediatek,color.yaml  | 4
> > ++--
> >  .../devicetree/bindings/display/mediatek/mediatek,dither.yaml | 2
> > +-
> >  .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 2
> > +-
> >  .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml    | 4
> > ++--
> >  .../devicetree/bindings/display/mediatek/mediatek,rdma.yaml   | 4
> > ++--
> >  7 files changed, 10 insertions(+), 10 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > index 191b56e16bee..bc1c70d089ba 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > @@ -31,7 +31,7 @@ properties:
> >                - mediatek,mt8183-disp-aal
> >                - mediatek,mt8192-disp-aal
> >                - mediatek,mt8195-disp-aal
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8173-disp-aal
> 
> Run 'make dt_binding_check'. This will fail.
> 
> >  
> >    reg:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .yaml
> > index 6894b6999412..fc40e2981eaa 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .yaml
> > @@ -28,7 +28,7 @@ properties:
> >        - items:
> >            - enum:
> >                - mediatek,mt8195-disp-ccorr
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8192-disp-ccorr
> >  
> >    reg:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .yaml
> > index bc83155b3b4c..22ed5d368cbe 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .yaml
> > @@ -32,14 +32,14 @@ properties:
> >            - enum:
> >                - mediatek,mt7623-disp-color
> >                - mediatek,mt2712-disp-color
> > -          - enum:
> > +          - const:
> >                - mediatek,mt2701-disp-color
> >        - items:
> >            - enum:
> >                - mediatek,mt8183-disp-color
> >                - mediatek,mt8192-disp-color
> >                - mediatek,mt8195-disp-color
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8173-disp-color
> >    reg:
> >      maxItems: 1
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.yaml
> > index 9d89297f5f1d..2a82792b2625 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.yaml
> > @@ -28,7 +28,7 @@ properties:
> >            - enum:
> >                - mediatek,mt8192-disp-dither
> >                - mediatek,mt8195-disp-dither
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8183-disp-dither
> >  
> >    reg:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > index 247baad147b3..45f88bdf07bb 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > @@ -29,7 +29,7 @@ properties:
> >            - enum:
> >                - mediatek,mt8192-disp-gamma
> >                - mediatek,mt8195-disp-gamma
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8183-disp-gamma
> >  
> >    reg:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > index e71f79bc2dee..88ba3f27b0e4 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > @@ -33,12 +33,12 @@ properties:
> >            - enum:
> >                - mediatek,mt7623-disp-ovl
> >                - mediatek,mt2712-disp-ovl
> > -          - enum:
> > +          - const:
> >                - mediatek,mt2701-disp-ovl
> >        - items:
> >            - enum:
> >                - mediatek,mt8195-disp-ovl
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8183-disp-ovl
> >  
> >    reg:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > yaml
> > index 8ef821641672..56368c10d904 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > yaml
> > @@ -35,12 +35,12 @@ properties:
> >            - enum:
> >                - mediatek,mt7623-disp-rdma
> >                - mediatek,mt2712-disp-rdma
> > -          - enum:
> > +          - const:
> >                - mediatek,mt2701-disp-rdma
> >        - items:
> >            - enum:
> >                - mediatek,mt8192-disp-rdma
> > -          - enum:
> > +          - const:
> >                - mediatek,mt8183-disp-rdma
> >  
> >    reg:
> > -- 
> > 2.18.0
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > 
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-arm-kernel__;!!CTRNKA9wMg0ARbw!xcy2G7LgKWqMWhM9wMaommKbXGVMY6gc6B0zZRk4uP8AWS0KwLAg2O5buJuUVkOXiMa-$
> >  


  reply	other threads:[~2022-03-03  9:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  8:00 [PATCH V5 0/6] add display support for MediaTek SoC MT8186 Rex-BC Chen
2022-03-01  8:01 ` [PATCH V5 1/6] dt-bindings: arm: mediatek: mmsys: add support for MT8186 Rex-BC Chen
2022-03-01  8:20   ` Matthias Brugger
2022-03-01  8:01 ` [PATCH V5 2/6] dt-bindings: display: mediatek: add aal binding for MT8183 Rex-BC Chen
2022-03-01  8:01 ` [PATCH V5 3/6] dt-bindings: display: mediatek: revise enum to const Rex-BC Chen
2022-03-02 18:29   ` Rob Herring
2022-03-03  9:44     ` Rex-BC Chen [this message]
2022-03-01  8:01 ` [PATCH V5 4/6] dt-bindings: display: mediatek: change to use enum for mutex Rex-BC Chen
2022-03-01  8:01 ` [PATCH V5 5/6] dt-bindings: display: mediatek: add MT8186 SoC binding Rex-BC Chen
2022-03-01  8:01 ` [PATCH V5 6/6] drm/mediatek: add display support for MT8186 Rex-BC Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db8c94fc5a7401af2d8a2d8c4135f6e13d6eac08.camel@mediatek.com \
    --to=rex-bc.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fparent@baylibre.com \
    --cc=hsinyi@chromium.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®