From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A30FE2C15A3 for ; Mon, 29 Dec 2025 15:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767022767; cv=none; b=FBwhbSGCDQx0vnRLOGttaEKd8j5eH7tJTrbSSu9NUh7aFSNl9ZoBRuOIpbc9T7f5IEzFNjhQN44Aa5u0oi3Baw2MVwtsx/1FisV6Yru4j/0pm8WOhT5vJR6CpxrQ3Jf+XtDaS7Etbp3YoC1nR/Qiq8jUkuTPJLFpwWwAIH5Dxk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767022767; c=relaxed/simple; bh=m5wk7DPA5PPC1RkT7jGwYDcd9T8ByltOzgI3xVjVfYk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=UisM79Fy0ZTsBgT18fDqTT0HLo6IkiXELAZN79mfqOEKEVvnNe6o/W2LMVUalYJfP9m4VRkbvEtydUQzE0jJm23OGp/rnmlVy+48BZri9Cj0v7xRfo6uusnoYq0rcuvp4PrfoT9ZbXyuvzM42P+CvglNb3VsGGI9rtGSKHdg0Xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DwDGlRyB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QmeiN8Q+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DwDGlRyB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QmeiN8Q+" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BT93x7g1055500 for ; Mon, 29 Dec 2025 15:39:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QDqhvoKuT1ONkqv4vqVemJrZs971EDuQB/aPFvgZPY4=; b=DwDGlRyBczg1A74/ ka+spwa0HE+4kwZbH1S53DnvTiJcm6N39Px+sXfnCD3ILFC9et8/xlHiNopVZdvL XAUsjhoQOSu46guqOZ4sS9yM34lBtHDS9y+QrTszxsH1SQs4riieMiTxEFuaquD2 8f//B3i/t4DQzaPXjaW/bwQ7s0eg3ZndXwmZ70meX+rw5K2A1y+/RA2d89hBx9Ah MfORKQn4E/Y1eboaMHQ3yA9shW5I67f1FrNu0TLF+11dtYOekeAAKflxmvOU+QKn q/E7G4qAq2YZHvBZFi+zTPRHv5VKlxlWiN40ZNvsc/Wd5rPi/qyuHTmuqdx01qAL NHxzmw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bavrj376g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 15:39:24 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f1aba09639so27434201cf.0 for ; Mon, 29 Dec 2025 07:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767022764; x=1767627564; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=QDqhvoKuT1ONkqv4vqVemJrZs971EDuQB/aPFvgZPY4=; b=QmeiN8Q+wPREL8LVV++Ur4Hty3BHpd/3MAXySEDPKZniffMTqmdYBpCSWMVV47qWL8 h7V4lsz1AXhHXT+cnoZOiu5BIVYw8Ut6MHSoe4KglauGASvcKijziG9dF9Sf4RxWd1qd otA8FQoHIThKGLmmeovhFybqr4bFWFala61G04j4qxa9ZjBtssfiPRx66gpo5CyoDkZa MtFyK5+HdpsqAls0NZemh5w+iKfkocfjxPhkExKf0bOgYAHwAleX/BU6VnkNEKJ6/3y7 aGJ1u+yQjSnrPgO5SM9efK7bsGfePCw4pdm+n3G67kjlyueqGoasE23VySkBIi0uwl22 j1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767022764; x=1767627564; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QDqhvoKuT1ONkqv4vqVemJrZs971EDuQB/aPFvgZPY4=; b=W/xSg/V8t9I0jyN6khpTWVGzLE9knw4PhMhftk94etpAmxaXGFfgRi9BPGNo5cCDDw 4f4Ev2LY3cpHDLFEP3QZWOY/Mh2QpAzv/zipaoXvXAEbh0gveUtVBJXQditOCerH5cgM D6YLNisqEBh2Z2o/ucyFEihxtOHf0r4BV1uM4/CFVYRWQZtpb9uYxzNN1uAnZpZlTI9B CA30hAUiMChKL0p21sW18sA2q+UamqgwbjGAViXO8iQfKefBdKXJY/sdjLQlw1Agp4LY sbrFVFDO73Cc9WNcVVg3jDAyyRc1xry2VgiY0zyF2BhgvPZaqFXJR+g8XO6iBhMivFM1 gpPQ== X-Forwarded-Encrypted: i=1; AJvYcCW1j33FF8hHVbdTo/17JgSaIbzBqE5YqwD6QwUV1WnviRtEHiHNHaMOQ+vBZUuUy/xbp0Y1NRFO2W82LrA=@vger.kernel.org X-Gm-Message-State: AOJu0YzHBzb6tsWskS+CkAdCWbeFHhI4ndf1Z8Up/r8TkKPAD7DzJ1SC 6YPh2rNrnUa/V5GDrgTUkluwuLwy0e9bCENCB86W4CcFGlj3q/qLf7k1q1E3rrtmHG8OkxMDkrd nN8ClmCGTltOs7lYJFanvDnZI8/j0NYJVfQvs63lw8oDCVxGfoubD64Etxln+9oCfed0= X-Gm-Gg: AY/fxX6s4Knd9bw6/gEMK9xXiagGpDN7RIzdcURQEXQ8azQyC5MkpJ/DligANXapXuq 21doXgSn68EhylKDYvWkiGm6y3QL5LPhUmQYmhLPQKux/rgOc0fm8hDfrl0kXbKZAB0YzQfD1C9 tIY1MJseQz+/z3nH4P5ZE9FIRhpDvq6Fd3qnceFtALAH+oDtoXfrys0m2+XhZBr6fL+6128aImv kKEmIn3s3c9Ws7azuIRqDl+1kdvIYeh8al1/WKCPBuPQImdoJxNQ6uTqAiF3qJWsB5Bf87Zt8yW DE922BIKwJDLM8DW4tify31b21yZpt9qhTx8UOcv5Kajs21YRgbEn3P2HJN3V21WiDM6JLVS5rU EmO6Q23w+jO+f4EBBVKkYYoXbBEEFYN2AyQtGQPvUTqPMYerzAu+L4/aYI0EANwO6ug== X-Received: by 2002:a05:622a:5c8:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4f4abd173a9mr354272001cf.3.1767022763636; Mon, 29 Dec 2025 07:39:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHN4U3BzOmAKYg1rjSuR+S+ey+f7NfZQwB9jAllO+pOp4YI5Ip8XRHO1clZOJqarYKVd1WNMg== X-Received: by 2002:a05:622a:5c8:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4f4abd173a9mr354271661cf.3.1767022763136; Mon, 29 Dec 2025 07:39:23 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b910601c7sm31896142a12.14.2025.12.29.07.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 07:39:21 -0800 (PST) Message-ID: Date: Mon, 29 Dec 2025 16:39:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT] arm64: dts: qcom: sm6125-ginkgo: Fix missing msm-id subtype To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gabriel Gonzales References: <20251229142806.241088-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251229142806.241088-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: D7lyz9wLDobOYD6KTtX1HgdQe9_J_teG X-Proofpoint-GUID: D7lyz9wLDobOYD6KTtX1HgdQe9_J_teG X-Authority-Analysis: v=2.4 cv=coiWUl4i c=1 sm=1 tr=0 ts=6952a0ac cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=qntHbeqAf4i1FaGKydUA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDE0MyBTYWx0ZWRfX3f2F4B8DELVb zDcOrfoMHRycunwbfBpJnitNXV+zo96rQeBFrqW/G7xvpuGyA0OC7lhqhwttsTzuv98r+HWWIOK GqcBW2CBoBfy1DivKpCtWdEZs81fkIkSxwOL6OUVkc0ZPaJ7MRGfTILk/aMWjr0upuSgz1oecFr WisVwRS8kQ38fd8DOH2+QZpvB/AXjKSlaDUdvyjFkrYJ6QvQrV8zmu6UfmluaXyYjRdq+dNGcpk d3AtIPB51tI85E+dlIKhalkPDltwKTRS5F/rHc/d3HjY0Ge0ul1kGR7BUGxp7AbcWhRxj0jjpm8 lrAgaZJqNVELRS6limVvpGKGoQ5j8ObrS29SMyBhwllpejKU0z4j8SiqXi2+x2Fs0xL6OahGdB6 o2HnfE9PJAkZSZ6u3QJOm1Ro2vC36EYKnCsEhIQ5BWFGWV96Ia3yB5I4G8PA6LGYQ3gE1R4cgQ1 lQdt1R7yhg0OyUWCfIQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_05,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290143 On 12/29/25 3:28 PM, Krzysztof Kozlowski wrote: > qcom,msm-id property must consist of two numbers, where the second > number is the subtype, as reported by dtbs_check: > > sm6125-xiaomi-ginkgo.dtb: / (xiaomi,ginkgo): qcom,msm-id:0: [394] is too short > > Xiaomi vendor DTS for Trinket IDP and QRD boards uses value of 0x10000, > so put it here as well. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts > index 68a237215bd1..6b68e391cf3e 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts > @@ -19,7 +19,7 @@ / { > chassis-type = "handset"; > > /* required for bootloader to select correct board */ > - qcom,msm-id = ; > + qcom,msm-id = ; +Gabriel (the original contributor) could you please confirm the phone still boots with that? Konrad