From: "Viktor Jägersküpper" <viktor_jaegerskuepper@freenet.de>
To: LKML <linux-kernel@vger.kernel.org>, stable <stable@vger.kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sasha Levin" <sashal@kernel.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Viktor Jägersküpper" <viktor_jaegerskuepper@freenet.de>
Subject: "Fixes:" tags on commits with Cc: stable
Date: Fri, 14 Aug 2026 19:20:57 +0200 [thread overview]
Message-ID: <db97cf96-e7c8-437b-9069-0952c62b023a@freenet.de> (raw)
Hi,
regarding a recent fix for AMDGPU which was tagged with Cc: stable, Greg
wrote that the "Fixes:" tag in that commit was wrong from his point of
view: It referenced a commit which was not contained in the mainline
kernel, but only in the drm-next branch (for the next merge window). The
patch from the referenced commit had been cherry-picked for the mainline
kernel via the drm-fixes branch, so Greg argued that the "Fixes:" tag
should have referenced that commit because a reference to a non-mainline
commit doesn't work with the stable team's tooling, which was confirmed
by Sasha.
However, Alex mentioned that some time ago it was determined that the
"Fixes" tag should reference the original commit (drm-next is upstream
for drm-fixes I guess) so that you could follow the cherry-pick -x chain.
As far as I can tell, the documentation doesn't say explicitly what is
correct. Since this issue might be relevant for more people, I'm asking
for a clarification so that the issue can be avoided in the future. Most
likely the documentation should be made clear on this matter.
Regards,
Viktor
next reply other threads:[~2026-08-14 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 17:20 Viktor Jägersküpper [this message]
2026-08-15 5:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db97cf96-e7c8-437b-9069-0952c62b023a@freenet.de \
--to=viktor_jaegerskuepper@freenet.de \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®